git: 1da1ad38d073 - main - tests/netpfil: reference manual pages in atf_skip statements
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Wed, 14 Oct 2026 19:35:16 UTC
The branch main has been updated by glebius:
URL: https://cgit.FreeBSD.org/src/commit/?id=1da1ad38d0731fb39e6685383fa9aa0a503b241f
commit 1da1ad38d0731fb39e6685383fa9aa0a503b241f
Author: Gleb Smirnoff <glebius@FreeBSD.org>
AuthorDate: 2026-10-13 06:35:56 +0000
Commit: Gleb Smirnoff <glebius@FreeBSD.org>
CommitDate: 2026-10-14 19:35:07 +0000
tests/netpfil: reference manual pages in atf_skip statements
For those modules that don't have a manual page spell out full name of a
loadable module.
---
tests/sys/netpfil/common/nat.sh | 2 +-
tests/sys/netpfil/common/utils.subr | 14 +++++++-------
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/tests/sys/netpfil/common/nat.sh b/tests/sys/netpfil/common/nat.sh
index 2b828dc03fdc..5f44be9e2577 100644
--- a/tests/sys/netpfil/common/nat.sh
+++ b/tests/sys/netpfil/common/nat.sh
@@ -103,7 +103,7 @@ userspace_nat_body()
firewall_init $firewall
if ! kldstat -q -m ipdivert; then
- atf_skip "This test requires ipdivert module loaded"
+ atf_skip "This test requires divert(4)"
fi
epair_host_nat=$(vnet_mkepair)
diff --git a/tests/sys/netpfil/common/utils.subr b/tests/sys/netpfil/common/utils.subr
index f5013098f5f2..fd4a842f31c4 100644
--- a/tests/sys/netpfil/common/utils.subr
+++ b/tests/sys/netpfil/common/utils.subr
@@ -86,21 +86,21 @@ firewall_init()
if [ ${firewall} == "ipfw" ]; then
if ! kldstat -q -m ipfw; then
- atf_skip "This test requires ipfw"
+ atf_skip "This test requires ipfw(4)"
elif [ $(sysctl -n net.inet.ip.fw.default_to_accept) -ne 1 ]; then
atf_skip "ipfw tests require net.inet.ip.fw.default_to_accept=1 tunable"
fi
elif [ ${firewall} == "pf" ]; then
if [ ! -c /dev/pf ]; then
- atf_skip "This test requires pf"
+ atf_skip "This test requires pf(4)"
fi
elif [ ${firewall} == "ipf" ]; then
if ! kldstat -q -m ipfilter; then
- atf_skip "This test requires ipf"
+ atf_skip "This test requires ipf(4)"
fi
elif [ ${firewall} == "ipfnat" ]; then
if ! kldstat -q -m ipfilter; then
- atf_skip "This test requires ipf"
+ atf_skip "This test requires ipf(4)"
fi
else
atf_fail "$fw is not a valid firewall to initialize"
@@ -113,7 +113,7 @@ dummynet_init()
firewall=$1
if ! kldstat -q -m dummynet; then
- atf_skip "This test requires dummynet"
+ atf_skip "This test requires dummynet(4)"
fi
case $firewall in
@@ -121,7 +121,7 @@ dummynet_init()
# Nothing. This is okay.
;;
*)
- atf_skip "${firewall} does not support dummynet"
+ atf_skip "${firewall} does not support dummynet(4)"
;;
esac
}
@@ -131,7 +131,7 @@ nat_init()
firewall=$1
if [ ${firewall} == "ipfw" ]; then
if ! kldstat -q -m ipfw_nat; then
- atf_skip "This test requires ipfw_nat"
+ atf_skip "This test requires ipfw_nat.ko loaded"
fi
fi
}