From nobody Tue Oct 13 13:08:59 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j3vmW2Qjgz6whKQ for ; Tue, 13 Oct 2026 13:08:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4j3vmW1whSz3Bmq for ; Tue, 13 Oct 2026 13:08:59 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791896939; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/X829JiJJkDQm9tCkIkMhlPdxbwGUhhDeS8V07N8qOI=; b=DQcc0qwpp7pcd7si+NAvtYMuhZEu3GSsE+1jPE4Sks6W81DRkmcrcMewG6GPHv7grXc2Po kan9vgKz0Gpi/vYLFJVcFfHH/gVbBzQ3eSCC0cs1GM1h6/dd3zMlDk1uHTN92oG5o9xXW/ S9YGbmwJwonbLOHHxM/3rhNydije+YerQvMoyE+z9B88yIlJqdiBbH73g2JsbyDG1LffhM qXBrqgqpn9yVRxmY0zUsUxFee/fBVAikqClc/Ll2KKjDlFQAjERDn5t5pT8AHhyL69jErn zytNqnXhHtVUeWf3RjVUGCuv8CLg9WSHOqg3jVrNiDIaBIGEE/Hf3itQQ7PRfQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1791896939; b=mgadvf/CBipo2pqvyt3e1WRCzT58B7ZLcpNJD82LzziSyxm5eZ9HjTMq3Im8ydRoZaFRZT t3c1S7P5NkYA9vu0k2WvV1CwmuwmhbGFYkDMAZ2X5NWoL5Etn/NxQ5KA2gAvJlEyHrgqiM W03ZYojOXf12gmnTdfygV2/hxJP/5mzEigXwLgSg5tl00jHfxNnzT8voDYY7/wpcmpIxzB LNliiBzaF/9JBl3Zh+5I9GKy6ZFDlPAumDLtIIMxzq0dAx6SIynAd9k0cjg3BcgrjRmiI9 O8yLuHTytoZPc5I+OWWGMrDtw4iZCfSdPkiIc8+7sLT53ocPP6V85rAYO3hNhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791896939; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/X829JiJJkDQm9tCkIkMhlPdxbwGUhhDeS8V07N8qOI=; b=TQPaYmXNAiRrLzhc/D+t07Jihdg5fiyxpvK/5r1s5dgdJNjdyENgWqUpUk9YDiAo4w/H75 Tr1/aKS6CHSocze4Iqxi9rP00pJ6rwoYF/9YdpcaWLxtgcBN/r9ba2Se8d9JEg0qgCfU/4 P/ShIB/mj2T7HwatqTfeS3oq+PJwm+mV38uSknnl4sCsQk0AIKRBcC6VHGmK52qVKMF6fC W48/bKiMZ6S27yUIeH2AMjmX8H9LIPISqykvkx/89adE8pG6Ohzlt+loyezbfP8s/nNCki wvuZ/bKDN2YwXu2gPovG76xGKe/wrhjAK52zE0avu8HTgXHQhv5fq3Zq3dY6DA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4j3vmW0jr1zFrR for ; Tue, 13 Oct 2026 13:08:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3f059 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 13 Oct 2026 13:08:59 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andrew Gallatin Subject: git: f4ff995e361f - main - pfil: Avoid potential mbuf tag leak List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: Commit messages for the main branch of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: gallatin X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f4ff995e361fa72cea240c4dbac2d0931965c80f Auto-Submitted: auto-generated Date: Tue, 13 Oct 2026 13:08:59 +0000 Message-Id: <6ace2d6b.3f059.39514407@gitrepo.freebsd.org> The branch main has been updated by gallatin: URL: https://cgit.FreeBSD.org/src/commit/?id=f4ff995e361fa72cea240c4dbac2d0931965c80f commit f4ff995e361fa72cea240c4dbac2d0931965c80f Author: Andrew Gallatin AuthorDate: 2026-10-13 13:01:26 +0000 Commit: Andrew Gallatin CommitDate: 2026-10-13 13:08:18 +0000 pfil: Avoid potential mbuf tag leak In '398254f9999e mbuf: simplify m_free' we removed tag processing on m_free() of M_NOFREE mbufs. It is possible that a packet filter could attach a tag to this stack mbuf and call m_free() on it, meaning that 398254f9999e may have introduced a tag leak. However,if a tag is attached without anyone calling m_free(), then this leak was pre-existing. Reviewed by: glebius Differential Revision: https://reviews.freebsd.org/D60686 Fixes: 398254f9999e Sponsored by: Netflix --- sys/net/pfil.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/net/pfil.c b/sys/net/pfil.c index fae150839eb3..400ea4d97fb4 100644 --- a/sys/net/pfil.c +++ b/sys/net/pfil.c @@ -139,6 +139,8 @@ pfil_fake_mbuf(pfil_mbuf_chk_t func, void *mem, u_int len, struct ifnet *ifp, */ rv = PFIL_REALLOCED; } + if (!SLIST_EMPTY(&m.m_pkthdr.tags)) + m_tag_delete_chain(&m, NULL); return (rv); }