Re: git: c01c0a27cb82 - main - openssl: make libcrypto export the same symbols as upstream
Date: Sun, 11 Oct 2026 16:34:31 UTC
> On Oct 11, 2026, at 9:21 AM, Enji Cooper (yaneurabeya) <yaneurabeya@gmail.com> wrote: > > >> On Oct 11, 2026, at 2:42 AM, Konstantin Belousov <kib@FreeBSD.org> wrote: > > > … > >>> Yes: the reason is that we should strive to promise compatibility, even to our >>> own bugs. It doesn't hurt to put these symbols in as compat symbols (which in >>> particular should mean that they won't be accessible by newly compiled binaries), >>> as the routines do in fact exist. >>> >>> With the next major version of FreeBSD we can then do a somajor bump and get >>> rid of them if desired. >> >> I fully support both the opinion expressed by Robert, and the proposed >> solution. >> >> In fact, there _is_ the observable consequence of the ABI breakage. >> The need to be careful and upgrade libcrypto and libssl simultaneously >> is exactly the breakage. > > > Ok, I understand the concern now and agree. Point noted for the future since I was a reviewer. > Gordon: could you readd the symbols to a compat section? > Thank you, > -Enji > > PS The whole major/minor SHLIB_NAME/SHLIB_LINK concept isn’t supported in bsd.lib.mk, but it’s available in contrib/bmake/mk/lib.mk. I’ll work with sjg@ to introduce that support and we can work towards removing the symbols and bumping the SHLIB_VERSION at a later date. I filed a followup issue to track what I described in the `PS` section: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=299312.