From nobody Sun Oct 11 15:32:18 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j2l2v6Q2Kz6vJ4j; Sun, 11 Oct 2026 15:32:23 +0000 (UTC) (envelope-from bz@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4j2l2v61zMz3KNs; Sun, 11 Oct 2026 15:32:23 +0000 (UTC) (envelope-from bz@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791732743; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qt0KM+hI4Mg3i/xRDj4NMsnBCcidJ435E5uHUwD7mGU=; b=vIV+SNyhhNVCX9ubaovLC6yhzMevYRKXlfcSCFPfCHWr+GpBCWOXAfGOgNiRlb0gbBl7dI zaXrc6sJVIgu7c0VlVV6OeYaHGEGW9bPGWmA5GI3FdD+7m7jxmHDTDAAd/tS5RUhuvE34e jJFdxjyFDb/cNZlzXjxB17i4cNcuECJvD9V0M7tzfR5eaBX79NGB7Dj/UJ8YA7e0Okjj+Z YRehrXDKw9VjWWh4p5r7x3YfsRW3Q7umYAo/wYGKzrYDUlBUlATdtcwWplK+OB9ZirRlxO Mfj+2BFko/pEW3wCv60oMdXhAyLE2Ep7YKHGsu9O71wLnie+khR0bHoF0PpkVQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1791732743; b=VZiI4iVVdLErNAiJsOYS/ET9Z8gzyRBmCErdM0U8NvxzU3df+B0TU0At563l1ru60Nl1Fx uneezo1rgFpRmknu7VJSdFXtFiJJsfeTV3wehpNmSS4NO1cqS7uQqOiBh8enVd20nLwpdL 2Z3F6A2OYkNXBituKkeOCsgrSqvuQwyIAWZ8mqHwWDttRAFn9XOLLtBA5DcPEpReNTWbGb DhVcnzgCSZdWMh/lxjGnGLgprs332KYR5z5VuHsKyo04rX4xdLSCHwiz/hMusp9t2wjwv8 HszBCY4Bwe6JtCcw58PX5roxhd/1Zy4x5+EzGeeBvWr4VM2Ni5RFujpm6JdPiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791732743; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qt0KM+hI4Mg3i/xRDj4NMsnBCcidJ435E5uHUwD7mGU=; b=LmSc/rTkjjaKY7wI/uh0vnxLVYDuDj75GHM+eZdx+tqjJKPUawgOJ9A+ATPjABGT5hzrll bbaSKNXueKNzr0rvjFO+5OGr30LioNqRSEmikF6VkXM+M1WZj14bLT7DxYF7ZeSXgA7KmN wLjf1MlWIZwKNxHjVLdaxHZrOxel5mmEMv+GpKOaTf16fDpbtThM4EaYN+IMWSavTbStuL YvxrfJh2lI0Nz3eRw9EhfvLl77tBPtI2EcO5ip/emjZBNvzrmMt/f8xdePtjcuni+4kNyO BiJpzBYrX02oe0Tc9Wd2pCD65rW4phnGHV8lctvDR4uApgFV0HSfiv7SA1VXeA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from mx-01.divo.sbone.de (mx-01.divo.sbone.de [IPv6:2003:a:140a:2200:6:594:fffe:19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (prime256v1) client-digest SHA256) (Client CN "mx-01.divo.sbone.de", Issuer "YE1" (not verified)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4j2l2v3XwrzrWP; Sun, 11 Oct 2026 15:32:23 +0000 (UTC) (envelope-from bz@freebsd.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mx-01.divo.sbone.de (Postfix) with ESMTPS id B34D06195707; Sun, 11 Oct 2026 15:32:19 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 8CE352D029EC; Sun, 11 Oct 2026 15:32:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id mo8M4NZvZxvX; Sun, 11 Oct 2026 15:32:18 +0000 (UTC) Received: from nv.t4-02.sbone.de (nv.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 4B7E52D029D8; Sun, 11 Oct 2026 15:32:18 +0000 (UTC) Date: Sun, 11 Oct 2026 15:32:18 +0000 (UTC) From: "Bjoern A. Zeeb" To: Nuno Teixeira cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 9820afb99e6f - main - LinuxKPI: introduce LINUXKPI_DEBUG to enable LinuxKPI debugging In-Reply-To: Message-ID: <69os47n0-559-rr7o-qps-p322so714380@serrofq.bet> References: <6aca83ef.2233a.71da542a@gitrepo.freebsd.org> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: Commit messages for the main branch of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="0-1148630532-1791732738=:11296" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --0-1148630532-1791732738=:11296 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT On Sun, 11 Oct 2026, Nuno Teixeira wrote: > Hello Bjoern, > > I've just update my laptop world and poudriere jail to > main-n290042-9f0432041b8f: Sun Oct 11 > and graphics/drm-612-kmod failed to build: > > > --- dma-fence-array.o --- > In file included from > /wrkdirs/usr/ports/graphics/drm-612-kmod/work/drm-kmod-drm_v6.12.110_1/drivers/dma-buf/dma-fence-array.c:29: > In file included from > /wrkdirs/usr/ports/graphics/drm-612-kmod/work/drm-kmod-drm_v6.12.110_1/linuxkpi/bsd/include/linux/dma-fence-array.h:30: > In file included from > /wrkdirs/usr/ports/graphics/drm-612-kmod/work/drm-kmod-drm_v6.12.110_1/linuxkpi/bsd/include/linux/dma-fence.h:31: > In file included from > /usr/src/sys/compat/linuxkpi/common/include/linux/wait.h:36: > /usr/src/sys/compat/linuxkpi/common/include/linux/spinlock.h:32:10: fatal > error: 'opt_linuxkpi.h' file not found > 32 | #include "opt_linuxkpi.h" > | ^~~~~~~~~~~~~~~~ > --- dma-buf.o --- > In file included from > /wrkdirs/usr/ports/graphics/drm-612-kmod/work/drm-kmod-drm_v6.12.110_1/drivers/dma-buf/dma-buf.c:53: > In file included from > /wrkdirs/usr/ports/graphics/drm-612-kmod/work/drm-kmod-drm_v6.12.110_1/linuxkpi/gplv2/include/linux/dma-buf.h:29: > In file included from > /usr/src/sys/compat/linuxkpi/common/include/linux/file.h:39: > In file included from > /usr/src/sys/compat/linuxkpi/common/include/linux/fs.h:39: > In file included from > /usr/src/sys/compat/linuxkpi/common/include/linux/wait.h:36: > /usr/src/sys/compat/linuxkpi/common/include/linux/spinlock.h:32:10: fatal > error: 'opt_linuxkpi.h' file not found > 32 | #include "opt_linuxkpi.h" > | ^~~~~~~~~~~~~~~~ > > > Thanks, This got added to LINUXKPI_GENSRC (see below). I did a clean universe for amd64, arm64, and riscv including drm-kmod master branch (and I am sure all the other branches as well as all my desktops/laptops over the last year since this was stuck in review--multiple times). Hmm, this is just another DOH moment... and I admit ... oh well. Yeah, I never build drm-kmod outside my src builds. I am not sure why drm-kmod does not use the supplied general lists for includes and generic sources to add but yeah, that ain't work. If no one beats me to it, I'll open yet another pull request later, first just to add opt_linuxkpi.h which will need to be applied to all supported drm-kmod branches. Thanks for letting me know. Mind you https://reviews.freebsd.org/D60207 would make that all easier right away but it's not there yet but it'll likely cleanup quite some bits then. > Bjoern A. Zeeb escreveu (sábado, 10/10/2026 à(s) 19:29): > >> The branch main has been updated by bz: >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=9820afb99e6fdc471cb820f321530c52ed2c31ac >> >> commit 9820afb99e6fdc471cb820f321530c52ed2c31ac >> Author: Bjoern A. Zeeb >> AuthorDate: 2025-11-25 17:17:55 +0000 >> Commit: Bjoern A. Zeeb >> CommitDate: 2026-10-10 18:28:33 +0000 >> >> LinuxKPI: introduce LINUXKPI_DEBUG to enable LinuxKPI debugging >> >> This allows us to build kernels which will (if the sysctl is enabled >> too) show pr_debug() and pr_devel() output. >> >> Enable it by default for debug kernels. >> >> This option can later also be used for other LinuxKPI parts, like >> skbuffs, netdevice, rcu, ... to conditionally compile in debugging >> support to further justify its existence beyond an in-code #define. >> >> Sponsored by: The FreeBSD Foundation >> MFC after: 3 days >> Reviewed by: dumbbell, emaste >> Differential Revision: https://reviews.freebsd.org/D54060 >> --- >> sys/compat/linuxkpi/common/include/linux/kernel.h | 6 ++++-- >> sys/conf/kmod.mk | 1 + >> sys/conf/options | 3 +++ >> sys/conf/std.debug | 1 + >> sys/conf/std.nodebug | 1 + >> 5 files changed, 10 insertions(+), 2 deletions(-) >> >> diff --git a/sys/conf/kmod.mk b/sys/conf/kmod.mk >> index c35116dfcaa8..c2081be0da5a 100644 >> --- a/sys/conf/kmod.mk >> +++ b/sys/conf/kmod.mk >> @@ -103,6 +103,7 @@ LINUXKPI_GENSRCS+= \ >> pci_iov_if.h \ >> pcib_if.h \ >> vnode_if.h \ >> + opt_linuxkpi.h \ >> opt_stack.h >> >> .if ${MK_USB} != "no" --0-1148630532-1791732738=:11296--