From nobody Sun Oct 11 09:42:17 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j2bHC5Tynz6vQxr; Sun, 11 Oct 2026 09:42:31 +0000 (UTC) (envelope-from kib@freebsd.org) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4j2bHB5lVzz4KCD; Sun, 11 Oct 2026 09:42:30 +0000 (UTC) (envelope-from kib@freebsd.org) Authentication-Results: mx1.freebsd.org; dkim=none; spf=softfail (mx1.freebsd.org: 2001:470:d5e7:1::1 is neither permitted nor denied by domain of kib@freebsd.org) smtp.mailfrom=kib@freebsd.org; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=freebsd.org (policy=none) Received: from tom.home (kib@localhost [127.0.0.1] (may be forged)) by kib.kiev.ua (8.18.1/8.18.1) with ESMTPS id 69B9gHAq086824 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sun, 11 Oct 2026 12:42:20 +0300 (EEST) (envelope-from kib@freebsd.org) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 69B9gHAq086824 Received: (from kostik@localhost) by tom.home (8.18.1/8.18.1/Submit) id 69B9gHZb086823; Sun, 11 Oct 2026 12:42:17 +0300 (EEST) (envelope-from kib@freebsd.org) X-Authentication-Warning: tom.home: kostik set sender to kib@freebsd.org using -f Date: Sun, 11 Oct 2026 12:42:17 +0300 From: Konstantin Belousov To: Robert Clausecker Cc: Gordon Tetlow , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: c01c0a27cb82 - main - openssl: make libcrypto export the same symbols as upstream Message-ID: References: <6ac806da.36b2d.5a40f66f@gitrepo.freebsd.org> <6A686A43-F8C3-4E70-AD36-1F0AF9BA0B8B@freebsd.org> List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: Commit messages for the main branch of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=4.0.2 X-Spam-Checker-Version: SpamAssassin 4.0.2 (2025-08-27) on tom.home X-Spamd-Bar: / X-Spamd-Result: default: False [0.00 / 15.00]; MIME_GOOD(-0.10)[text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : No valid SPF, No valid DKIM,none]; ARC_NA(0.00)[]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US]; MIME_TRACE(0.00)[0:+]; FREEFALL_USER(0.00)[kib]; TO_DN_SOME(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; HAS_XAW(0.00)[]; RCVD_TLS_LAST(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MISSING_XM_UA(0.00)[]; R_SPF_SOFTFAIL(0.00)[~all:c]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_FIVE(0.00)[5] X-Rspamd-Queue-Id: 4j2bHB5lVzz4KCD On Sun, Oct 11, 2026 at 07:21:16AM +0000, Robert Clausecker wrote: > Hi Gordon, > > On Sat, Oct 10, 2026 at 10:53:33PM -0400, Gordon Tetlow wrote: > > On 9 Oct 2026, at 16:24, Robert Clausecker wrote: > > > > > Hi, > > > > > > On Fri, Oct 09, 2026 at 11:15:56PM +0300, Konstantin Belousov wrote: > > >> On Thu, Oct 08, 2026 at 09:10:50PM +0000, Gordon Tetlow wrote: > > >>> The branch main has been updated by gordon: > > >>> > > >>> URL: https://cgit.FreeBSD.org/src/commit/?id=c01c0a27cb82ca40ed507889c8f78fb2dcf76568 > > >>> > > >>> commit c01c0a27cb82ca40ed507889c8f78fb2dcf76568 > > >>> Author: Gordon Tetlow > > >>> AuthorDate: 2026-10-08 21:10:10 +0000 > > >>> Commit: Gordon Tetlow > > >>> CommitDate: 2026-10-08 21:10:34 +0000 > > >>> > > >>> openssl: make libcrypto export the same symbols as upstream > > >>> > > >>> Make the libcrypto Version.map export the same symbol names as upstream > > >>> 3.5.8 (and 3.5.9, no new symbols were added). > > >>> > > >>> Remove 52 names that upstream does not export: > > >>> - the internal threading and record layer functions (ossl_crypto_*, > > >>> ssl3_cbc_*, tls1_cbc_*), which only libssl used; > > >>> - the internal WPACKET_quic_* functions; > > >>> - OPENSSL_cpuid_setup; > > >>> - ASN.1 item functions that are not in util/libcrypto.num. > > >> > > >> Removing versioned symbol warrants dso name change, generally. I did not > > >> claim that it is required, but if we are serious about ABI for openssl > > >> libs in base, then it is. > > > > > > Can we keep the symbols with a legacy ABI version as compat symbols? > > > > The removed exports were leaked symbols that were internal to libcrypto. > > Nothing in the base system used them, and anything in ports using the ports > > version of OpenSSL wouldn’t have been able to use them either. Given that, > > is there a reason we should carry these exports forward? > > Yes: the reason is that we should strive to promise compatibility, even to our > own bugs. It doesn't hurt to put these symbols in as compat symbols (which in > particular should mean that they won't be accessible by newly compiled binaries), > as the routines do in fact exist. > > With the next major version of FreeBSD we can then do a somajor bump and get > rid of them if desired. I fully support both the opinion expressed by Robert, and the proposed solution. In fact, there _is_ the the observable consequence of the ABI breakage. The need to be careful and upgrade libcrypto and libssl simultaneously is exactly the breakage.