git: 62e958df018a - main - zfs: drop duplicate `vfs.zfs.metaslab.condense_pct` sysctl
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sat, 10 Oct 2026 07:13:27 UTC
The branch main has been updated by ngie:
URL: https://cgit.FreeBSD.org/src/commit/?id=62e958df018a0af83252c4e8f63208be41fc14a8
commit 62e958df018a0af83252c4e8f63208be41fc14a8
Author: Christos Longros <chris.longros@gmail.com>
AuthorDate: 2026-10-10 07:11:03 +0000
Commit: Enji Cooper <ngie@FreeBSD.org>
CommitDate: 2026-10-10 07:11:14 +0000
zfs: drop duplicate `vfs.zfs.metaslab.condense_pct` sysctl
`metaslab.c` already registers this tunable via `ZFS_MODULE_PARAM`, so the
`SYSCTL_UINT` here is a second registration of the same leaf. This
resulted in messages like:
```
sysctl_register_oid: can't re-use a leaf (vfs.zfs.metaslab.condense_pct)
```
Remove the duplicate sysctl registration, as upstream (OpenZFS) did.
MFC after: 1 week
Signed-off-by: Christos Longros <chris.longros@gmail.com>
Reviewed by: imp, mm, ngie
Differential Revision: https://reviews.freebsd.org/D57721
---
sys/contrib/openzfs/module/os/freebsd/zfs/sysctl_os.c | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/sys/contrib/openzfs/module/os/freebsd/zfs/sysctl_os.c b/sys/contrib/openzfs/module/os/freebsd/zfs/sysctl_os.c
index 00a027f9101e..834041f33e67 100644
--- a/sys/contrib/openzfs/module/os/freebsd/zfs/sysctl_os.c
+++ b/sys/contrib/openzfs/module/os/freebsd/zfs/sysctl_os.c
@@ -513,19 +513,6 @@ param_set_active_allocator(SYSCTL_HANDLER_ARGS)
return (param_set_active_allocator_common(buf));
}
-/*
- * The in-core space map representation is more compact than its on-disk form.
- * The zfs_metaslab_condense_pct determines how much more compact the in-core
- * space map representation must be before we compact it on-disk.
- * Values should be greater than or equal to 100.
- */
-extern uint_t zfs_metaslab_condense_pct;
-
-SYSCTL_UINT(_vfs_zfs_metaslab, OID_AUTO, condense_pct,
- CTLFLAG_RWTUN, &zfs_metaslab_condense_pct, 0,
- "Condense on-disk spacemap when it is more than this many percents"
- " of in-memory counterpart");
-
extern uint_t zfs_remove_max_segment;
SYSCTL_UINT(_vfs_zfs, OID_AUTO, remove_max_segment,