git: e959f2a7d8a8 - main - ctf*: exit with error upon terminate()

From: Ed Maste <emaste_at_FreeBSD.org>
Date: Fri, 09 Oct 2026 18:46:47 UTC
The branch main has been updated by emaste:

URL: https://cgit.FreeBSD.org/src/commit/?id=e959f2a7d8a8ac942983328f91cd5c566e3f72cb

commit e959f2a7d8a8ac942983328f91cd5c566e3f72cb
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2024-02-04 21:47:50 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2026-10-09 18:23:42 +0000

    ctf*: exit with error upon terminate()
    
    The initial port of the CTF tools had a FreeBSD-specific patch to print
    the termination message but exit with a 0 status, with a goal of getting
    as much to build as possible and silently ignoring any issues.
    
    We're now past the point where silently ignoring failures makes sense.
    Any future issues need to be found and addressed.
    
    PR:             276826
    PR:             276930 [exp-run]
    Reviewed by:    markj
    Sponsored by:   The FreeBSD Foundation
    Differential Revision: https://reviews.freebsd.org/D43743
---
 cddl/contrib/opensolaris/tools/ctf/cvt/util.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/cddl/contrib/opensolaris/tools/ctf/cvt/util.c b/cddl/contrib/opensolaris/tools/ctf/cvt/util.c
index 0eda56dbf65a..5139725bb9cf 100644
--- a/cddl/contrib/opensolaris/tools/ctf/cvt/util.c
+++ b/cddl/contrib/opensolaris/tools/ctf/cvt/util.c
@@ -149,17 +149,7 @@ terminate(const char *format, ...)
 
 	if (getenv("CTF_ABORT_ON_TERMINATE") != NULL)
 		abort();
-#if defined(__FreeBSD__)
-/*
- * For the time being just output the termination message, but don't
- * return an exit status that would cause the build to fail. We need
- * to get as much stuff built as possible before going back and
- * figuring out what is wrong with certain files.
- */
-	exit(0);
-#else
 	exit(1);
-#endif
 }
 
 /*PRINTFLIKE1*/