From nobody Fri Oct 09 15:21:48 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j1Vvv6qrbz6vccx for ; Fri, 09 Oct 2026 15:22:03 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4j1Vvt3W82z4Vf3 for ; Fri, 09 Oct 2026 15:22:02 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of jrtc27@jrtc27.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=jrtc27@jrtc27.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none) Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4a17baef589so32498895e9.0 for ; Fri, 09 Oct 2026 08:22:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791559321; x=1792164121; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:content-type:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6/Xs/CBXfG1Ne1Iu8bh149UTWWFLCytApW/D7NpPYWE=; b=bb/m8YuVuakVKTIkD3TyVd06EWdgwQVGmVCeCRU4WwDfUOhGFrPD1fnwVtByfdzx9H fJsfULeFapugBF5N8998Wwi4B9zrkgEgm1l7DwIZEEnMgB5Z2MMGoMkqKPbM4y5JZRnj 8psHfxvIhdrla7JBbeDYVIUXcjHPDBuHv+lIiuNOJaAhmg/75/uGwN8TcK7Pv6MP7Oe8 bVsi2hE9V4TJ0skn8vbnh2NbMXxwtWlg2C3828WdDrScI59Rxq4mi4Ygvkg64zSYsLuC /+fI/e9Ixw5b35Rkh9JgcFAx9fW+4vo6KNLGC/Y/+MANE2U4lTTxMNiwfRM60IISGKQQ u5jQ== X-Forwarded-Encrypted: i=1; AKwUvBx1taKeXlILX/j1DYlCFJ+jE/63AYVpq1fDFzZkgA0bMd4lpfpXJ8fYBbwfxf5eAedp72VSz4xABZ8DGSo0cm4G7mWNGA==@freebsd.org X-Gm-Message-State: AFuF++kXePR9z+1xk8P2bmGhrHBfToGAjpnxVHt+2migKoSpK5q7WGBZ nObjSJ4d0D0EXuzsOF7n2AnFgKWBwztB2CqOLAFPE2JVlWl835ty89TyP+NnvHtsa9E= X-Gm-Gg: AYBFou1GOAtdsHVFTXAv9i64yFKFb8ea7unOZN9igzCbTVweRx23rc1Jz+wOHvds9ft X5w78mwgEVBfTFyIMFDTYQpC5gtEKPTLBhSKYRzFsvedxDuYGWv0yEaHVFKnjnTW6KZwaQ0J80v /LvrcqvM6A7J1J4yqF8J6kR5i3VK/cYcAHtklxJ2pak9HsaBpcqEn1/X3ZdSUNcRnQ6DRGXjeOH zrKukzZCqRsZRrVYVKoPZFlDEgbltwkhsqOtUD7pWN9NGNbOnoQ4woCrYZbCbrUlrQ3md8q1WTK 0xHqSJwXsDOaPyLCo9yxPI+BmGV7Z3v3WFpxdMjFHFMY++Ju+xSCT57N/s20PGHwxLb2HMV4NQ3 bzGrmNVco1rHmkcF5ajL1IYbLyf5JdLyI+xTK84G5k7bqDhTD3eMbsgCTB0iwAYdhcFvszaT26W MhQYb6R14qk1rziDCXoTrbwxiNI5TQd6avpsBmQu5N87FHL/HLNqqoZpDb5IjCdbVxAdV4k23vF Nyuk7k/EuqG1rmMr2sDYZuV6kBPy6BivU6+QX5GUuDCeYk= X-Received: by 2002:a05:600c:19c8:b0:4a0:1a7f:2abb with SMTP id 5b1f17b1804b1-4a18e47ab20mr44943975e9.11.1791559320708; Fri, 09 Oct 2026 08:22:00 -0700 (PDT) Received: from smtpclient.apple (nat-184-161.net.cam.ac.uk. [131.111.184.161]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a18bb68abfsm71388635e9.0.2026.10.09.08.21.58 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Oct 2026 08:21:59 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3901.100.1.1.12\)) Subject: Re: git: 24d5194306b5 - main - build: Emit a warning for build targets run as root From: Jessica Clarke In-Reply-To: <6ac9028e.3a17d.35333feb@gitrepo.freebsd.org> Date: Fri, 9 Oct 2026 16:21:48 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <6ac9028e.3a17d.35333feb@gitrepo.freebsd.org> To: Ed Maste X-Mailer: Apple Mail (2.3901.100.1.1.12) X-Spamd-Bar: / X-Spamd-Result: default: False [0.60 / 15.00]; MV_CASE(0.50)[]; FORGED_SENDER(0.30)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; MIME_GOOD(-0.10)[text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; FREEFALL_USER(0.00)[jrtc27]; TO_DN_EQ_ADDR_SOME(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.128.43:from]; R_DKIM_NA(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.128.43:from]; RCVD_COUNT_TWO(0.00)[2]; FROM_NEQ_ENVFROM(0.00)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; RCPT_COUNT_THREE(0.00)[4] X-Rspamd-Queue-Id: 4j1Vvt3W82z4Vf3 On 9 Oct 2026, at 16:04, Ed Maste wrote: >=20 > The branch main has been updated by emaste: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D24d5194306b573bf3396858b4c0aa5d4= 20c37c91 >=20 > commit 24d5194306b573bf3396858b4c0aa5d420c37c91 > Author: Ed Maste > AuthorDate: 2025-05-14 15:23:42 +0000 > Commit: Ed Maste > CommitDate: 2026-10-09 15:02:30 +0000 >=20 > build: Emit a warning for build targets run as root >=20 > Build targets should generally be run as an unprivileged user. = Even > though building as root is discouraged many users do so, so just = start > with a warning. Whilst this is surely where we eventually want to end up, as it is best practice to only use root when necessary, I=E2=80=99m not sure this is something we should be warning about just yet, especially given the official updating-from-source instructions in the handbook [1] and equivalent in-tree UPDATING instructions have you do everything as root (well, they don=E2=80=99t say that explicitly, but there=E2=80=99s no = mention of switching users, the handbook uses make kernel which has to run buildkernel as root like installkernel, and the buildworld is amongst everything else (ditto buildkernel for UPDATING)). I also suspect this interacts poorly with running etcupdate as root, which has no separation of build and install responsibilities, at least if you don=E2=80=99t use the (now default) -B, but possibly also even = with that. So I think we have a lot of things to get in order before we start emitting this warning. Jessica [1] https://docs.freebsd.org/en/books/handbook/cutting-edge/#makeworld