From nobody Fri Oct 09 15:04:46 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j1VWz0p5Gz6vbLl for ; Fri, 09 Oct 2026 15:04:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4j1VWy6bBxz4Ssw for ; Fri, 09 Oct 2026 15:04:46 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791558286; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AR0CRVA8tBu3HK59DfOfoPWQH7vGntsRh6bR/5otfRw=; b=ltfRhZ2ufuhKG8Y5zDLDCYdZR4XCUMfD/rnyGn3zxUrrdsCnsav3NKNHnXg1hC7eh4nREQ qnO92U1oRmTKvyVCpKHhKOBW2G2da81I3fcoB4KHX6myobjQ0UnXzHjpYSReDD16bqix58 RoL+D6U+xfRiTTOpmt47RfLWN5KnY2k43QwWWcFRZsN7ZHX438aslQOegZwIVz4MiILN18 c5YxRcTg6V3F634ASsemWKys44BJHwKOGHYiZH9Us2T5MZw5qt51StI4LnI4MlZ34Bz+Mb xwSr321jh2B9ycYj1LRMHOLV1XN7763F1rtnFGmXhFB8h+TBaIVyAPzqsCzMjA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1791558286; b=MOqdqk3omVqpjQxLUBQJeRPJdgblhLsY69FyJCyZcLFRgHmxz8iKleC1t0o0x1LBvuUdcl imvT2e9lRL4Rb4kkaCQIR+z88nQdiodz/fIJbTHBbGDrtL1toBGjv4NG0g4VXH2OqzzYtL rj0f3QagnUFMRKhF6FK/bc6KmQEYDmNtZEa+WQ5MsK6Eqqcrs5uTWLgmzLVMEmlyXg1hWy DWTn1iHNu7JezpisbZzOZqLc4PM9/uwEEI6Xi2sidh5A+OkCIxhcP02s4WpG1oGcDpXcF4 q8M2wu4JqiA+l/ILH1XRR8pzEw4mbOmDyGDrwMs0NNWvUI/uZkUcw49zzrgYug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791558286; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AR0CRVA8tBu3HK59DfOfoPWQH7vGntsRh6bR/5otfRw=; b=CQbJeTpRr1RkhwJgZhLG9Gc7abScay/Q4vuqeCb2dXdf3a46QzoSo1fTzAzGn3VvXJuRSd pZhKrQtXFe+IpCHuqKAjHgtUcJHhdRL0mMP5UdlD0wkeIUcOnnV00co8OUI43rYfo72tjO SYTLFID8ZtMzYBEikFmFOI4hYgDkikqs2MXwvnUGcxnRqLsjZLaEGP8I9fZJeWpSHoy6f6 h+ntqtmz3wYB0O+kMEwdC5kNeigwE3h2HMcIl8UxsEiUV+Ghk3vWRRznLfbXQBw92gWrJI +A2dU41VBE004qsSCxSJjJUp9oHaRmY02m4ABg1vChyHF+5/fn0JdSurCLhpLA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4j1VWy565DzFZs for ; Fri, 09 Oct 2026 15:04:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3a17d by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 09 Oct 2026 15:04:46 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ed Maste Subject: git: 24d5194306b5 - main - build: Emit a warning for build targets run as root List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 24d5194306b573bf3396858b4c0aa5d420c37c91 Auto-Submitted: auto-generated Date: Fri, 09 Oct 2026 15:04:46 +0000 Message-Id: <6ac9028e.3a17d.35333feb@gitrepo.freebsd.org> The branch main has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=24d5194306b573bf3396858b4c0aa5d420c37c91 commit 24d5194306b573bf3396858b4c0aa5d420c37c91 Author: Ed Maste AuthorDate: 2025-05-14 15:23:42 +0000 Commit: Ed Maste CommitDate: 2026-10-09 15:02:30 +0000 build: Emit a warning for build targets run as root Build targets should generally be run as an unprivileged user. Even though building as root is discouraged many users do so, so just start with a warning. Reviewed by: brooks Differential Revision: https://reviews.freebsd.org/D50352 --- Makefile.inc1 | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Makefile.inc1 b/Makefile.inc1 index c1dd1fe836d3..6a228a29ed5d 100644 --- a/Makefile.inc1 +++ b/Makefile.inc1 @@ -375,6 +375,10 @@ test-system-${_t}: .PHONY .elif ${MK_LLD_BOOTSTRAP} == "yes" .info SYSTEM_LINKER: libclang will be built for bootstrapping a cross-linker. .endif +BUILD_USER!= id -u +.if ${BUILD_USER} == 0 +.warning Warning: ${.TARGETS} should not be run as root +.endif .endif # End WITH_SYSTEM_COMPILER / WITH_SYSTEM_LD