From nobody Fri Oct 09 10:12:55 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j1N3F1T4lz6vRXL for ; Fri, 09 Oct 2026 10:12:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4j1N3D5YXzz4Y0N for ; Fri, 09 Oct 2026 10:12:56 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791540776; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=s50hQ20GP4cUo5aotVge9TgEB7ipb5WK3ZfY6YjDddU=; b=NM8icKqqYleFhf4RhjSko/hi2f3yiUnHavMYOvNjeuaRl1E8s0H2QEXYNEyN0Qrcvdf1VI 3IaYFMS0QVwP0FQFhnrjCJp+6ioa4WUD7sgxjtawwd0I59ndXynotNhRCmas/YJ52hDINi pRO29yJ197VHRK9EYvZeCJSpU6Mfd5JKMrJeVrv/92EuTvWBvUGYiGKi+O8XiKMohA+0sB Z2TdkI9w2DgRr2TMg8VY7Cd9VcPoLEws8/4hopHW6VgnyE21CwA+dYw21q0tOE5xUH07tM oC1TV73G9cXqOiV3XKTVijXFTF4uYHGsXyxarvE9RS7lnR9jeGnd/b4+mnAfWQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1791540776; b=FdgjGE47cP6fV497o4s8Ty3dZ/EaTHehHpsk062nK21S80+uVOxE9FZ/i006pFzOdUVwJ5 wnQ3k3R7/c5ait1FYbZzt8ulPiYJk9gl4CqV6wKjzccd/F5hn1iQdRABRRVX5/5S3Ci1OY slISk41AQ4ClA3SoY31kpvY3ux6HYXsrKE0N2Mot1XUvE0zS2ljAPSylr2qdKJWUV12N58 ManqaqiNoA1B/NHHMF0/oxq/RgIRgsQAIg3+7TiAnMeGQ5GGUNXPobjraMLGW1LmN9Fr3W iXUESl5oqWntzluHB9O4p++mZIGDQjLfCM6qVx/VQ+kYQpxHhSYNe/WfcWBGfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791540776; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=s50hQ20GP4cUo5aotVge9TgEB7ipb5WK3ZfY6YjDddU=; b=RJu5fNHAlkSwB/Obf9+F7A49rviw02bglzqm246UVQoW6tSghV0M5SOmZkc7oOZHH3TyXj g2vmRchOkjY1LD5O4y9LgJVkRf5Ckgz1KenbVgs1IzapNLsq1wIi8FPYF6K9+Kxcpax2rX 7yPT6RIsHILR3wP1PYzyDyD4PaKgPNZ+FzClkceYDHe7f7qjB8jUk9onngXA6ekH5wSPLK r410kqJ0NK4hpi2wNUHnkl1C97MED7jpNe8qx7XMXCXZikXg5myzmyg3T/zrd5mSX664td T3sIXRuZvsmH8TKMHDTmHFMiqcwQdHzEA8Om1e6Ao6M4shTRKZtEKbm1ewWJNg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4j1N3C4lnBz1LZV for ; Fri, 09 Oct 2026 10:12:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 42c25 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 09 Oct 2026 10:12:55 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Sumit Saxena From: Sumit Saxena Subject: git: 4fbb63f289ed - main - if_bnxt: drop redundant PCI disable in bnxt_fw_reset_close() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ssaxena X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4fbb63f289ed6a06e715c6882e8fff3201381743 Auto-Submitted: auto-generated Date: Fri, 09 Oct 2026 10:12:55 +0000 Message-Id: <6ac8be27.42c25.647f37f5@gitrepo.freebsd.org> The branch main has been updated by ssaxena: URL: https://cgit.FreeBSD.org/src/commit/?id=4fbb63f289ed6a06e715c6882e8fff3201381743 commit 4fbb63f289ed6a06e715c6882e8fff3201381743 Author: Sumit Saxena AuthorDate: 2026-08-01 09:07:47 +0000 Commit: Sumit Saxena CommitDate: 2026-10-09 08:24:45 +0000 if_bnxt: drop redundant PCI disable in bnxt_fw_reset_close() bnxt_fw_reset_close() unconditionally called pci_disable_device() after freeing the Rx IRQs, on every firmware reset, not just the BNXT_STATE_FW_FATAL_COND path which already disables the device via bnxt_fw_fatal_close(). BNXT_FW_RESET_STATE_ENABLE_DEV in bnxt_fw_reset_task() already re-enables the device unconditionally, so this wasn't leaving the device disabled, just adding an unnecessary PCI disable/re-enable cycle around every non-fatal reset. Reviewed by: gallatin MFC after: 2 weeks Sponsored by: Broadcom Inc. Differential Revision: https://reviews.freebsd.org/D58619 --- sys/dev/bnxt/bnxt_en/if_bnxt.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sys/dev/bnxt/bnxt_en/if_bnxt.c b/sys/dev/bnxt/bnxt_en/if_bnxt.c index 2129c0ff51b0..0c0f896f2c12 100644 --- a/sys/dev/bnxt/bnxt_en/if_bnxt.c +++ b/sys/dev/bnxt/bnxt_en/if_bnxt.c @@ -1985,8 +1985,6 @@ static void bnxt_fw_reset_close(struct bnxt_softc *bp) iflib_irq_free(bp->ctx, &bp->rx_cp_rings[i].irq); } - if (pci_is_enabled(bp->pdev)) - pci_disable_device(bp->pdev); bnxt_ktls_del_all(bp); pci_disable_busmaster(bp->dev); bnxt_clear_ktls(bp);