From nobody Fri Oct 09 10:12:52 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j1N3B2fZNz6vRQ7 for ; Fri, 09 Oct 2026 10:12:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4j1N395nmsz4YG1 for ; Fri, 09 Oct 2026 10:12:53 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791540773; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LbWD3xHUtoqpNyfBxDYe84aTTQzAElPMPKlhktVKubg=; b=dTlmEKQ6kKHhktnuN/lH8E6r9+TEbHexkua/6OSxcesWo6zTg96PF86xNAcRbe1SSgwSh6 F6ZoHgTncQFCZHB1/HzcDKsSASkpdkdTQXH3ssPnhXIsx4Tqn2+zjF6zfhv0ww+NZ6Sc7v tFJUXiYrHQwGswUmqBgLO/4wYniR8KS7IQ5TtvSLMQoW06Lagk6rwnufxWK4CeYneJJhNh Z9+PIc/Vmgo0FjDOBVZlfkOZM6ELC7h60xG73JxxfOgP1n9rUG0jpg31prJizKAAQ2RSdO ttkaC+xhdcNOhkzwdzHUAR4jaACtJJq5qWR3Zsi++K3zG3FF+x2pSX0H3HSEFQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1791540773; b=AMerr+dcbNJD2E/F6MI+0o7D1bf8eFRNzMz4Hk/TJgw8dC7DgLhLlXxHxGS6DWB7BtROIn FpqTCZ8/KQeeQEcmQFrI9eylnhT28eEUMl3gPLyjtqW492iFokrSFocUO98EwuyEYn/Li+ LK1y+WShwoA4Gf3UA5SwUuCw33TZzDKrX+PdDTOXkmE/q6WnrNFLvt4q9pEiDlz/gASlbA 04t/qRTc3DYZ8Kexdr5/bVz4TadOod+W8+VnYv55L4S131MYg4KRlcSN6S/Hm0lxAW04wo HqJMUk8XvP2hafqM/hhBRN3qOtDUEZERFz9iV6x2ZVuacxY9UJuaXk1RzyQUfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791540773; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LbWD3xHUtoqpNyfBxDYe84aTTQzAElPMPKlhktVKubg=; b=H9M0D41Ror6lgT4b1jqertkd32fI1tQ9SS754mLvDKHYH+k10FdLL4LkGP/o7IT/x2RzWT 07h6J8PdQfWl+q3f3yV+R96oism1MOjQIiZBVaQe5av5C/93xIT+xdpKlKKLSCFSO4Akfj dTZSLeWSVzJuFRISQyZE3FJHIJSV5bXCCYaPmjcwAPHexQwLc+Mm4kXroyA3QyNgXGMimr weHWh5Sb3jVjBXz3pCJp0PpaZZLRJSyPtXScBMueEBF98FojucZu9WrKZ5H9uzLZCdVv5f 2Fgw6YtYi9PxRTGTv2JXOACyCYdnhL0vkCTTYWwpyaA5T652BN9AwAbArwnsGQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4j1N382lNXz1KQj for ; Fri, 09 Oct 2026 10:12:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 42c94 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 09 Oct 2026 10:12:52 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Sumit Saxena From: Sumit Saxena Subject: git: 7781529f31b6 - main - if_bnxt: Never ARM Tx CQ as they are not interrupt-driven List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ssaxena X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 7781529f31b62a3071995b9f0446b8ded4ec8cf9 Auto-Submitted: auto-generated Date: Fri, 09 Oct 2026 10:12:52 +0000 Message-Id: <6ac8be24.42c94.5df80190@gitrepo.freebsd.org> The branch main has been updated by ssaxena: URL: https://cgit.FreeBSD.org/src/commit/?id=7781529f31b62a3071995b9f0446b8ded4ec8cf9 commit 7781529f31b62a3071995b9f0446b8ded4ec8cf9 Author: Sumit Saxena AuthorDate: 2026-07-31 16:04:34 +0000 Commit: Sumit Saxena CommitDate: 2026-10-09 08:24:44 +0000 if_bnxt: Never ARM Tx CQ as they are not interrupt-driven Tx completion rings are not interrupt-driven, so there is no need to ring the doorbell with CQ_ARMALL and toggle bits set for them. Stop arming the Tx CQ doorbell on P5+, which makes tx_cp_rings[]->toggle dead, so drop the now-unnecessary toggle bookkeeping for it in process_nq() too. Reviewed by: gallatin MFC after: 2 weeks Sponsored by: Broadcom Inc. Differential Revision: https://reviews.freebsd.org/D58616 --- sys/dev/bnxt/bnxt_en/if_bnxt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sys/dev/bnxt/bnxt_en/if_bnxt.c b/sys/dev/bnxt/bnxt_en/if_bnxt.c index e0e606189fdb..2d996d80a0f5 100644 --- a/sys/dev/bnxt/bnxt_en/if_bnxt.c +++ b/sys/dev/bnxt/bnxt_en/if_bnxt.c @@ -3758,7 +3758,7 @@ skip_def_cp_ring: goto fail; if (BNXT_CHIP_P5_PLUS(softc)) - softc->db_ops.bnxt_db_tx_cq(&softc->tx_cp_rings[i], 1); + softc->db_ops.bnxt_db_tx_cq(&softc->tx_cp_rings[i], 0); /* Allocate the TX ring */ rc = bnxt_hwrm_ring_alloc(softc, @@ -4405,7 +4405,6 @@ process_nq(struct bnxt_softc *softc, uint16_t nqid) { struct bnxt_cp_ring *cpr = &softc->nq_rings[nqid]; nq_cn_t *cmp = (nq_cn_t *) cpr->ring.vaddr; - struct bnxt_cp_ring *tx_cpr = &softc->tx_cp_rings[nqid]; struct bnxt_cp_ring *rx_cpr = &softc->rx_cp_rings[nqid]; bool v_bit = cpr->v_bit; uint32_t cons = cpr->cons; @@ -4423,7 +4422,6 @@ process_nq(struct bnxt_softc *softc, uint16_t nqid) if (NQE_CN_TYPE(nq_type) != NQ_CN_TYPE_CQ_NOTIFICATION) { bnxt_process_async_msg(cpr, (tx_cmpl_t *)&cmp[cons]); } else { - tx_cpr->toggle = NQE_CN_TOGGLE(cmp[cons].type); rx_cpr->toggle = NQE_CN_TOGGLE(cmp[cons].type); rx_cqe = true; }