From nobody Fri Oct 09 10:12:49 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j1N373gvjz6vRRP for ; Fri, 09 Oct 2026 10:12:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4j1N370Bjtz4YDK for ; Fri, 09 Oct 2026 10:12:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791540771; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jf+T+nZoaI2WOA2AOjwepsYff8A35D6E2uG3XJISjS4=; b=W+hXylp5uAbswswlAoZScVgaMevyXygk8/Qp8ixEL6qPaFQgHneWP4duAGeoDwBIBb89pO GF7nDCb3jHQ+UqgG+kqUyjIVzDYV/8LSrZi72qdxjzCU30Q4Lg4IyOYlasZ5dpk4GWWZI+ rWdXm1QS8lEof20GBaNaau4mkCtaYrqHu7zaPH2yIy0u+08dUcnXItxhXU9a9kxOVPuDvU 4BH6xm0TCBiB7iVl3GaJ/zycY8qLLyEC0E9pZWxOohDkD1zjStOxUkvD95LgZ3G+VyhblV QlJKD82hvqHaLy3ifLoRvEw9fmWJtAFOLZZXzkfvhzMHhtrdcMKXW9N4OnEJ4Q== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1791540771; b=JUZYIKzR2AicTeMWy/0Qwhs9Xxc7mNrtqJepsrKllWEVF75tZPYNJqp3fXX2ZPNR/8d3WM PkRg2bQVM+bvmNF36GFaJkdrIgBroNKuImi4Ma2qva+2Ak3sN7kaTvgBlLRQviMDBoBqKJ mK3o6ZzuQSAY2e71sA+6/E4RgS7hBtSA/G9aIiWwo11emhPxDtApI3fXoqhiocZCSepWk5 gwji4HpwzE0gfaKmS8DQgC6o5dkB2jDCAJb1QJ2V7wYxhc/S0krvFnXzoHf+POAddKVkUk e5zOEcrmKHZrd3ZWG9s+UiDcevj6soSLx2zYCJblMd0rewPjCoxHWL0ZyDoFaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791540771; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jf+T+nZoaI2WOA2AOjwepsYff8A35D6E2uG3XJISjS4=; b=WgTxXVA+dkhBLCZl6aAMoww/htgSHLLsAoGvcCYaOQUc5y/29kqCzu6fhoNXyz7uQy9/GO cd9plpyEDxZW1zfaufDkxxUNJUPiE8hTm+vSJ4WfEOQ5uxLeSBoWJekk9eRa2en0Efydtn 9z5LyxVPDmvAYr4w0nwazG74u3UuMVUPQM73M+RIk1mUyyj0yBZWMNASDtBeFjZfQGJIJz t6E8sSbmMWX99/zRHJoEHmFUAKXdm0zq6awU9SZ6ytDR0nGAPomlCbgz0BJN1k4lxgc28i CmTF/3asKlhx62cF8yBFHUm1TjetszXnVvG56nqqMhPW0HXph8s+EfHT4WXylw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4j1N350qZWz1LWv for ; Fri, 09 Oct 2026 10:12:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 41a4b by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 09 Oct 2026 10:12:49 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Sumit Saxena From: Sumit Saxena Subject: git: a8622eac118a - main - if_bnxt: Restore Rx CQ doorbell skip-when-idle optimization on P5 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ssaxena X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a8622eac118a31187be02f4dd1a53f58fc6ec35a Auto-Submitted: auto-generated Date: Fri, 09 Oct 2026 10:12:49 +0000 Message-Id: <6ac8be21.41a4b.1ca84915@gitrepo.freebsd.org> The branch main has been updated by ssaxena: URL: https://cgit.FreeBSD.org/src/commit/?id=a8622eac118a31187be02f4dd1a53f58fc6ec35a commit a8622eac118a31187be02f4dd1a53f58fc6ec35a Author: Sumit Saxena AuthorDate: 2026-07-31 15:55:56 +0000 Commit: Sumit Saxena CommitDate: 2026-10-09 08:24:44 +0000 if_bnxt: Restore Rx CQ doorbell skip-when-idle optimization on P5 The unconditional-doorbell fix for Whp/older NICs (always ring the Rx CQ doorbell after processing Rx interrupts) had also been applied to P5+ chips, discarding process_nq()'s work-done signal entirely and losing the doorbell-skip optimization on P5+ when process_nq() finds no CQ notification to act on. Make process_nq() return whether it saw a CQ notification, and only skip the Rx CQ doorbell on P5+ when it didn't; non-P5+ chips continue to always ring it, since process_nq() isn't used on that path. Reviewed by: gallatin MFC after: 2 weeks Sponsored by: Broadcom Inc. Differential Revision: https://reviews.freebsd.org/D58613 --- sys/dev/bnxt/bnxt_en/bnxt_sysctl.c | 2 +- sys/dev/bnxt/bnxt_en/if_bnxt.c | 18 +++++++++++++----- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/sys/dev/bnxt/bnxt_en/bnxt_sysctl.c b/sys/dev/bnxt/bnxt_en/bnxt_sysctl.c index cc72c4214cba..fad3982f5581 100644 --- a/sys/dev/bnxt/bnxt_en/bnxt_sysctl.c +++ b/sys/dev/bnxt/bnxt_en/bnxt_sysctl.c @@ -115,7 +115,7 @@ static const int mpc_cmp_counters_count = sizeof(mpc_cmp_counters) / sizeof(mpc_ DEFINE_MUTEX(tmp_mutex); /* mutex lock for driver */ extern void bnxt_fw_reset(struct bnxt_softc *bp); extern void bnxt_queue_sp_work(struct bnxt_softc *bp); -extern void +extern bool process_nq(struct bnxt_softc *softc, uint16_t nqid); /* * We want to create: diff --git a/sys/dev/bnxt/bnxt_en/if_bnxt.c b/sys/dev/bnxt/bnxt_en/if_bnxt.c index 25b535a67af8..6566c1e8f442 100644 --- a/sys/dev/bnxt/bnxt_en/if_bnxt.c +++ b/sys/dev/bnxt/bnxt_en/if_bnxt.c @@ -202,7 +202,7 @@ static const pci_vendor_info_t bnxt_vendor_info_array[] = SLIST_HEAD(softc_list, bnxt_softc_list) pf_list; int bnxt_num_pfs = 0; -void +bool process_nq(struct bnxt_softc *softc, uint16_t nqid); static void *bnxt_register(device_t dev); @@ -4385,7 +4385,7 @@ bnxt_process_async_msg(struct bnxt_cp_ring *cpr, tx_cmpl_t *cmpl) } } -void +bool process_nq(struct bnxt_softc *softc, uint16_t nqid) { struct bnxt_cp_ring *cpr = &softc->nq_rings[nqid]; @@ -4396,6 +4396,7 @@ process_nq(struct bnxt_softc *softc, uint16_t nqid) uint32_t cons = cpr->cons; uint32_t raw_cons = cpr->raw_cons; uint16_t nq_type, nqe_cnt = 0; + bool rx_cqe = false; while (1) { if (!NQ_VALID(&cmp[cons], v_bit)) { @@ -4409,6 +4410,7 @@ process_nq(struct bnxt_softc *softc, uint16_t nqid) } else { tx_cpr->toggle = NQE_CN_TOGGLE(cmp[cons].type); rx_cpr->toggle = NQE_CN_TOGGLE(cmp[cons].type); + rx_cqe = true; } NEXT_CP_CONS_V(&cpr->ring, cons, v_bit); @@ -4421,6 +4423,8 @@ done: cpr->raw_cons = raw_cons; cpr->v_bit = v_bit; } + + return rx_cqe; } static int @@ -4429,10 +4433,14 @@ bnxt_rx_queue_intr_enable(if_ctx_t ctx, uint16_t qid) struct bnxt_softc *softc = iflib_get_softc(ctx); if (BNXT_CHIP_P5_PLUS(softc)) { - process_nq(softc, qid); + bool ret = false; + ret = process_nq(softc, qid); softc->db_ops.bnxt_db_nq(&softc->nq_rings[qid], 1); - } - softc->db_ops.bnxt_db_rx_cq(&softc->rx_cp_rings[qid], 1); + if (ret) + softc->db_ops.bnxt_db_rx_cq(&softc->rx_cp_rings[qid], 1); + } else + softc->db_ops.bnxt_db_rx_cq(&softc->rx_cp_rings[qid], 1); + return 0; }