From nobody Fri Oct 09 07:46:43 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j1JpW421Tz6vF94 for ; Fri, 09 Oct 2026 07:46:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4j1JpW3Pc1z4KsQ for ; Fri, 09 Oct 2026 07:46:43 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791532003; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CHkyI3ML4bd9Gairdv/YtwiBwsvVZTvg9rGMb51x2aI=; b=ZBy5SMgB57bbQxB1l8F++ZRTn+DN7oVZCEvsregWIJRAWw+LWf5Y/WQv34KgVzTlwH6u0n vV0pG1B1PEl9cUnkZO47re7PdRaZWsMJ+6ilgVkOSgiJef+WRWrsB6ayIkDeNcTZZKr/KF IIndXXKdEPR6Mia1Rc0u3RuBocX8jt3WjhPhp1I6V6qvwG4VbKHubu5jsJ9upMkY7mDKPa M3/FsUb1yauEcc0urPTJJqDb0DrBHhNHNtHMRZvN/gKaIjrwkk/jUt2Q6lVWhk+23BRTa6 pkaIdg9v1KuXox1AyXMvzBNgHiJlH6Sv+6pkcx8e9zSBejCcUhcTGwSA8fMuVA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1791532003; b=rJKbNVGjoU2JMYezO8vbTBJty3bmukd1AbOFXRELye0aK9Iz40vfBAwvIX3NirnEm3rGya Sn1eihYJu850xmVJ0BMoSgzbjMGP1vPFfiK/FZ/tpa6GJ9k5JhIiLrCAiUM32KB+8B0xS1 OyX56+iZTWnxuUe/faU8i50BlJzjBuQaCDIc96bdZA8owQRHqzirNNkmH4sAhP7QeoNvsL DMfMlcp1ub5P6fFP3t6DYrUKiZeVsS9AiQ8QRB/qbsw/gQATt/sEBDjAOIi2Ra+hWVrT7U 1pEQs4N5kghYXDvuhobx/971diKxJCAtmke+Qvhq0RHC98JKqR5moKRrPAXFcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791532003; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CHkyI3ML4bd9Gairdv/YtwiBwsvVZTvg9rGMb51x2aI=; b=x0Aih3tx5PQaAZXMlt0M8UXevhLTirMeI3Iqd3FwxC5mQu2zFaPPOKEHqSJOQ5f0h21rSk 4zJKRrky/ccVqNmOl0q6sRfyOTLZpT/yv+liVVCsMijejW5ehKBwUJfFuMCwcRP7RaoWwY YVpibxmiMUeps4q2L35ev02fypL3xRkZcef1pk4Fs/FBLrlMKInCoGU3kZBT5jT+zrIpOU SDGfRtlTdoa2ar166CQOf8SO3TUCgX3a3a1DpleZn1jTtav1OmuOUwwLYuc7lPFp2CwDJ9 Y+hFKe7Bw6FhZ58b7RHYzDnrqFs3134N+rMQeshS/bpJ/qX7FlcaJ8/yphlHPg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4j1JpW2D9Rz1GLv for ; Fri, 09 Oct 2026 07:46:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 32cf4 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 09 Oct 2026 07:46:43 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Certner Subject: git: e478037df4f1 - main - systm.h: Remove unused List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e478037df4f12e3d1b6b551f05ea7ce23c096886 Auto-Submitted: auto-generated Date: Fri, 09 Oct 2026 07:46:43 +0000 Message-Id: <6ac89be3.32cf4.2a864e3f@gitrepo.freebsd.org> The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=e478037df4f12e3d1b6b551f05ea7ce23c096886 commit e478037df4f12e3d1b6b551f05ea7ce23c096886 Author: Olivier Certner AuthorDate: 2026-10-06 09:36:09 +0000 Commit: Olivier Certner CommitDate: 2026-10-09 07:44:10 +0000 systm.h: Remove unused It only contains sched_pin_lite() and sched_unpin_lite(), which have been unused in-tree for the past 8 years, and were only briefly used between 6573d7580b85 ("epoch(9): allow preemptible epochs to compose") and a760c50c9ea7 ("With epoch not inlined, there is no point in using _lite KPI. (...)"). Additionally, these functions are redundant with the existing sched_pin() and sched_unpin() in , which are already themselves inline functions. The only difference is that the sched_*_lite() ones do not require the full definition of 'struct thread', which may have been useful to circumvent namespace pollution. That problem, if it materializes again, could be quickly circumvented without this trickery by the use of non-inline functions, or using inline functions referencing a variable filled at kernel startup with the desired offset. The trickery of using offsets computed at compile-time appears necessary only in the case of extremely performance sensitive functions. Cleaning up namespace pollution should stay the preferred way forward whenever possible. Reviewed by: glebius, imp MFC after: 3 days Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D60404 --- sys/sys/kpilite.h | 52 ---------------------------------------------------- sys/sys/systm.h | 2 +- 2 files changed, 1 insertion(+), 53 deletions(-) diff --git a/sys/sys/kpilite.h b/sys/sys/kpilite.h deleted file mode 100644 index b48b062bd7ea..000000000000 --- a/sys/sys/kpilite.h +++ /dev/null @@ -1,52 +0,0 @@ -/*- - * SPDX-License-Identifier: BSD-2-Clause - * - * Copyright (c) 2018, Matthew Macy - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions - * are met: - * 1. Redistributions of source code must retain the above copyright - * notice, this list of conditions and the following disclaimer. - * 2. Redistributions in binary form must reproduce the above copyright - * notice, this list of conditions and the following disclaimer in the - * documentation and/or other materials provided with the distribution. - * - * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND - * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE - * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE - * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE - * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL - * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS - * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) - * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT - * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY - * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF - * SUCH DAMAGE. - */ - -#ifndef _SYS_KPILITE_H_ -#define _SYS_KPILITE_H_ -#if !defined(GENOFFSET) && (!defined(KLD_MODULE) || defined(KLD_TIED)) && defined(_KERNEL) -#include "offset.inc" - -static __inline void -sched_pin_lite(struct thread_lite *td) -{ - - KASSERT((struct thread *)td == curthread, ("sched_pin called on non curthread")); - td->td_pinned++; - atomic_interrupt_fence(); -} - -static __inline void -sched_unpin_lite(struct thread_lite *td) -{ - - KASSERT((struct thread *)td == curthread, ("sched_unpin called on non curthread")); - KASSERT(td->td_pinned > 0, ("sched_unpin called on non pinned thread")); - atomic_interrupt_fence(); - td->td_pinned--; -} -#endif -#endif diff --git a/sys/sys/systm.h b/sys/sys/systm.h index 02a075dcd5ed..ccc542bed309 100644 --- a/sys/sys/systm.h +++ b/sys/sys/systm.h @@ -97,7 +97,6 @@ struct ucred; #ifdef _KERNEL #include /* MAXCPU */ #include /* curthread */ -#include #include extern bool scheduler_stopped; @@ -177,6 +176,7 @@ int linux_alloc_current_noop(struct thread *, int); #define critical_enter() critical_enter_KBI() #define critical_exit() critical_exit_KBI() #else +#include "offset.inc" static __inline void critical_enter(void) {