From nobody Thu Oct 08 14:58:02 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j0tQg1dvFz6vlv1 for ; Thu, 08 Oct 2026 14:58:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4j0tQf6N15z4jMC for ; Thu, 08 Oct 2026 14:58:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791471482; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ar+w64P8iBUo1bkbHenpGy4uymkCle620C9ZKiGaF50=; b=lJAWJIe4pztFM0BeZ6OIGOLnmQLHnHOLaoDZTsXgobOWKSDyZqXsA9usau8DUIHEZjIkf+ z6ZAtoQVIdCm5kPs2GyM8FcYjPJwAja08K5D/KQRZVLGtjm7cJAgHkMcMILdsediFCEBEQ +9N496QyfSV3iR+aGazS1iSDgVgRt0aMr1Bk5LHsyOoVNSRxTUNQRpihhpXzMwdVpvAd9h +uMQk7APm8tcktZlo5P2cq//lKC09gIYT9dJPtw9faliUc7MNrbiw9D8OiY6CTIRh1gaa2 ThagyYAtZUx0cZ2rQq1lykbSzZHZCYP03pvBcAidlZ76oTMYDzdjk8QawWZEPA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1791471482; b=dQL+eL2Du+YbOrjMrrKZ4GDNcVWgCRwja+daw3dqctHFIMz1ykmUSiwfjH/mbJwGcAttOm TUv9RQEyjW9NfRGolYe1hL5MohTSXp/q5J7NQunNj5zfcaIp/WFOySEDEfCJQUElepSvgj 3v7iw20vW9bJk54xwjObvNRg+pyQ2f2Rr71GtFhhSivZcOM2T7klESaEbVJLUOPlv7Kacd xF6zDsaUBPoZx9tb2O1PidhPvHReMGHrFQziWiVKS8r/IHGlw76ikBTs4HPVZ3ZH4QJFsO Dw2ZYh5k5yR/rvcIszCyzEVTiQQgXH2uf+Zz8urAe3RxoyA6kDbQPa9UJAuebA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791471482; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ar+w64P8iBUo1bkbHenpGy4uymkCle620C9ZKiGaF50=; b=rnrytGjlLJtUbvfG/5O70MJeXOPIaJuj/ct3k3N6TjhzXIfzDd9Dl0Mw1wKkfbXoJlrWO5 EQqsAd6GnBEXrR5YX9AmeF8HtW7mX1Y4hUeIBoM39wpgiq5wxHTiUVhjpHvNf7t0ta2VNY 3rEah7wYrcjsqs+O04gYlMMomP1mbeCmRyQi0GI1ZowFuUZ7GbKS8YE1Va/veluziY/aiD 2AG0WlmmKI+rNGpTe7wBkL3Z/x8ZwncXkjARdvEbxSdheKs9LTnlAs4Tg6PtucsgSRCpJF oJgY7mpZrVp9b9wEKdfQ81k2H0Ye4tki/EAtsr/96BmfP1UON75QOSMCCTyGWw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4j0tQf4tTLzl09 for ; Thu, 08 Oct 2026 14:58:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3660e by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 08 Oct 2026 14:58:02 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Osvaldo Janeri Filho From: Mitchell Horne Subject: git: 911fcebfc7f1 - main - hwpmc: return errors from PMC_OP_PMCGETMSR List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mhorne X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 911fcebfc7f1e5a5dd184137c0b9d62b4b066f17 Auto-Submitted: auto-generated Date: Thu, 08 Oct 2026 14:58:02 +0000 Message-Id: <6ac7af7a.3660e.1d35aa@gitrepo.freebsd.org> The branch main has been updated by mhorne: URL: https://cgit.FreeBSD.org/src/commit/?id=911fcebfc7f1e5a5dd184137c0b9d62b4b066f17 commit 911fcebfc7f1e5a5dd184137c0b9d62b4b066f17 Author: Osvaldo Janeri Filho AuthorDate: 2026-10-08 09:44:00 +0000 Commit: Mitchell Horne CommitDate: 2026-10-08 14:57:40 +0000 hwpmc: return errors from PMC_OP_PMCGETMSR pcd_get_msr() returns a positive errno, but only a negative value was treated as a failure, so errors were reported as success. Signed-off-by: Osvaldo Janeri Filho Reviewed by: mhorne MFC after: 3 days Sponsored by: AMD Pull Request: https://github.com/freebsd/freebsd-src/pull/2461 --- sys/dev/hwpmc/hwpmc_mod.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/hwpmc/hwpmc_mod.c b/sys/dev/hwpmc/hwpmc_mod.c index 7db73b5c78c9..7ffabee4004f 100644 --- a/sys/dev/hwpmc/hwpmc_mod.c +++ b/sys/dev/hwpmc/hwpmc_mod.c @@ -4465,7 +4465,7 @@ pmc_syscall_handler(struct thread *td, void *syscall_args) break; } - if ((error = (*pcd->pcd_get_msr)(adjri, &gm.pm_msr)) < 0) + if ((error = (*pcd->pcd_get_msr)(adjri, &gm.pm_msr)) != 0) break; if ((error = copyout(&gm, arg, sizeof(gm))) < 0)