From nobody Thu Oct 08 13:08:48 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j0r0c3vltz6vdXM for ; Thu, 08 Oct 2026 13:08:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4j0r0c3QWVz4Vxw for ; Thu, 08 Oct 2026 13:08:48 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791464928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ob1vQayS7pWo+rkooFGTc3tmPwY9bfufK97Ji0mtu7M=; b=jO8MiRr0qduLVoekQHG4sLaODqkyICM+bAB6Ep8Ji9xD+G40mFLqKIQMwI+f+rSWh2rvKx wZgQG2hZBcuBPDlPvpFNqsuTWwaN6tTR7Yr6foNqZ0RVjsSN3EsU0pRqrTiSgn2XQlcHTH i9MgnckNAF+6ELt/jWdeqY1hbLpTq/lfPrmPZG7OpS+rg679j4U0SX2aribYfFYvI7S9Zi D+DbygWCSmPMKdu2bdCUEkn7hruJHd0wu8FT9jsULa7PffgUPdzJC9VyMCMtPB5swg4rDM VBYjHdXqxoIMUIzADWI4lNLAiZsTJrZSMvniAeG9GqLiWPC+7X8WcG551M1iAg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1791464928; b=r38gLI7P23EswY7E7PQ7XLW6m6P6zHfmHDYaFERpo67VL2zAHPgkqJlfhXW98R1aVUsXyI av92XuTiX1VJsSzzNOdXRLc5ni6kb1hLf4HenLLHGE8xnta99K3ExZp5Tw1DUiDBUkhLy7 pQnjwgHoMAr+V7N9MEYlurU4LcESrZBHCl5YVnu3V6tTR6x+KjCKcC6DmopPpxLWuRu3q6 tpBffa2ehCOFeBVSZmPDdIr0x6ow2o6hAcZr3hgriDCPabbeQ9l/qEHykiUxSw4elc0etD tj9lQbEXcGBpX7lQ3BZulnNxtrj6PGGHmhpGg0X2wjKQ5FR/EkL/5qE1Bt3j9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791464928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ob1vQayS7pWo+rkooFGTc3tmPwY9bfufK97Ji0mtu7M=; b=Os2MyUE7VjsHeyLdWHPdnRokkYbW2gUCjXbFTMrHaO9p80qoM6mVxKySW/3tcqnSuMs1iG 6N7SMq0tvXLygu+J5R/MbdP6btwwKJ6k3Ik00hC6XBItC/Cw72qt6fQzMH02z46uGC+kny AJ0UaPqESpT1s+0lDzGPnGv7d8fsmnhcfE92oJPcDFn9rplR6e8YrP6ypqz3F6N7NKVa73 D5jMa5TbEu1OUStT5mL2Sv+8avRTYAlLESnjpgAt70bMTqyLSw3J0cpslY9A0a0O7dDtO0 O78LwaJjfI9IWUGJ+ybMIodafBJ5fzzILkzSYvrZ3iwTtbEXp3sMRh8xAgXUdg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4j0r0c2CVlzhYX for ; Thu, 08 Oct 2026 13:08:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 21933 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 08 Oct 2026 13:08:48 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Michael Tuexen Subject: git: d39b12e9030b - main - sysctl: don't loop when EAGAIN is returned List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d39b12e9030b20410cecbcbb0c22847d7f8b5471 Auto-Submitted: auto-generated Date: Thu, 08 Oct 2026 13:08:48 +0000 Message-Id: <6ac795e0.21933.35ed90c8@gitrepo.freebsd.org> The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=d39b12e9030b20410cecbcbb0c22847d7f8b5471 commit d39b12e9030b20410cecbcbb0c22847d7f8b5471 Author: Michael Tuexen AuthorDate: 2026-10-08 13:05:11 +0000 Commit: Michael Tuexen CommitDate: 2026-10-08 13:05:11 +0000 sysctl: don't loop when EAGAIN is returned When userland_sysctl() experiences EAGAIN, don't loop internally but leave retrying to the caller. Looping was a problem in case of using tcpsso(8) to switch a TCP stack where the acceptance check of the new TCP stack results in EAGAIN. Reviewed by: kib, glebius MFC after: 1 week MFC to: stable/15 Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D60444 --- sys/kern/kern_sysctl.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/sys/kern/kern_sysctl.c b/sys/kern/kern_sysctl.c index ad2d4ae22a77..8c63f8073cb4 100644 --- a/sys/kern/kern_sysctl.c +++ b/sys/kern/kern_sysctl.c @@ -2580,14 +2580,9 @@ userland_sysctl(struct thread *td, int *name, u_int namelen, void *old, } CURVNET_SET(TD_TO_VNET(td)); - for (;;) { - req.oldidx = 0; - req.newidx = 0; - error = sysctl_root(0, name, namelen, &req); - if (error != EAGAIN) - break; - kern_yield(PRI_USER); - } + req.oldidx = 0; + req.newidx = 0; + error = sysctl_root(0, name, namelen, &req); CURVNET_RESTORE();