From nobody Wed Oct 07 16:59:29 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j0K9F6fWCz6w9yM for ; Wed, 07 Oct 2026 16:59:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4j0K9F4dclz4Y83 for ; Wed, 07 Oct 2026 16:59:29 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791392369; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dTfk1keo3S3mrVlFVVPrPzm2xVJ4uvlK+lRcN44ywhw=; b=Jaa7mdsu7tnnaOSRDL1SfDALX8brmkoa0GzUSK0BtnT63oBUu+fPnqnGQeJYNFFJQuQAeC QhM7FEEqHAheOn/pESFfeLQKFSYwIffRkw+i3mtcIsih9MzDa89FatXjb7nTOTlpXlxcqH 2NQLpEIgN+vSj2MiKQawJ99ZHMCcir/xcfe1MLT4omJzdVndCFyh4GuWTsFcoYKcnCmbd2 LE8e6g0qe5hZgz/IIuHyfmcJF237QiqzXROa/I1++mNCvOXABN/iI8Jeu1v9FYQCXj+1CD g/zerSU8acMHiBGOJhpy7f/rJI9o0RAD4XomQ8f0u4poUTyILsznYjokMBXMPQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1791392369; b=G7+ZFFZm9jKga2Tswyg8XEZNaARYDPPOj5m9/FCc32krPka+atu/BKaXGQQ4koMwyHfG7R grulelJGvN6CfgUKjP1lcGSvehNQaCN8g+Dg2E88sJfxC3o5bpCfRJKePnqWW8Yn4+v7oI dTZUxGclKIWEO34VWrTk/31ggdEGN+oPppnG/PIICGwNrFJlM/Vfxuxmlc4wprtw00/9EG eHekMqAHq747SXik5Z2J5CLzHhZlE9hb8T46UGgmgCdcG0YrVkLxlzyRTth4jdhPjtHnB8 o8O8OH4N/UwFps8YKEl1/iHQtqzB2Q+nngiNV6CiZZGmMbux54ZHniklqxE3ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791392369; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dTfk1keo3S3mrVlFVVPrPzm2xVJ4uvlK+lRcN44ywhw=; b=WUWGuK8Pt7BzpSZpgughdR0oQl78/DFEWr24VbTz04qVh5TcrnLQW8Z/X5H5uB0QWCqY3x /kWr2gOAnF2XBdkDR/h2AZbsVYerFTTekEWBy9FpGGUvL+fCkD1KbrGE36psJQeBqM6tpT PLC87oto/JRsPvw4mOdBr9HNM2iC0XIThsplfblkiegIfzLv/pdqgjd5TeKAd10uaHVn0I x+iGEfgbsmq/jjAThwz6xy+o/fPLCyXeW5TTP40A2IZD05LMImaT1Fx4Z1u/HGw5Kpdeza MPa69VlKL29vQlHI2RxzrV3zEQeVeYehKuwI0FwTHCeixBE2wcXxwU8eTDddAw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4j0K9F38nwz11vv for ; Wed, 07 Oct 2026 16:59:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 36637 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 07 Oct 2026 16:59:29 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: ShengYi Hung Subject: git: 1d21e67e720a - main - libthr: Do not rely on UB in counter List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: aokblast X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 1d21e67e720a08992e81d626cff9d76524a81f22 Auto-Submitted: auto-generated Date: Wed, 07 Oct 2026 16:59:29 +0000 Message-Id: <6ac67a71.36637.7462135a@gitrepo.freebsd.org> The branch main has been updated by aokblast: URL: https://cgit.FreeBSD.org/src/commit/?id=1d21e67e720a08992e81d626cff9d76524a81f22 commit 1d21e67e720a08992e81d626cff9d76524a81f22 Author: ShengYi Hung AuthorDate: 2026-10-07 01:41:55 +0000 Commit: ShengYi Hung CommitDate: 2026-10-07 16:59:10 +0000 libthr: Do not rely on UB in counter counter + 1 > 0 is a undefined behavior and nobody guarantee that it will be honestly perform by the compiler that counter + 1 will always be INT_MIN. We switch to INT_MAX check instead to provide a deterministic result. Reviewed by: kib MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D60426 --- lib/libthr/thread/thr_mutex.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/libthr/thread/thr_mutex.c b/lib/libthr/thread/thr_mutex.c index 82da8ab1ccba..1787db825bf3 100644 --- a/lib/libthr/thread/thr_mutex.c +++ b/lib/libthr/thread/thr_mutex.c @@ -865,7 +865,7 @@ mutex_self_trylock(struct pthread_mutex *m) case PTHREAD_MUTEX_RECURSIVE: /* Increment the lock count: */ - if (m->m_count + 1 > 0) { + if (m->m_count < INT_MAX) { m->m_count++; ret = 0; } else @@ -934,7 +934,7 @@ mutex_self_lock(struct pthread_mutex *m, const struct timespec *abstime) case PTHREAD_MUTEX_RECURSIVE: /* Increment the lock count: */ - if (m->m_count + 1 > 0) { + if (m->m_count < INT_MAX) { m->m_count++; ret = 0; } else