Re: git: df6131e2b74d - main - Remove CDDL and ctfconvert tests when their controlling knobs are disabled
Date: Wed, 07 Oct 2026 14:17:21 UTC
> On Oct 7, 2026, at 5:06 AM, Dag-Erling Smørgrav <des@FreeBSD.org> wrote: > > Dag-Erling Smørgrav <des@FreeBSD.org <mailto:des@FreeBSD.org>> writes: >> Enji Cooper <ngie@FreeBSD.org> writes: >>> commit df6131e2b74d9f334c16387e9a46cafd6e27eb78 >>> Author: Enji Cooper <ngie@FreeBSD.org> >>> AuthorDate: 2026-09-22 02:46:52 +0000 >>> Commit: Enji Cooper <ngie@FreeBSD.org> >>> CommitDate: 2026-09-22 02:53:03 +0000 >>> >>> Remove CDDL and ctfconvert tests when their controlling knobs are disabled >>> >>> In the event someone specified MK_CDDL == no prior to this change, all >>> tests under `/usr/tests/cddl` would stick around after the change, >>> resulting in errors. Similarly, MK_DTRACE == no removed ctfconvert, >>> which the ctfconvert tests relied on (but remained around after the knob >>> was disabled). >> >> The sum total of my build configuration is >> >> WITH_DEBUG_FILES ?= yes >> WITHOUT_PROFILE ?= yes >> >> After buildworld + installworld, check-old wants to delete the CDDL >> tests. If I run delete-old, then installworld again, they are >> recreated. > > Ping Could please run `make showconfig` from the top-level directory and attach the output in a reply? Thanks! -Enji