From nobody Wed Oct 07 03:51:27 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hzzhF6lJZz6svxW for ; Wed, 07 Oct 2026 03:51:41 +0000 (UTC) (envelope-from sobomax@sippysoft.com) Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hzzhF1Zdzz4kmn for ; Wed, 07 Oct 2026 03:51:41 +0000 (UTC) (envelope-from sobomax@sippysoft.com) Authentication-Results: mx1.freebsd.org; dkim=none; arc=pass ("google.com:s=arc-20260327:i=1"); spf=pass (mx1.freebsd.org: domain of sobomax@sippysoft.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=sobomax@sippysoft.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none) Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-381b831d535so3530360a91.0 for ; Tue, 06 Oct 2026 20:51:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1791345100; cv=none; d=google.com; s=arc-20260327; b=WXSYiWQ18WyRl/XAUpQ0yTjBSwzKhXA9FV2h/Dbp7d3Wr+0BuVLkAveo3Z5lYCfdcn yLWLD77PFt3EQATOBNUULP64WA+1ibJ2pCZgblYmcyO2Swo8dAJMmZTZjrAYQlvz6+3v +G7/v56CYxurgb8RnSfvJyIuLe4HsorBX7A+gghAm3lUoiwdegmle2vdChW6aX3L72bX 5xrpQ7oC+6/J4OyWHanHfQR5NP1nFIcIUr3auAazUpCkkcfqTiLlnb858yNXG/maNWoA DZ0fx0yMkgTvBDl2o8YynuScpSP3+EKDD0bK2RnoSoXs9x8FXgKCq7aNHiJkz5n9RogZ MJPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version; bh=XGC8IzSHsoUfN4rL4lKDuvnYFM4fhlvmydtIamM4Ia0=; fh=/lETsaKgmpHO6av78cmohifquJ7P6wU6mxpucMNa560=; b=W8/faImPFCH5mQJ4a/nExYUtYozG8u7Oh1L4hmL66ndvd12scrSjVM/fAvHDbim8Dw 4MeM9UClreYcFX4V3PZRuKqBR/F5PAMYS7cgdNoomZQXVfG20CCHQJi6ZYx2NOtqLSuS 9rX297R5rsVi/00c2clYx/mnUrHiJxwBqOdDaCIVadKIwPuFDH9M4ADfXWUBFCcSEMel wQtuFkD+h6hXklf2qmfnJwDwaNKy82HY50o7z7Tc379qz/Z6eUamLfcVG56iSG4yVl9w YeLVeSlX7Thj9GBqPeeukP5lgcxj+/stejpOF/3sjZIvb+0jGPSFyE1fxOm0D7cv9q3L Lt0w==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791345100; x=1791949900; h=content-type:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=XGC8IzSHsoUfN4rL4lKDuvnYFM4fhlvmydtIamM4Ia0=; b=rNKVEwv4acJxcoRYoKPytt182tI81WfnBTw6FUtIQAz6T5uPfXHUwQ5/MwJhTCBicP YJ9l72XJLHFmxCg0FKZ6YhdhV+WFwDi2XCIdfg7Fsu5iylh7oowi6Tao9TH/bgBTI3Kp ubPHDq5q/q+axv15v3Owi655IxgUT7m1capg3c5vvcxg0Q+Pvd2x6l7NL9E3/MOPaeYm tBjjTEaKIsnb7N46wgiIbqsmRqvJw3Xwli1ew3X4X4mlQ0LULyyQnsSKJX1dJx6rn9P7 keGIr0+7isivwe7F+omRf0dfHJag57uAZ8WOzg2vLhoFkSMl8/J9raQVvYRG3LxlylHj 0tZQ== X-Forwarded-Encrypted: i=1; AKwUvBy2rBTHGOtX0a9oYWEGp5fJZ3bzCBuMuJmBpdx52d0LBj+OKheJKoUlO17sdZPwIOmhvWS5HZe0asnfBIY5qDFKW2/dFg==@freebsd.org X-Gm-Message-State: AFq9FYKI0kPz30bG/zw6jJQSaOii/KM6LCUZgFGvcSGMOu7/kW+JqGop xl+AqdCuL1nkyW9HG8oUDVc7BNqQ8eNPSdyPDWV8VDY1s2knklaVzuWrR1K6QQhxaZN0A/FFc9/ jE+OJt07MllHRQcZVeiGW8ANswXaNobGDJWDZwEjKZw== X-Gm-Gg: AYBFou1yvU2j9+Tw0YzlGVAk7QaGHNo2Kr1C/dWjhQyMOUDNgiRF6IKwbmmcHud9LQm oNMrRptA8mKdIqiVhTyDqVrK7uTnlpBYMtmGSDt//9nh0RJ4+zAw85ho144I+G8DAtDSb2DP6/w 8apmaIMG4N8AV7A8fDDS/vwYlJzGD6rjkx1yXHb8NkYNU3OhEuCW4IW+0WdIAt/OkEnjfqtVrNE 5HpTv+oCJ8QFaOtK37AvjP3oen83o8g4DFYQIAOv6Xu+r2mUcsuTdV+z0bA+Uyed4uYVU3ws0Y+ TS5RBfODLPaZtzq+wx81i6vyuvV95kaZt9PNvwDjCF9UeiW5lYlE/w== X-Received: by 2002:a17:90b:1344:b0:3a8:7bbc:3f3e with SMTP id 98e67ed59e1d1-3a8a1b0071cmr977730a91.41.1791345099732; Tue, 06 Oct 2026 20:51:39 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 References: <6abecfdf.3a8dc.610fc5a7@gitrepo.freebsd.org> <86jynwnvls.fsf@ltc.des.dev> <86cxtmojly.fsf@ltc.des.dev> In-Reply-To: <86cxtmojly.fsf@ltc.des.dev> From: Maxim Sobolev Date: Tue, 6 Oct 2026 20:51:27 -0700 X-Gm-Features: AclHuK-Jb3Z82y6EomBD5vwHeV9n_cs73DOPyvycHMORv0R9aVdTUOv8LQPfH3I Message-ID: Subject: Re: git: 43b0384bc7e8 - main - mountpoint(1): new utility, implemented as a stat(1) hardlink To: =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= Cc: src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000570d10065d380890" X-Spamd-Bar: - X-Spamd-Result: default: False [-1.00 / 15.00]; ARC_ALLOW(-1.00)[google.com:s=arc-20260327:i=1]; FORGED_SENDER(0.30)[sobomax@freebsd.org,sobomax@sippysoft.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; RWL_MAILSPIKE_GOOD(-0.10)[209.85.216.47:from]; MIME_TRACE(0.00)[0:+,1:+,2:~]; TO_DN_SOME(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; RCVD_COUNT_ONE(0.00)[1]; FREEFALL_USER(0.00)[sobomax]; RCVD_IN_DNSWL_NONE(0.00)[209.85.216.47:from]; R_DKIM_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[sobomax@freebsd.org,sobomax@sippysoft.com]; FROM_HAS_DN(0.00)[]; MISSING_XM_UA(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; RCPT_COUNT_THREE(0.00)[4] X-Rspamd-Queue-Id: 4hzzhF1Zdzz4kmn --000000000000570d10065d380890 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable This has been suggested by reviewer @kib citing similarity to readlink. Original implementation was a standalone. I frankly don't care one way or the other, but arguably you could have raised this earlier while it's still at review stage. If that's important to you I suggest you do the conversion now. -Max On Tue, Oct 6, 2026, 9:54=E2=80=AFa.m. Dag-Erling Sm=C3=B8rgrav wrote: > Dag-Erling Sm=C3=B8rgrav writes: > > Maxim Sobolev writes: > > > mountpoint(1): new utility, implemented as a stat(1) hardlink > > Why was this implemented as a stat(1) hardlink? There is aboslutely no > > common code between the two. > > I'm serious, Maxim. Implementing mountpoint(1) as an alternate move of > stat(1) adds more complexity than it saves. Please revert and re-commit > as an independent binary. > > DES > -- > Dag-Erling Sm=C3=B8rgrav - des@FreeBSD.org > > --000000000000570d10065d380890 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
This has been suggested by reviewer @kib citing simi= larity to readlink. Original implementation was a standalone. I frankly don= 't care one way or=C2=A0the other, but arguably you could have raised t= his earlier while it's still at review stage. If that's important t= o you I suggest you do the conversion now.

-Max

On Tue, Oct 6, 2026, 9:5= 4=E2=80=AFa.m. Dag-Erling Sm=C3=B8rgrav <des@freebsd.org> wrote:
= Dag-Erling Sm=C3=B8rgrav <des@FreeBSD.org> writes:
> Maxim Sobolev <sobomax@FreeBSD.org> writes:
> >=C2=A0 =C2=A0 =C2=A0mountpoint(1): new utility, implemented as a s= tat(1) hardlink
> Why was this implemented as a stat(1) hardlink?=C2=A0 There is aboslut= ely no
> common code between the two.

I'm serious, Maxim.=C2=A0 Implementing mountpoint(1) as an alternate mo= ve of
stat(1) adds more complexity than it saves.=C2=A0 Please revert and re-comm= it
as an independent binary.

DES
--
Dag-Erling Sm=C3=B8rgrav - des@FreeBSD.org

--000000000000570d10065d380890--