From nobody Tue Oct 06 00:47:47 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hzHfW4KbXz6vhNb for ; Tue, 06 Oct 2026 00:47:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hzHfW3nhQz4LwW for ; Tue, 06 Oct 2026 00:47:47 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791247667; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Q1w+YJ7M5Ocnp1RlVxehYSA13fvLI8a0T7z2saPB1P4=; b=YMWHpbEG4+sDBTPryqIiedOraTQnGn3PQWlqTlSllMoev/x3nLc0CfBz74bDMXQMQLylLk i71S7I5nmqmvY7U1jYbzikRFCwEnSVnaXqaCNX9DD/+FPlHwh3qI0Z/ZklIk1VZngkYlLa SEn2h4Mc8Mhc2XBtCWxbH/T+1gpTQsBX7mtmzH51edz447zmrl6Yt1VvrGtn0vddvoYBEt HnkSZQDYkrAlj+X+PRQoFLSmHsPLkST7/MavBgYC/FRkP5jD/QARJyVfDRGEV99Ta33jqz vDj98jCQCPcviTGGGSurEWvQlOYntFP7pzE1kcsb+pk55QTn6v9sLF21CpqqZQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1791247667; b=qIvPAON4wcTjsKGHmmveT19j95W1F0p7Mm9kgEWVL/iHukjy74sFDA6rmLPkd/UvkEmFIB jphyjrpOktGIp4X2muxqqQjv+3l0oR2EC9NHmn+bIedBqwE2fX1ZsrFuml2vPJn7SIPQdE 9NTFkl+DlKm8RQxCayn9cHj8GPL/hvIo3hkYircmQZg2qnyGvFMUot0iRoH1MRzj5NMZvU 1sNUbeUt4mmVsE25CMlyPavk8ypILlGN4nx8wpysFrOw/2t+DkGT/VzgEa0EvYQNzoWMgY KXPBu8aJ/xX2S5qAEauQMx9P0o8td4r83yqYXeij3HmjsLeBvKoXTQCH9SeEYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791247667; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Q1w+YJ7M5Ocnp1RlVxehYSA13fvLI8a0T7z2saPB1P4=; b=HZrDjPHIyPpeAKvZLHtAY/ytReWGszdcH/5N8HWFIzXsT/gBWmDfJhZ/8dmN49Ca6L+Apw 7UZ2xwixy5jpruIVFXmxd2Xe3JnyFJa8jPpQvcpdmWQ48EUK2B9PxWFJX8I0wKAxIMWUal AeF3DZXNZ+EU3j9zpEGL5IjU2GWwaSMAISh39/xu5PmX8yROy9z4WUf0l/pXqFqnkxoSOo ghFQcMoEeUoODnpW5i1Vlim76wBbxz1b+eqagr+aYm1QthwZzqsaMSGFElRgtbfPzudCYp QWdK9uYbSa5hyPhT+gG3zkrvgs7TNub3xpPqABA9Ur1irmsK3tW3qDVZQCsuIA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hzHfW2ZXPzksJ for ; Tue, 06 Oct 2026 00:47:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3aecb by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 06 Oct 2026 00:47:47 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 1e595e959f66 - main - devfs_open: do not access dsw after dev_relthread() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 1e595e959f66e11d0490e90270b9fb701cbc6739 Auto-Submitted: auto-generated Date: Tue, 06 Oct 2026 00:47:47 +0000 Message-Id: <6ac44533.3aecb.832df6b@gitrepo.freebsd.org> The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=1e595e959f66e11d0490e90270b9fb701cbc6739 commit 1e595e959f66e11d0490e90270b9fb701cbc6739 Author: Konstantin Belousov AuthorDate: 2026-10-05 23:35:32 +0000 Commit: Konstantin Belousov CommitDate: 2026-10-06 00:30:49 +0000 devfs_open: do not access dsw after dev_relthread() Noted and reviewed by: markj Fixes: 850d4562928e ("cdevsw: add D_NONPASSABLE flag") Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D60393 --- sys/fs/devfs/devfs_vnops.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sys/fs/devfs/devfs_vnops.c b/sys/fs/devfs/devfs_vnops.c index cd6cd1959d6b..53fb08c6931b 100644 --- a/sys/fs/devfs/devfs_vnops.c +++ b/sys/fs/devfs/devfs_vnops.c @@ -1288,6 +1288,7 @@ devfs_open(struct vop_open_args *ap) int error, ref, vlocked; struct cdevsw *dsw; struct file *fpop; + bool passable; if (vp->v_type == VBLK) return (ENXIO); @@ -1306,6 +1307,7 @@ devfs_open(struct vop_open_args *ap) dev_relthread(dev, ref); return (ENXIO); } + passable = (dsw->d_flags & D_NONPASSABLE) == 0; if (vp->v_type == VCHR) devfs_usecount_add(vp); @@ -1347,8 +1349,7 @@ devfs_open(struct vop_open_args *ap) #endif if (fp->f_ops == &badfileops) { finit(fp, fp->f_flag, DTYPE_VNODE, dev, - (dsw->d_flags & D_NONPASSABLE) == 0 ? &devfs_ops_f : - &devfs_ops_nonpassable_f); + passable ? &devfs_ops_f : &devfs_ops_nonpassable_f); } return (error); }