From nobody Fri Oct 02 20:43:14 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hxLMl1qr8z6tXwR for ; Fri, 02 Oct 2026 20:43:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hxLMl0TCgz4cCJ for ; Fri, 02 Oct 2026 20:43:15 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790973795; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/kSNxjZwbUgsJOIi5EfVqYxOWlxE2byJTOGZToxdVTQ=; b=dKaDRvsdY8oyJ9seaPmY30KNNynkMCj9RpxFkoIzG0pwCE1XEDoLzD/vjg174QwD8LljIO OyCOC+8HcVGs2seVsXt9RzCVH5UiQtYI+wZ/VSTCpLDCgzm8iYyDqOPakE5Dn9XnVCuHIf KllsgVwU/DS/M0h19A96c03hpPsV+zpvx+ZgGQogNn2VGiBnKqUHkEhCY2W5lOnqFXuMTL 3yq/xsY5uFQR/P5AOsX0AhwkjKBCpgxkJA4451O+x2RnXKvheV9kxBc+x3W4D7RDfvlh81 DNaNEHwrKadnYoqRQrw/8kmebod/j9j0Pt1xmbpvMRHSbZk9IrvkP488SKl3tg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790973795; b=XQKy3h6HHk1zQ9G3hJaIWqXNS4AEWBGte0HeACGlHH4Mrk7uKO7g93RYdGcmpIdzJty7Ba qIvyVMSxpot/TWe13gHSh5rYhgrcdM5R7o8wB83lg3HZFw4njlAtc/ENLy2NmvzTDoF+xk g9pwJR33yDTOLjc+CFaqzXHog1T3WwzFny9CX45N02yNfYn2pRdtjtcFPNxMdG7zTlS60Q 0FNpasO4lKmBnbf7GNkQBs8tJS6fhzb5MSZmSBlE6LX0qro3fC1PieCghwihxD+CM0u1L1 SVgCNyl6TNjZ5MFNIUUYr2P9j8R0+b0pY+uuc+CU8XnXzkkqHDBYFYmHpoBz9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790973795; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/kSNxjZwbUgsJOIi5EfVqYxOWlxE2byJTOGZToxdVTQ=; b=VFUyLjA/Ia0i/jSKHn+PazeYImLswPcB3TCtjytJZiEXWWWTcdWW2zYmNfByy/2m0fxyxS DEVtGYwQUdC6zIHvZkrKNCWCDRcJS3ACpqSaWXK0r95/LgE+Hy/eH/kQFVfdvh09ZSz5Ic 2eXm7py6lOx/Upn/OcbkLjk+0hHevWnk5NW9KpXBYi5W3DFFFquEv5TyUElZVoxekQ95YO wBl+cUcc1M8Oq4ohe6C0bKExGUzqkp18+OZUrQSMIP+gpvtFYR62SqIk3KE/BcZQgyQ+2j R8kL0uqEsVL4cCRMH1LC8KinGIn1EKC6V6rO8LqK3w+VahbtX0yUduKv3DhUyw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hxLMk6MJpzbNc for ; Fri, 02 Oct 2026 20:43:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 38d38 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 02 Oct 2026 20:43:14 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Enji Cooper Subject: git: 9d5a33d9c294 - main - [tests] lib/libc/gen:assert_test: undefine `NDEBUG` List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ngie X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 9d5a33d9c294b01cead6ff65b0773b5b5ab85ccd Auto-Submitted: auto-generated Date: Fri, 02 Oct 2026 20:43:14 +0000 Message-Id: <6ac01762.38d38.335153e@gitrepo.freebsd.org> The branch main has been updated by ngie: URL: https://cgit.FreeBSD.org/src/commit/?id=9d5a33d9c294b01cead6ff65b0773b5b5ab85ccd commit 9d5a33d9c294b01cead6ff65b0773b5b5ab85ccd Author: Enji Cooper AuthorDate: 2026-10-02 19:27:51 +0000 Commit: Enji Cooper CommitDate: 2026-10-02 20:42:53 +0000 [tests] lib/libc/gen:assert_test: undefine `NDEBUG` In the event `NDEBUG` was defined, `assert` would become a no-op, breaking some of the expectations in `assert_test` around `assert(..)` failing generating a coredump. This is a better approach than the previous one committed in 6f3445006a as it continues to test the `assert(..)` function instead of just skipping it if `NDEBUG` was defined. Suggested by: kevans MFC after: 4 days MFC with: 6f3445006a Fixes: 6f3445006a Differential Revision: https://reviews.freebsd.org/D60253 --- contrib/netbsd-tests/lib/libc/gen/t_assert.c | 26 ++++++-------------------- 1 file changed, 6 insertions(+), 20 deletions(-) diff --git a/contrib/netbsd-tests/lib/libc/gen/t_assert.c b/contrib/netbsd-tests/lib/libc/gen/t_assert.c index b4023223b446..cec98c3beed0 100644 --- a/contrib/netbsd-tests/lib/libc/gen/t_assert.c +++ b/contrib/netbsd-tests/lib/libc/gen/t_assert.c @@ -28,6 +28,12 @@ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE * POSSIBILITY OF SUCH DAMAGE. */ + +#if defined(__FreeBSD__) +/* TODO: upstream this. */ +#undef NDEBUG +#endif + #include __RCSID("$NetBSD: t_assert.c,v 1.3 2017/01/10 15:17:57 christos Exp $"); @@ -43,18 +49,6 @@ __RCSID("$NetBSD: t_assert.c,v 1.3 2017/01/10 15:17:57 christos Exp $"); #include #include -#ifdef __FreeBSD__ -/* TODO: upstream this. */ -static void -skip_if_ndebug_set(void) -{ - -#ifdef NDEBUG - atf_tc_skip("Testcase requires code to be compiled without -DNDEBUG."); -#endif -} -#endif - static void disable_corefile(void) { @@ -86,10 +80,6 @@ ATF_TC_BODY(assert_false, tc) pid_t pid; int sta; -#ifdef __FreeBSD__ - skip_if_ndebug_set(); -#endif - pid = fork(); ATF_REQUIRE(pid >= 0); @@ -128,10 +118,6 @@ ATF_TC_BODY(assert_true, tc) pid_t pid; int sta; -#ifdef __FreeBSD__ - skip_if_ndebug_set(); -#endif - pid = fork(); ATF_REQUIRE(pid >= 0);