From nobody Fri Oct 02 19:34:07 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hxJrP1dLHz6vvyj for ; Fri, 02 Oct 2026 19:34:29 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pz2-x29.google.com (mail-pz2-x29.google.com [IPv6:2607:f8b0:4864:3b::29]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hxJrL5vJ3z4LMm for ; Fri, 02 Oct 2026 19:34:26 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20251104 header.b=V6COk1wb; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:3b::29 as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pz2-x29.google.com with SMTP id d2e1a72fcca58-88732460a36so2202983b3a.2 for ; Fri, 02 Oct 2026 12:34:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790969660; x=1791574460; darn=freebsd.org; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:content-type:from:to:cc:subject:date:message-id :reply-to:content-type; bh=VdbXaj7wYGc0PkXS9Vv9snqHqvPNgNeKQr9xvSxL3R8=; b=V6COk1wb2/uXCWCAWDyBA6lHf5+HZAKY8faRurCqfOHWaZ3dJAjXK6UDvF1GRhcSgS AHrY7VV6OLFDaUet0hQPraNaiqgZWVbw6uiIohSLWlqinl/kb9dwN/pJ73POopJBFfqZ DsNFcXlw8dCCIlh1WrvdR6hesNpOwinLYFmNEpE3DyGe85WARnu2eG/vdqkkjzqxnmlP rXw5BPVqkkHeT7zM4FCZDEX9fi7XMmQX8TPEbo8B5RRTR8bkMPUE5XrpH5nwVuGdUtvK f08lPg8fK6UvwHPgO33SqX+3XMLtLXSO/lA+jrqcnGn8NUNwNxmYCd5gcEutOHQHPauw dAvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790969660; x=1791574460; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:content-type:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=VdbXaj7wYGc0PkXS9Vv9snqHqvPNgNeKQr9xvSxL3R8=; b=lhRf6MzmMNMWu0JPT79yX/KpewDE6hG3m2vq0UbFO6uI16YZO4i3MriNAHB+9jK8bz 3EKfGn35uOHOUAxrNyUqBF0FjvieW4fofXvYdlvsWdMfYdFLjTe/wAGA5wzECiGjWe8n RCiQMk8aQUp80/gkcJjZZny9ry6gGNG1utARfoF9bXwfAoAshMgPSmZs1Jc5Rl52Qyg2 Etdxnpm6+XPnWoI1ARHhEnSCinvkPiapK+vAlbJOZaT5YBDdZIGuGaOytdA4vVgHP15x +gh30eioHUkNkJxrKSFbnb0vu4MI0hjizWPfX5swLcNlf0zDooTYWz8y3/z4pOl+SAEX MPdw== X-Forwarded-Encrypted: i=1; AKwUvBx3Wx4wnaxNrDooxXq9PD3deq7KwMOlZFk9oP5wfDWzAXLtxGyzQbBn6kqFykizXPfbB+DlPPNu0e23jZ8Rzi54m+YN7Q==@freebsd.org X-Gm-Message-State: AFuF++mRusrTSZE6lFh6sjusEYxWmgn787yIkVGhJ1TS3vQtEf1ZLE9l qtRKh9wSHs93pMtkMlT262wIWVWO8dFBEdTUkef/M/nHeAta7vVPZac4 X-Gm-Gg: AYBFou0PE/UZhzQFvgJ1Zp9MsCnPxWjMVrDQMMZmQ5Z2CiU96jbaR+Ov0FYUFekSVs6 NvYEi/5KZMdN5U7/hlD+kFjWkWZBrzwL6CzNWoCftKAlweNmcgIMdvfTeoDw6DDeUKKBm08orSh EWtk9mPIs+AO4QQyZhNGfI5e7l7DUoS2SAruhqGS30Vh92HurBnDiOCiwXxGmGloQi6grhR2eXB wjR0Ozg0Za4nQMOUR0jStgRRi1vkg4JbxIHKWlyenRMg4U34V9POKvxIpfjDRSbHFw+3kijMWbH LfUAua2WT4v/+1ViP+S7kBvNqTORcIoVxUIFFoUpTlwf04dIVXlR6T9Wj8PwS6GSp2/B8rg0SFY /mQ2o7hPbEJbnHzqSiEJ+DFC5iJ3HZBdCmDXYtxIA9xdwVjwoUfWxKWkeOraVrKFhaz24uaARs7 kDKsMhHqwyfdK++V7I3HVI9cmV5/lDKIlBEvlv83/nC7h4DR2yxRuAcDRRrdvHYtBdEOF8RdBfI nwaym5scbonsyS4RchXAw== X-Received: by 2002:a05:6a00:1bc7:b0:87c:d00a:f351 with SMTP id d2e1a72fcca58-88af86615d8mr2961157b3a.47.1790969660266; Fri, 02 Oct 2026 12:34:20 -0700 (PDT) Received: from smtpclient.apple ([187.15.153.172]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-88b0cd67b89sm1298116b3a.50.2026.10.02.12.34.18 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 02 Oct 2026 12:34:19 -0700 (PDT) Content-Type: multipart/signed; boundary="Apple-Mail=_47411303-6D07-4355-A91B-05597F78F9C8"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.700.51.1.3\)) Subject: Re: git: 6f3445006aa0 - main - [tests] lib/libc/gen:assert_test: skip tests when NDEBUG set From: "Enji Cooper (yaneurabeya)" In-Reply-To: <14fffc5e-7cb1-42b0-80fb-ac94a516f540@FreeBSD.org> Date: Fri, 2 Oct 2026 12:34:07 -0700 Cc: Enji Cooper , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Message-Id: <4647E17E-BEA7-424B-830E-F3723F2BE3A8@gmail.com> References: <6ab22091.3fd77.2b258f0@gitrepo.freebsd.org> <14fffc5e-7cb1-42b0-80fb-ac94a516f540@FreeBSD.org> To: Kyle Evans X-Mailer: Apple Mail (2.3864.700.51.1.3) X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.60 / 15.00]; SIGNED_PGP(-2.00)[]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; MV_CASE(0.50)[]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4864::/56:c]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20251104]; FREEMAIL_FROM(0.00)[gmail.com]; TO_DN_EQ_ADDR_SOME(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; FROM_HAS_DN(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:3b::29:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; HAS_ATTACHMENT(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; MID_RHS_MATCH_FROM(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_FIVE(0.00)[5] X-Rspamd-Queue-Id: 4hxJrL5vJ3z4LMm --Apple-Mail=_47411303-6D07-4355-A91B-05597F78F9C8 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Oct 2, 2026, at 4:24=E2=80=AFAM, Kyle Evans = wrote: >=20 > On 9/22/26 08:14, Kyle Evans wrote: >> On 9/22/26 01:30, Enji Cooper wrote: >>> The branch main has been updated by ngie: >>>=20 >>> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D6f3445006aa05550f14af65b04276c3d= 25169941 >>>=20 >>> commit 6f3445006aa05550f14af65b04276c3d25169941 >>> Author: Enji Cooper >>> AuthorDate: 2026-09-22 06:22:57 +0000 >>> Commit: Enji Cooper >>> CommitDate: 2026-09-22 06:30:30 +0000 >>>=20 >>> [tests] lib/libc/gen:assert_test: skip tests when NDEBUG set >>> In the event that NDEBUG is specified in CFLAGS--which is most = likely >>> triggered via `MK_ASSERT_DEBUG` =3D=3D "no" -- all assert(3) = statements are >>> optimized out by design. This breaks the assert(3) tests as = they >>> specifically rely on assert(3) actually raising a `SIGABRT` = instead of >>> quietly succeeding. >>> Skip both tests if `NDEBUG` is set. There's no sense running = the >>> `assert(true)` test if the result could instead be a false = positive. >>> MFC after: 2 weeks >>> --- >>> contrib/netbsd-tests/lib/libc/gen/t_assert.c | 20 = ++++++++++++++++++++ >>> 1 file changed, 20 insertions(+) >>>=20 >> Hi, >> Why not just #undef NDEBUG right before we include ? Given = that it's a test of the feature, >> I think it makes plenty of sense to ignore the user-requested = preference for just this one scenario >> where we want to confirm that the feature isn't coincidentally = broken. >> Thanks, >> Kyle Evans >=20 > Ping? I really don't think this is the approach we should be taking = here, particularly when > the alternative is robust and easy to implement. Thanks for the poke: https://reviews.freebsd.org/D60253 ! -Enji= --Apple-Mail=_47411303-6D07-4355-A91B-05597F78F9C8 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkHfexGRJ3gYRdA2gGpE5DjPsNJgFAmrABzAACgkQGpE5DjPs NJjoAQ//ePDkmi6XTpGZ+qDYfHOLFcspj69ag3qqjOsY+my3uuVgibn1ubnccbCf 4L61+WoLHUjGQkJnQkarRR1+WOtq+sopv9TeL6Da9jN+Ok5kzvV9CEGwkNwnkm73 dijdx+oAIMS2YcunYkacDxYO9wLr8k38AM5A79Bi5MAFpI66AaIBQaBoSmERYCrj 08pc9DUhiYP+LRewqfGTKdH0oz/mcf5+uQcUl8rFQD7a4PGFHb7cfN2nVVZXOnSN AVTSlwjYDb3qxtnS2W5yivKm3V+2iNJC5VEn9mrmfDPQEHuwsTAaUVy/cWhX7AUo iOqgTeGjsmt48ELWEmpX5WOFHSy8/nNeyqbyxyOjyfrYxIYSobNN4CFOfqTF5JWx vCAUyhlhYve7b9ySHzxBsFMIbg6tEVeKSZdhTKoa6zYM5kyByc/FNqJssVSl1sQn Ih5QwnS6aX7TRMtc9mTr9F70AH34142REubAl0RearTLA2MTvhTWtIV8yeex2rfT /sKpGrUTzfQQQKmSKBXBPk6iFFjev7TFx7xVjrHoWEso49dxG1tulBBwFwOCacda ThjPdXaaHMoGsHS795XXuhlPGDPWry2dMrZ3lrSgIZF1AcMeeQgBInzPikETamhw /z65/tEk/1Ab+TL7R8nWFuoBuzuso50pTjKLK2y8AQVJY9ciL+E= =2EDp -----END PGP SIGNATURE----- --Apple-Mail=_47411303-6D07-4355-A91B-05597F78F9C8--