From nobody Fri Oct 02 11:24:40 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hx5zG4w5Gz6vCGC; Fri, 02 Oct 2026 11:24:42 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hx5zG3kRqz3LsG; Fri, 02 Oct 2026 11:24:42 +0000 (UTC) (envelope-from kevans@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790940282; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=RlWG1LbvLhLnACyLIz48xo/dITx2FVScdDUhZEmf/u8=; b=nU6iK4Brte7hM3i1FTW4asIaiBK5bor28u4B/ZZ70OAqpz9qgSDpsSqzM17Pj79Q1u/kNn pOdcHI5dbw5V+fcAOM1iAvTirssSlSMm/YQbXpJiy/JEBs/Oig5Hx5xQBkltHnoX7OkLwM Kgr7tyXFzZspvrOrh9c6hifKOt3fuLA3etKEezuY44pqZ2df0k/vV6+SOZ3s8FZvAC2I9r Gad57ZngvY2F/OFdqyamv/eDdG1xUGadBT1LGg012TOOsHKoXqKe4UfwlSZVdhnymEyYpY SbmKPDTLUCm4YZ7wqa+L1f7fH3NXX5l2uE7PmvMjavv1WKCPtZ7N2DYB00/RCA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1790940282; b=E7kF8DzN48uRo2SlRnQJCNsvT+ytxF58cSgWN+eoTykmT4PXJD3U6/0a3D4bVzoa92yzqL vJeJGqODcM01JdS/7j/q4qF3P3Folu1mhlKEy9YTYl5bhrwALCVMq9lbtFg17iK8HDOGEt LZKwbcJwqKJLqp40c0PtObqNZb95D30zoDBCyzgBQxUjafVO1ik7NEm6OXYgnHIsLvkXHs IjEAOFsVJpduFM9U95bF085lom3AX9RnoKMxp3awCMq1ZmE4ThMhtE61ZCWiy63gqFR8GC 4wXa05WIi2D81r85B7RizgqmSjOiwLv51dqebZ/YwDkObTKQ5Cg1gkdZReXp/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1790940282; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=RlWG1LbvLhLnACyLIz48xo/dITx2FVScdDUhZEmf/u8=; b=QB2NO0rB/rQL6HblV5QE1MVNnLhZcpUyqYS2bqdRVcVSa6WkiK3Jd3K/ue0Md+kiNxokwA kbapJoieC9NraaemYHYA4EAddCxPkino9b+oANAq7EVy44ffwpRKWv1puUITXGkBItCEDM XkGTFZvW7C6BJ7RpKmREpFnzMInicOkimYzDiSeWnYiz5oIKC8AXh8ZCwdph2EOz0j1Aat /Sw2rGeuS0bKZmkmaF5ptuykb9saLftujQ8Pu7wL7tLiOmGOAgiWngyAx2yc0RXaPEnytl ghRlOxtlThfZpV12NOu2oi3PrrW3r1nx7OqE+Lh8cJw08md/aEVBSK0Wf0Jeyw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [10.9.4.95] (unknown [209.182.120.176]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: kevans/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4hx5zG0Fl5ztg1; Fri, 02 Oct 2026 11:24:41 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Message-ID: <14fffc5e-7cb1-42b0-80fb-ac94a516f540@FreeBSD.org> Date: Fri, 2 Oct 2026 06:24:40 -0500 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 6f3445006aa0 - main - [tests] lib/libc/gen:assert_test: skip tests when NDEBUG set From: Kyle Evans To: Enji Cooper References: <6ab22091.3fd77.2b258f0@gitrepo.freebsd.org> Content-Language: en-US Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Autocrypt: addr=kevans@FreeBSD.org; keydata= xjMEWySaMRYJKwYBBAHaRw8BAQdAdk/Fqvvw2gwIzw2l1UAbv5mrT35Y5ylfHyUBEcWY3AzN H0t5bGUgRXZhbnMgPGtldmFuc0BGcmVlQlNELm9yZz7ClgQTFggAPgIbAwULCQgHAgYVCgkI CwIEFgIDAQIeAQIXgBYhBPv/ZC7g03RcLBP+TBlOtBOHRwt7BQJlp2YoBQkQJmZ1AAoJEBlO tBOHRwt7krYBAPnGTE/v9EcirWF5oGU+J19nr0wOpPCQzMOxCf5e2km5AQDHIznIhaLvZYUw LlxiBE7MEs/2w4WfXRgW+LuAkzedCc44BFskmjESCisGAQQBl1UBBQEBB0B84DgMSsY6hG+1 o57XJAuqj+dVfG+esKnEiO6T886KYAMBCAfCfgQYFggAJgIbDBYhBPv/ZC7g03RcLBP+TBlO tBOHRwt7BQJlp2ZOBQkQJmadAAoJEBlOtBOHRwt75v8A/Aq5ti6ACDG6/Hfodp9rfed9UQIH q45o6ymUj2TnhTJWAP45Wtv80BB+TiEcWCG7kcOYB3hcqZlD8k8vfito8b3KBA== In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 9/22/26 08:14, Kyle Evans wrote: > On 9/22/26 01:30, Enji Cooper wrote: >> The branch main has been updated by ngie: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=6f3445006aa05550f14af65b04276c3d25169941 >> >> commit 6f3445006aa05550f14af65b04276c3d25169941 >> Author:     Enji Cooper >> AuthorDate: 2026-09-22 06:22:57 +0000 >> Commit:     Enji Cooper >> CommitDate: 2026-09-22 06:30:30 +0000 >> >>      [tests] lib/libc/gen:assert_test: skip tests when NDEBUG set >>      In the event that NDEBUG is specified in CFLAGS--which is most likely >>      triggered via `MK_ASSERT_DEBUG` == "no" -- all assert(3) statements are >>      optimized out by design. This breaks the assert(3) tests as they >>      specifically rely on assert(3) actually raising a `SIGABRT` instead of >>      quietly succeeding. >>      Skip both tests if `NDEBUG` is set. There's no sense running the >>      `assert(true)` test if the result could instead be a false positive. >>      MFC after:      2 weeks >> --- >>   contrib/netbsd-tests/lib/libc/gen/t_assert.c | 20 ++++++++++++++++++++ >>   1 file changed, 20 insertions(+) >> > > Hi, > > Why not just #undef NDEBUG right before we include ?  Given that it's a test of the feature, > I think it makes plenty of sense to ignore the user-requested preference for just this one scenario > where we want to confirm that the feature isn't coincidentally broken. > > Thanks, > > Kyle Evans > Ping? I really don't think this is the approach we should be taking here, particularly when the alternative is robust and easy to implement. Thanks, Kyle Evans >> diff --git a/contrib/netbsd-tests/lib/libc/gen/t_assert.c b/contrib/netbsd-tests/lib/libc/gen/t_assert.c >> index ce73015142d6..b4023223b446 100644 >> --- a/contrib/netbsd-tests/lib/libc/gen/t_assert.c >> +++ b/contrib/netbsd-tests/lib/libc/gen/t_assert.c >> @@ -43,6 +43,18 @@ __RCSID("$NetBSD: t_assert.c,v 1.3 2017/01/10 15:17:57 christos Exp $"); >>   #include >>   #include >> +#ifdef    __FreeBSD__ >> +/* TODO: upstream this. */ >> +static void >> +skip_if_ndebug_set(void) >> +{ >> + >> +#ifdef    NDEBUG >> +    atf_tc_skip("Testcase requires code to be compiled without -DNDEBUG."); >> +#endif >> +} >> +#endif >> + >>   static void >>   disable_corefile(void) >>   { >> @@ -74,6 +86,10 @@ ATF_TC_BODY(assert_false, tc) >>       pid_t pid; >>       int sta; >> +#ifdef    __FreeBSD__ >> +    skip_if_ndebug_set(); >> +#endif >> + >>       pid = fork(); >>       ATF_REQUIRE(pid >= 0); >> @@ -112,6 +128,10 @@ ATF_TC_BODY(assert_true, tc) >>       pid_t pid; >>       int sta; >> +#ifdef    __FreeBSD__ >> +    skip_if_ndebug_set(); >> +#endif >> + >>       pid = fork(); >>       ATF_REQUIRE(pid >= 0); >