From nobody Tue Nov 03 03:04:13 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jJYM20BLtz6xj7M for ; Tue, 03 Nov 2026 03:04:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jJYM16N7Wz4Snr for ; Tue, 03 Nov 2026 03:04:13 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793675053; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Dpo4uUS4FZSX/oUPT1Y/quByyvF3irHsclZqYB/fyic=; b=xL50rsSckL4/Odbf6/8Vr1c4JzzylJUGbYD5CU4vH5jP9GVrOAvs6BPBVgY1qwX+HcwFPA tht+o0mxNlP+/KRDNWvBzJu6FI+QMOy/SQWtinQjM3D6ibrvhpHhor0xJOPgeF5n5Gbykj aLyvJEndJ+X3KfA0X70x4rRulYpYInkVCKowS2NyicvXRZgdIw+L/Q78EN+7MPLiztnzS2 Mx9fNWwhH2SE/azh4lk5I0x+ux6wATIni4ocmzsMZPX4NbNk1O7oARsnYZHuiuZw2GaJEk +M9AS8Fpxlk6J0s6/wY7gG9mih3wCuc+8a5KxyIHxSgDTAr9AMRtonJz5U3usQ== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793675053; b=fFE7XKyxn7baCoBUbbEumQvDwiWj6AiqthqktSi8w2Pdw36JDkEFukm8Tt2uf+g4PiTQLw 3E+sgjgvZF57Nwd83/d6owkTRfgsrQdf1d8hP12Ar5Cfi8A3WJK+YIPwcXrgp0rkGquja2 OMCKWg0DoSAYbf2sIokEt0f6a3++VN6sbNrC5Ivootz7WjVPoxQW00lzujKp+BYbCWuKOr eigei9EUf3B5VQJ8KWrV8j59zrbZUwQg4xh5kY+hyFpxKkHfVkGmPZUXKR5AWqAtHR2Ehb 9+tEJkren9cY1nnjCFOZSS8M0vEpH0rDkLcL97nKIkyOsPkTHe0h1N612T60uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793675053; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Dpo4uUS4FZSX/oUPT1Y/quByyvF3irHsclZqYB/fyic=; b=BSU8RBaV/5B0v/BfVsxhzIz+ufJeHz5Hc6BuTUXP1riMcKEC/PDNDkOxWyZV9KKjMXTMa4 WJ2XyKBLS3fF6zRSKGcedM9sD8MvDf3oLHu3WwiIQhI12/WAmzfAuSPaSYgCXpvKCGZjQN imaqWVkfhWrHDLVM8v9vMYe4pFF+3K190gOcLpoAodN7JhAFdQd9ROEbnRmVzgzr3onqmM m5IShJOwcuTUo13c52D5edJlNjMONPdUfnDdQxBJ3SjKC7Usqo9x29CUOVcqXWKDcY+cWA quyz4iRb5S1z1jUOHcmsLf0UqvIjy39nkxDlrc02o3SpqfK3V/XDxqlUipvUNw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jJYM162fGz1CmN for ; Tue, 03 Nov 2026 03:04:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3e55a by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 03 Nov 2026 03:04:13 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Xin LI Subject: git: fbac0abdc5ab - main - mqueuefs: set *a_eofflag in VOP_READDIR List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: Commit messages for the main branch of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: delphij X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: fbac0abdc5ab1fe867ac85635662ef06b2ee9d10 Auto-Submitted: auto-generated Date: Tue, 03 Nov 2026 03:04:13 +0000 Message-Id: <6ae94f2d.3e55a.618ae182@gitrepo.freebsd.org> The branch main has been updated by delphij: URL: https://cgit.FreeBSD.org/src/commit/?id=fbac0abdc5ab1fe867ac85635662ef06b2ee9d10 commit fbac0abdc5ab1fe867ac85635662ef06b2ee9d10 Author: Xin LI AuthorDate: 2026-11-03 03:02:03 +0000 Commit: Xin LI CommitDate: 2026-11-03 03:02:03 +0000 mqueuefs: set *a_eofflag in VOP_READDIR mqfs_readdir() never reported end of directory. Since 77b273d8f5f4 VOP_READDIR_APV() asserts that a readdir which returns no entries also sets *a_eofflag, so with INVARIANTS the final zero-length getdirentries(2) that ls(1) issues on a mounted mqueuefs panics: panic: VOP_READDIR: eofflag not set Report end of directory when the child list was walked to its end; leave the flag clear when the walk stopped because the buffer was full. MFC after: 1 week --- sys/kern/uipc_mqueue.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/kern/uipc_mqueue.c b/sys/kern/uipc_mqueue.c index 68eda5ecb039..cd402fa3e80b 100644 --- a/sys/kern/uipc_mqueue.c +++ b/sys/kern/uipc_mqueue.c @@ -1459,6 +1459,8 @@ mqfs_readdir(struct vop_readdir_args *ap) sx_xunlock(&mi->mi_lock); uio->uio_offset = offset; + if (ap->a_eofflag != NULL) + *ap->a_eofflag = (pn == NULL); if (tmp_ncookies != NULL) ap->a_ncookies = tmp_ncookies;