From nobody Mon Nov 02 21:44:53 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jJQGm1BlHz6ycMQ for ; Mon, 02 Nov 2026 21:45:04 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jJQGk0tt9z52wH for ; Mon, 02 Nov 2026 21:45:02 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of jrtc27@jrtc27.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=jrtc27@jrtc27.com Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-48e20edd106so2716587f8f.1 for ; Mon, 02 Nov 2026 13:45:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793655901; x=1794260701; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:content-type:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=2YBpg/e2BlYvx+GUacJp1iyv5mIRPSH1+oxhmjAfOE0=; b=aqBXV3EwuiO9aALo2ekmKvAJowhpi3NWx0qtjBb+S6O6Vgel6K151XtZ0ZVXUh93SG FmNKgJr86MgN5b96vdle94r/JU5fOJQLr8Srv8KwBQ59uccztWGQL/58V9iCoK97HLPf /FFycyStnV+3JWrpVu9soqiy6b/dTNgOoBp0pveyyrBFTNSj4c+dz3GydW+TjNdTYC2z zKHbAf/Coqx3c6sK0RxuhiMh/vcYofJoMUfLj3ZLSUGAFzWjhHM5L52g2pAfUd651P0c L1ortuPCD5jBa6xL0WgvaAtAufC/XDAWs7PtlCJAsHwx8Wd7vI9oIHbOW11T6i8QQA/Q 6oNw== X-Forwarded-Encrypted: i=1; AKwUvBzW4/BhKKWYMeNCLWNQNAugT+NOeURSSE3jYLDTe5uNVxaBdoMUHlaxepiZaNL/hEw/cw9O4NkbQubdRy/tCkFMszcIRA==@freebsd.org X-Gm-Message-State: APuU4Z92yajSaypatSe/yvPyOkaijcRP+mnZANo92hk5hKoUYgUcflL2 TQ7PxOeKMQ7iPp4qs4byZniwng69lsOLMMfp69ekDt5K3VBPOVxO8MZtL8mymkPg0WEPvO7TcWp 8NTTrbXQ= X-Gm-Gg: AYBFou2Ij+glm8kndem7G8ylQfSHl6y8hx32r4+7Hn2z3yUrEQsepvAEA5MFUhhpII1 cDS09QqlRiH/6X/bno5KBu1ka1nmzh1wSJlDVnKuMmX8z/rTr2piLuaEz1qWNMdcbbmgTSLgbXY t6lofdDafBhZAm5I/GrwV3gtUGMYoCDc4hkFfwtiFJ6/KvN/JOW8k9EMczvMymslcaJTBVPr1GJ mjrN4qILOse7KUJrq11jAKgrJD9oPK0p9MkTcoZLNY9SONN3lDmHaM3z3XHlb3htioi6zn7nJ/Y kIhE98sGh0mr2laaJ6+j73Ny9ccKqTc1I26vC3gKmYVB/S3sVg1I0+Fu3kDAaepqKa2zRGISVAU F/NxUzciXgSuuh7DLK8v55kPWQk0F2FHSXFzbFa8zzt7+o8Y7M3zQDEIpX0Zh2owbrIO0oMeKpY kBXgzel7H7CiXysQlF4+bPsb3kgSjqwCWlm/Khhl6sL/0m3JMIlVYJqckWrPtGcQDVtKwehSThu CcXp/oGmijTjvUB8rGoJrEepwJ0OiR5wPO17BJFqPiugSJnkEjwb9mjctlXxnZNDjueGj8E8+5y JlCQXw/HyxMi9ZED+/A5GluS/ys/BlFhOx5UXGcPWfRi7SD8PSVXLrLoMpCraqrgzMhu7KWRWBF 14q/JzZxWqsc1kgTOSWc0ioKIleI= X-Received: by 2002:a05:6000:2587:b0:48e:5d63:a4e5 with SMTP id ffacd0b85a97d-48e6e26184emr25471738f8f.0.1793655900825; Mon, 02 Nov 2026 13:45:00 -0800 (PST) Received: from smtpclient.apple (host86-142-176-254.range86-142.btcentralplus.com. [86.142.176.254]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48e71bab1a8sm21670476f8f.57.2026.11.02.13.44.58 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Nov 2026 13:45:00 -0800 (PST) Content-Type: text/plain; charset=us-ascii List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: Commit messages for the main branch of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3901.200.71.1.16\)) Subject: Re: git: ada1f577cc29 - main - bhyve/riscv: correctly handle empty masks and broadcast in SBI IPI/RFNC From: Jessica Clarke In-Reply-To: Date: Mon, 2 Nov 2026 21:44:53 +0000 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" , Doongar Singh , owner-src-committers@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <28C327C3-1FD6-4CDB-A8D8-02202698F779@freebsd.org> References: <6ae8fb7f.3f2ac.6d484a47@gitrepo.freebsd.org> To: Ruslan Bukin X-Mailer: Apple Mail (2.3901.200.71.1.16) X-Rspamd-Queue-Id: 4jJQGk0tt9z52wH X-Spamd-Bar: / X-Spamd-Result: default: False [0.60 / 15.00]; MV_CASE(0.50)[]; FORGED_SENDER(0.30)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.221.52:from]; ARC_NA(0.00)[]; FREEFALL_USER(0.00)[jrtc27]; TO_DN_EQ_ADDR_SOME(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; MID_RHS_MATCH_FROM(0.00)[]; R_DKIM_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[FreeBSD.org,gmail.com,freebsd.org]; RCVD_IN_DNSWL_NONE(0.00)[209.85.221.52:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; RCPT_COUNT_FIVE(0.00)[6] On 2 Nov 2026, at 21:33, Ruslan Bukin wrote: > On Mon Nov 2, 2026 at 9:10 PM UTC, Jessica Clarke wrote: >> On 2 Nov 2026, at 21:07, Ruslan Bukin wrote: >>>=20 >>> The branch main has been updated by br: >>>=20 >>> URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dada1f577cc291336cbb69782075dbbf9= fe746872 >>>=20 >>> commit ada1f577cc291336cbb69782075dbbf9fe746872 >>> Author: Doongar Singh >>> AuthorDate: 2026-11-02 20:58:53 +0000 >>> Commit: Ruslan Bukin >>> CommitDate: 2026-11-02 21:05:46 +0000 >>>=20 >>> bhyve/riscv: correctly handle empty masks and broadcast in SBI = IPI/RFNC >>>=20 >>> Bhyve treats an empty cpu set as an error which triggers MPASS = panic in >>> the guest. As per the SBI spec, empty masks should return = SBI_SUCCESS, >>> and a base of -1UL specifies a broadcast to all harts. Fix both = in >>> vmm_sbi.c, clear a1 on return, and skip the SBI ecall in >>> sbi_ipi_pic_ipi_send() if the mask is empty. Also add a NULL check = in >>> riscv_send_ipi(). >>=20 >> Please revert this so it can be landed as several minimal commits = that >> each do one thing, not one big commit that does more things that >> necessary all at once. See my initial feedback on the revision, = though >> I am still reading through the rest of it. >>=20 >=20 > Sounds good. Was a bit in a hurry as bhyve guest currently does not = boot > without some of these bugfixes. Yeah, I assumed that was the case. Unfortunately I had started reviewing the changes earlier in the evening but broke for dinner, and only submitted the initial couple of comments a few minutes before your push. Jessica