From nobody Mon Nov 02 21:33:04 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jJQCx0CLHz6ycX0; Mon, 02 Nov 2026 21:42:37 +0000 (UTC) (envelope-from br@bsdpad.com) Received: from mail.bsdpad.com (mail.bsdpad.com [91.99.52.19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jJQCw1t8kz51yW; Mon, 02 Nov 2026 21:42:36 +0000 (UTC) (envelope-from br@bsdpad.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdpad.com header.s=20201212 header.b="FZE/1TKX"; spf=pass (mx1.freebsd.org: domain of br@bsdpad.com designates 91.99.52.19 as permitted sender) smtp.mailfrom=br@bsdpad.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=freebsd.org (policy=none) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=bsdpad.com; s=20201212; h=From:To:Subject; bh=HrHJugYBwk4Eg7DMcXvCe/CR8DffUKwXQ73iFK227b8=; b=FZE/1TKXuFrT9FyIPpmhV63M9u bUVuZ3TxhcE8FaZw+Pq3twSJurSKaP9IYM5CcmH+acqido6vQokTgkKnyN+nUMM+HHIdSsN95xAIr 3+g6yeK60KigvI3vvVerHFQr+W79T3SZQyzeS7Mck6RrrUIFNIat/ffvrvXBZCDpo76qKFyrkRh5E U5v/Ch2F2k+513hDcDwdjWP257q/JJC2hbAmO8asIicGeyVeJgcpAKoN9lbxgB6pRYhxdrQDEXYbP udnveE/tTe990OQSPPhZvG9xZoRIoZ2uQMIqeoiCtRt7+TE7Ly8DUB8OqGny20whX1O5nr6PxozWn MT9OF3pA==; Received: from mail.bsdpad.com ([91.99.52.19] helo=localhost) by mail.bsdpad.com with esmtpsa (TLS1.3) tls TLS_AES_128_GCM_SHA256 (Exim 4.99.3 (FreeBSD)) (envelope-from ) id 1xNzUU-00000000FxG-0jay; Mon, 02 Nov 2026 21:33:04 +0000 List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: Commit messages for the main branch of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 02 Nov 2026 21:33:04 +0000 Message-Id: Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" , "Doongar Singh" , Subject: Re: git: ada1f577cc29 - main - bhyve/riscv: correctly handle empty masks and broadcast in SBI IPI/RFNC To: "Jessica Clarke" From: "Ruslan Bukin" X-Mailer: aerc References: <6ae8fb7f.3f2ac.6d484a47@gitrepo.freebsd.org> In-Reply-To: X-Rspamd-Queue-Id: 4jJQCw1t8kz51yW X-Spamd-Bar: / X-Spamd-Result: default: False [0.41 / 15.00]; MV_CASE(0.50)[]; FORGED_SENDER(0.30)[br@FreeBSD.org,br@bsdpad.com]; R_SPF_ALLOW(-0.20)[+mx]; R_DKIM_ALLOW(-0.20)[bsdpad.com:s=20201212]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), DKIM not aligned (relaxed),none]; MIME_GOOD(-0.10)[text/plain]; XM_UA_NO_VERSION(0.01)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEFALL_USER(0.00)[br]; TO_DN_EQ_ADDR_SOME(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_ONE(0.00)[1]; ASN(0.00)[asn:24940, ipnet:91.99.0.0/16, country:DE]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@FreeBSD.org,dev-commits-src-main@FreeBSD.org]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[FreeBSD.org,gmail.com,freebsd.org]; RCPT_COUNT_FIVE(0.00)[6]; ARC_NA(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_NEQ_ENVFROM(0.00)[br@FreeBSD.org,br@bsdpad.com]; DKIM_TRACE(0.00)[bsdpad.com:+] On Mon Nov 2, 2026 at 9:10 PM UTC, Jessica Clarke wrote: > On 2 Nov 2026, at 21:07, Ruslan Bukin wrote: >>=20 >> The branch main has been updated by br: >>=20 >> URL: https://cgit.FreeBSD.org/src/commit/?id=3Dada1f577cc291336cbb697820= 75dbbf9fe746872 >>=20 >> commit ada1f577cc291336cbb69782075dbbf9fe746872 >> Author: Doongar Singh >> AuthorDate: 2026-11-02 20:58:53 +0000 >> Commit: Ruslan Bukin >> CommitDate: 2026-11-02 21:05:46 +0000 >>=20 >> bhyve/riscv: correctly handle empty masks and broadcast in SBI IPI/RF= NC >>=20 >> Bhyve treats an empty cpu set as an error which triggers MPASS panic = in >> the guest. As per the SBI spec, empty masks should return SBI_SUCCESS= , >> and a base of -1UL specifies a broadcast to all harts. Fix both in >> vmm_sbi.c, clear a1 on return, and skip the SBI ecall in >> sbi_ipi_pic_ipi_send() if the mask is empty. Also add a NULL check in >> riscv_send_ipi(). > > Please revert this so it can be landed as several minimal commits that > each do one thing, not one big commit that does more things that > necessary all at once. See my initial feedback on the revision, though > I am still reading through the rest of it. > Sounds good. Was a bit in a hurry as bhyve guest currently does not boot without some of these bugfixes. Ruslan