From nobody Mon Nov 02 21:10:15 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jJPVt04kKz6yY1K for ; Mon, 02 Nov 2026 21:10:30 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jJPVr5Gl7z4vCg for ; Mon, 02 Nov 2026 21:10:28 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of jrtc27@jrtc27.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=jrtc27@jrtc27.com Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-48e04773687so1053234f8f.2 for ; Mon, 02 Nov 2026 13:10:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793653827; x=1794258627; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:content-type:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=QF3GCCBDJAI9NyuljuETz+ank9muKUDZjyurYMdAIX8=; b=ub5Nm9ngKroKW7/ooWBx7/nzjzkvtXJPj9AiQxXX6OcwQsXEFur0t2QqpqF76eG6ja F3Yr+g5RHHn1tclW2L7CrRwl/NrGx88wam1iM2Xtt9TbvViCYnkgAVDDudLLIqbrigsc O8SCogaBXwhBvp35Hp+uFQ6PB32AZc9qfOh9mpdFz+iUqVAAK1ugOkgIq4WLlAxiwHAf GPaPlZtnM+i6kN09AMkmq6SPU1Z5ULyYCfdOIXfdr5zelkUBnGlxUBceAuC3qG7Otcjn XEAuG12iqaw/o+ky7hoIdlJCUFjJKsRcomYofXXHpGGvl+jYamnwAYnScxEciiBytpyL oKDw== X-Forwarded-Encrypted: i=1; AKwUvByuGlucTuG0s78jEPLLnnGpNC/v/dN8J+boT1kDIApKjBqlUkcOf3hTdiGCOMn81IMC3i6Aume7NXVQE6cXG+SPMsLVyA==@freebsd.org X-Gm-Message-State: APuU4Z8T08ztPpvthVqkCsuIoDMd0gihMk0R33Kl4WGGgx5zrHKi84Tj eCNR7uhIaiF2G39Ef0AKNsF7GYz2n56YVaL0wM3oyx/nvQJxosRDaxz2/y8Ex7Q3M+0= X-Gm-Gg: AYBFou0J+Skppm5RYBqevCSTx9rQz9N0ses5BPGh54/7XbfD0PS6A/BP+B1gZjS9B+h yrUd4IjzDrJIK2LwKrjkfIN1FIysBGKWYgZN5QrybvhUmPPpUOxEFCIh+GyJnfAbfHlx+e1Wcnl zpQvN7THKjMFGfqyC4GXfwoSCxMyzIoKU6Sw3hGN54SUonHML8BlnBZ0XFFr57eD5lxEYO6XTkS 4ApSMwyTK/CIyFQe9YAwz1MMH5ZBC6D6aZANtnUHoq8pCYcDVz/5/KJHmty/cr2gb+dLdGsK8hA wC1mgTtmmBLUsRWT55NH3H7vbRbUWXqXIttkL4YIguPTqGtjOq4UoIXNZx1AtxqUhbtxb5BiKNh TEftNL/yg+PeEbLzBJ3ruz8ppzPsKCWyMdZJm5nVVzBZn1rsfj5LeVD9DdAOntZGNwNGY5PWweL M2O2loJTWxelCz3UQDN/aOvVB2aaOh+ZfUr8MtyZPQ7wrWrMlUY1C9N7w9gZBgvQHt9kfmx3m3i jYSVljHpRC1OqO7fKWd9J5Ac7o3XkBgD54IcxufS4/qxp0LG93PeVG8h6jdSi+K0XukR9cv08ZD qCm+UCU8kPjq0A1RN4dyv7IDoOxv0Jr8/Zt1nWM2L9wdLjG6KiSm77SgEaTyUm3THRCexrISt++ CizI9vZ0lJ+ujYACko7Mnp8R2e8A= X-Received: by 2002:a05:6000:184d:b0:48d:fbf2:555f with SMTP id ffacd0b85a97d-48e6e518487mr27775070f8f.55.1793653827267; Mon, 02 Nov 2026 13:10:27 -0800 (PST) Received: from smtpclient.apple (host86-142-176-254.range86-142.btcentralplus.com. [86.142.176.254]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48e71b78c10sm21280729f8f.25.2026.11.02.13.10.25 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Nov 2026 13:10:26 -0800 (PST) Content-Type: text/plain; charset=us-ascii List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: Commit messages for the main branch of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3901.200.71.1.16\)) Subject: Re: git: ada1f577cc29 - main - bhyve/riscv: correctly handle empty masks and broadcast in SBI IPI/RFNC From: Jessica Clarke In-Reply-To: <6ae8fb7f.3f2ac.6d484a47@gitrepo.freebsd.org> Date: Mon, 2 Nov 2026 21:10:15 +0000 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" , Doongar Singh Content-Transfer-Encoding: quoted-printable Message-Id: References: <6ae8fb7f.3f2ac.6d484a47@gitrepo.freebsd.org> To: Ruslan Bukin X-Mailer: Apple Mail (2.3901.200.71.1.16) X-Rspamd-Queue-Id: 4jJPVr5Gl7z4vCg X-Spamd-Bar: / X-Spamd-Result: default: False [0.60 / 15.00]; MV_CASE(0.50)[]; FORGED_SENDER(0.30)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.221.46:from]; ARC_NA(0.00)[]; FREEFALL_USER(0.00)[jrtc27]; TO_DN_EQ_ADDR_SOME(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; MID_RHS_MATCH_FROM(0.00)[]; R_DKIM_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[FreeBSD.org,gmail.com]; RCVD_IN_DNSWL_NONE(0.00)[209.85.221.46:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; RCPT_COUNT_FIVE(0.00)[5] On 2 Nov 2026, at 21:07, Ruslan Bukin wrote: >=20 > The branch main has been updated by br: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dada1f577cc291336cbb69782075dbbf9= fe746872 >=20 > commit ada1f577cc291336cbb69782075dbbf9fe746872 > Author: Doongar Singh > AuthorDate: 2026-11-02 20:58:53 +0000 > Commit: Ruslan Bukin > CommitDate: 2026-11-02 21:05:46 +0000 >=20 > bhyve/riscv: correctly handle empty masks and broadcast in SBI = IPI/RFNC >=20 > Bhyve treats an empty cpu set as an error which triggers MPASS = panic in > the guest. As per the SBI spec, empty masks should return = SBI_SUCCESS, > and a base of -1UL specifies a broadcast to all harts. Fix both in > vmm_sbi.c, clear a1 on return, and skip the SBI ecall in > sbi_ipi_pic_ipi_send() if the mask is empty. Also add a NULL check = in > riscv_send_ipi(). Please revert this so it can be landed as several minimal commits that each do one thing, not one big commit that does more things that necessary all at once. See my initial feedback on the revision, though I am still reading through the rest of it. Jessica