From nobody Mon Nov 02 15:58:38 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jJGb270nxz6xtSv for ; Mon, 02 Nov 2026 15:58:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jJGb26Vk3z4fDN for ; Mon, 02 Nov 2026 15:58:38 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793635118; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=n6xNrV9bSCrEU/C3OcwWvK+x6AaI03DR8zxRcM3aOwM=; b=xOaDZwujEXxMegkWeK8SV5gkFwLjej1/9ajnBn6JIlb3UuUwjNoqThODtxV9QyHwrPQvgx /6BUeeXW5Ul3gxgWebWpakF39z/BFI9NaOXT6jzZfq1oDqwp7s6JEfEGNiQNUD5JrRLyU3 zsIqrqpyMyrPKYgJD6QUIqTh2/tf3036g5x/38tPQjDBNX1/kkk0KWkqXxqrOnpa7X06SW U7NWcvzpzocTD1Rdq5sFxbKODqmAE+7XXw/Rv7r5D1zQ+dCo9/2ojDW/DCwdIN8yZGnpBw rPOnLXqQzZZfKbqRECtP2Vp5CpiHkZxd9Wg8v52OIcbKWU/REOii4dNIqSmYXw== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1793635118; b=ORxBRivpYC3Lc+pcAZ22DuyRbnxpsIc3UiLuv3r0gdZfRZaRcURCWEyhCUozmqjo4jeHDg YhKB4HHQQ9dFY2KxyGMVjb2ALE/I17EabNxwqSCtf23nVYOITf/unO1i6LCrlNk4FkLJ2m ikCaPScT1ya/B/YnPzEYQrNOPYF/ZjjkuwtVun4P73PZjsEAFwSCbKouNA6ILieYOnGQSf hpt2vM/7VUugERd/neqw4iY2YtFmU1MxYvArIg0aDu6tuRk8NOjluvKsSBWTREcuCIxQuK iCXxZGlj5bUBa0MBH/mVw9jZdzwnEbcj0a93aC+AuVQrhlwgDetngNjGq7Yn4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1793635118; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=n6xNrV9bSCrEU/C3OcwWvK+x6AaI03DR8zxRcM3aOwM=; b=Ar13uTM4GIBJQm2fJRAORHCkFE3MfsytsPHhTwkgYeAbB90mWHZOZCt+1Z2OPiQXcM3IBt 9xThyTiGYFaXbveybBMh9vC0oCm6G0AXM8G+wAR6rCfTuvpuYAJKSFcNdSRk+fJGaSqijr tLQYSkAjZc3x3vNh690mOiaVVFlY8gXvACYgmjGGePKc+L4s7CjO02VKc3gvnEKPfi5W9g BIvn9vVZLaCylBkDyeeEWf+4rpL5FMpmEzezGsR/SiRjgQ896pSTob2oPj6TthO7GDp0Aq NJwgsg3ut1dHznww5ck+VNXO7QQFTYZce0Op/4jZxRGPvnsvHfOU8Ukz6ZtTUQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4jJGb265gQzsTy for ; Mon, 02 Nov 2026 15:58:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 4435c by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 02 Nov 2026 15:58:38 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andrew Gallatin Subject: git: 0b420c655f81 - main - lacp: fix lacp for interfaces with unknown media List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: Commit messages for the main branch of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: gallatin X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 0b420c655f816a31165c457b9462183b25eaecf2 Auto-Submitted: auto-generated Date: Mon, 02 Nov 2026 15:58:38 +0000 Message-Id: <6ae8b32e.4435c.3b3443d3@gitrepo.freebsd.org> The branch main has been updated by gallatin: URL: https://cgit.FreeBSD.org/src/commit/?id=0b420c655f816a31165c457b9462183b25eaecf2 commit 0b420c655f816a31165c457b9462183b25eaecf2 Author: Andrew Gallatin AuthorDate: 2026-11-02 15:53:34 +0000 Commit: Andrew Gallatin CommitDate: 2026-11-02 15:58:28 +0000 lacp: fix lacp for interfaces with unknown media Fall back to if_baudrate if ifmedia_baudrate() returns 0 in lacp_aggregator_bandwidth(). When lacp_aggregator_bandwidth() returns 0, lacp will never come up, due to aggregator selection starting with a 0. This is why its important for interfaces with unknown media (meaning ifmedia_baudrate() returns 0) to fall back to using if_baudrate in order to avoid this state. Differential Revision: https://reviews.freebsd.org/D61084 Reviewed by: kbowling Sponsored by: Netflix --- sys/net/ieee8023ad_lacp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/net/ieee8023ad_lacp.c b/sys/net/ieee8023ad_lacp.c index 7861dfe455ca..92f45a3c74c4 100644 --- a/sys/net/ieee8023ad_lacp.c +++ b/sys/net/ieee8023ad_lacp.c @@ -960,6 +960,8 @@ lacp_aggregator_bandwidth(struct lacp_aggregator *la) } speed = ifmedia_baudrate(lp->lp_media); + if (speed == 0) + speed = lp->lp_ifp->if_baudrate; speed *= la->la_nports; if (speed == 0) { LACP_DPRINTF((lp, "speed 0? media=0x%x nports=%d\n",