Re: git: 83d0eed50106 - main - lan867xphy: New driver for Microchip LAN8670/1/2 10BASE-T1S PHYs

From: Enji Cooper (yaneurabeya) <yaneurabeya_at_gmail.com>
Date: Sun, 01 Nov 2026 00:51:34 UTC
> On Oct 30, 2026, at 7:03 AM, Ed Maste <emaste@FreeBSD.org> wrote:
> 
> The branch main has been updated by emaste:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=83d0eed501060a733753c57c85da3abab4c973ad
> 
> commit 83d0eed501060a733753c57c85da3abab4c973ad
> Author:     Ed Maste <emaste@FreeBSD.org>
> AuthorDate: 2026-05-04 22:45:56 +0000
> Commit:     Ed Maste <emaste@FreeBSD.org>
> CommitDate: 2026-10-30 14:03:21 +0000
> 
>    lan867xphy: New driver for Microchip LAN8670/1/2 10BASE-T1S PHYs
> 
>    10BASE-T1S is a Single Pair Ethernet (SPE) standard, intended for
>    automotive and industrial applications.  It supports a multidrop "mixing
>    segment" of at least 25m with up to 8 nodes.
> 
>    This driver currently does not support per-silicon-revision config or
>    PHY-Level Collision Avoidance (PLCA), but is sufficient for establishing
>    basic connectivity.
> 
>    Device details are available in the "Microchip LAN8670/1/2 10BASE-T1S
>    Ethernet PHY Transceiver Datasheet”.

Hi Ed,
	This unfortunately broke the LINT-NOVIMAGE build :/… I’m not sure (yet) why this build issue was only flagged with LINT-NOVIMAGE >_>…
Cheers,
-Enji

```
/scratch/tmp/ngie/src/sys/dev/mii/lan867xphy.c:110:1: error: expected identifier
  110 | DRIVER_MODULE(lan867xphy, miibus, lan867x_driver, 0, 0);
      | ^
/scratch/tmp/ngie/src/sys/sys/bus.h:941:2: note: expanded from macro 'DRIVER_MODULE'
  941 |         EARLY_DRIVER_MODULE(name, busname, driver, evh, arg,            \
      |         ^
/scratch/tmp/ngie/src/sys/sys/bus.h:933:2: note: expanded from macro 'EARLY_DRIVER_MODULE'
  933 |         EARLY_DRIVER_MODULE_ORDERED(name, busname, driver, evh, arg,    \
      |         ^
/scratch/tmp/ngie/src/sys/sys/bus.h:928:12: note: expanded from macro 'EARLY_DRIVER_MODULE_ORDERED'
  928 | };                                                                      \
      |                                                                         ^
/scratch/tmp/ngie/src/sys/sys/module.h:154:2: note: expanded from macro '\
DECLARE_MODULE'
  154 |         DECLARE_MODULE_WITH_MAXVER(name, data, sub, order, MODULE_KERNEL_MAXVER)
      |         ^
/scratch/tmp/ngie/src/sys/sys/module.h:146:58: note: expanded from macro 'DECLARE_MODULE_WITH_MAXVER'
  146 |         SYSINIT(name##module, sub, order, module_register_init, &data); \
      |                                                                 ^
/scratch/tmp/ngie/src/sys/dev/mii/lan867xphy.c:110:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Werror,-Wimplicit-int]
/scratch/tmp/ngie/src/sys/sys/bus.h:941:2: note: expanded from macro 'DRIVER_MODULE'
  941 |         EARLY_DRIVER_MODULE(name, busname, driver, evh, arg,            \
      |         ^
/scratch/tmp/ngie/src/sys/sys/bus.h:933:2: note: expanded from macro 'EARLY_DRIVER_MODULE'
  933 |         EARLY_DRIVER_MODULE_ORDERED(name, busname, driver, evh, arg,    \
      |         ^
/scratch/tmp/ngie/src/sys/sys/bus.h:928:12: note: expanded from macro 'EARLY_DRIVER_MODULE_ORDERED'
  928 | };                                                                      \
      |                                                                         ^
/scratch/tmp/ngie/src/sys/sys/module.h:154:2: note: expanded from macro '\
DECLARE_MODULE'
  154 |         DECLARE_MODULE_WITH_MAXVER(name, data, sub, order, MODULE_KERNEL_MAXVER)
      |         ^
/scratch/tmp/ngie/src/sys/sys/module.h:146:2: note: expanded from macro 'DECLARE_MODULE_WITH_MAXVER'
  146 |         SYSINIT(name##module, sub, order, module_register_init, &data); \
      |         ^
/scratch/tmp/ngie/src/sys/dev/mii/lan867xphy.c:110:1: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
/scratch/tmp/ngie/src/sys/sys/bus.h:941:2: note: expanded from macro 'DRIVER_MODULE'
  941 |         EARLY_DRIVER_MODULE(name, busname, driver, evh, arg,            \
      |         ^
/scratch/tmp/ngie/src/sys/sys/bus.h:933:2: note: expanded from macro 'EARLY_DRIVER_MODULE'
  933 |         EARLY_DRIVER_MODULE_ORDERED(name, busname, driver, evh, arg,    \
      |         ^
/scratch/tmp/ngie/src/sys/sys/bus.h:928:12: note: expanded from macro 'EARLY_DRIVER_MODULE_ORDERED'
  928 | };                                                                      \
      |                                                                         ^
/scratch/tmp/ngie/src/sys/sys/module.h:154:2: note: expanded from macro '\
DECLARE_MODULE'
  154 |         DECLARE_MODULE_WITH_MAXVER(name, data, sub, order, MODULE_KERNEL_MAXVER)
      |         ^
/scratch/tmp/ngie/src/sys/sys/module.h:146:9: note: expanded from macro 'DECLARE_MODULE_WITH_MAXVER'
  146 |         SYSINIT(name##module, sub, order, module_register_init, &data); \
      |                ^
3 errors generated.
--- lan867xphy.o ---
*** [lan867xphy.o] Error code 1
       make[5]: stopped making "all" in /scratch/tmp/ngie/obj/scratch/tmp/ngie/src/amd64.amd64/sys/LINT-NOVIMAGE
make[5]: 1 error
       make[5]: stopped making "all" in /scratch/tmp/ngie/obj/scratch/tmp/ngie/src/amd64.amd64/sys/LINT-NOVIMAGE
      186.08 real        95.46 user         5.40 sys
--- buildkernel ---
```