git: d66fec481bfd - main - netlink: Fix lock leak in nl_find_nhop
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Fri, 22 May 2026 00:40:08 UTC
The branch main has been updated by emaste:
URL: https://cgit.FreeBSD.org/src/commit/?id=d66fec481bfd65cbabb6c12a410d76843e76083e
commit d66fec481bfd65cbabb6c12a410d76843e76083e
Author: Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2026-05-21 21:14:41 +0000
Commit: Ed Maste <emaste@FreeBSD.org>
CommitDate: 2026-05-22 00:38:45 +0000
netlink: Fix lock leak in nl_find_nhop
Reviewed by: bz, pouria
Fixes: 7e5bf68495cc ("netlink: add netlink support")
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D57156
---
sys/netlink/route/nexthop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sys/netlink/route/nexthop.c b/sys/netlink/route/nexthop.c
index 314fb66431b9..0b4a929f65a6 100644
--- a/sys/netlink/route/nexthop.c
+++ b/sys/netlink/route/nexthop.c
@@ -173,7 +173,7 @@ nl_find_nhop(uint32_t fibnum, int family, uint32_t uidx,
CHT_SLIST_FIND_BYOBJ(&ctl->un_head, unhop, &key, unhop);
if (unhop != NULL) {
struct nhop_object *nh = unhop->un_nhop;
- UN_RLOCK(ctl);
+ UN_RUNLOCK(ctl);
*perror = 0;
nhop_ref_any(nh);
return (nh);