From nobody Wed May 20 14:54:05 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gLF1B5K2Bz6dvRb for ; Wed, 20 May 2026 14:54:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gLF196wdHz3gb0 for ; Wed, 20 May 2026 14:54:05 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779288846; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vV7MkBd0QoXvHQgrdaiEhZtuz24UAx8h5XEjMdhRsuY=; b=UWsReIRYzO5K9UFBMrmAzaHmEkpex8JAbeP7CviINAabQsH1qgj+YxwLDOsBndxmBFWCC5 3+fRhvPXpCgau+9bciMDUntMaODyiRKTl/2LyvAVsYTaFr2reYHX0Tx1pfreKrt4VtcLhk 5C8C4Gtcur/xpU8J20Wq61uwIbwtcr1L3SzM4qaOelKC88HUTmOXDcHqCPz9dkuCuvPqJN A9E99DQlLbmuu5xvSL6zOVL5KFg7MpzVqzmXntkkgJgEgXyYWjqpCFqSmVgSqLMaed4DEf vrARZcYq2idcxO1BWwBVP7SKLxKzRT4XGb0A5N9VFsQcxgRwkd+fDnmaAJqGzQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1779288846; a=rsa-sha256; cv=none; b=ema37EvUHuQbJRdDMsW1EXXWm+wXd6STlmB6StBLB837NFPdBRkxFLpW68f/9aibyr8UJ9 9t6I6uQpnOknbudcB5C6l3Usw0RteutsJS4NhrNMkVnq56MqqiPHkv11o2wVccqazQpxGO kI84I5zhToc1a72GxiuaJcGXoUTjY7vNi6tyYyuhHoGmJoruP6WNHX0WUgHaNlNn/QfGgK ya9WSCHcw0ZkV4rUlwCU+XFoSE/rE9cZleNJWRTyZEfunODooXuQwLSsXiy1JM1ltIPQv+ 12ZEEt9W71s5CxZbNDPDBgRRfwOKRp1+lvwuFQNIpBuKnHtp19qnKwEfxvilSg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779288846; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vV7MkBd0QoXvHQgrdaiEhZtuz24UAx8h5XEjMdhRsuY=; b=oaptV1euvR4cW0SlwarM+8sdsI8wsoAA295KADPPbyLs+xBKwpHf2Co+SiRqIbqKPi9yPm TQRlBQcq9KMkXZizoARFlK9JaYuzx3Wk6J/iVFGDDfyOvvLweBEWqsnaqvQ6J70PwcxCl8 t5Gn/lchfQyDwTijchiKS/Qv8eEOd/DjrERxKpqWe0iCWdmgXfXNEQAVce/nPzqxzgJuKc +pgNyDvm0cV9AiJDj+5fXXNAwqZdHUZUrfae7+bd7J4suc+G1ruFMm+ynNoXgc7FQQh7Sp qIsY4RdgwzdgUdaw34eU6a0jJw8QekOhSuOupZlew7QIgE4OgmzlbeN3zj8xUg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gLF196Ft9z15XL for ; Wed, 20 May 2026 14:54:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 415d7 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 20 May 2026 14:54:05 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: d6f0e671d079 - main - kinst/arm64: Fix return values from kinst_invop() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d6f0e671d0797b56011880f84d12ce5fb20bf099 Auto-Submitted: auto-generated Date: Wed, 20 May 2026 14:54:05 +0000 Message-Id: <6a0dcb0d.415d7.3fa5169d@gitrepo.freebsd.org> The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=d6f0e671d0797b56011880f84d12ce5fb20bf099 commit d6f0e671d0797b56011880f84d12ce5fb20bf099 Author: Mark Johnston AuthorDate: 2026-05-20 14:49:28 +0000 Commit: Mark Johnston CommitDate: 2026-05-20 14:49:28 +0000 kinst/arm64: Fix return values from kinst_invop() After commit 853cd8723494 it became invalid for kinst_invop() to return 0: dtrace_invop_start() would convert this to a sentinel value indicating that it did not consume the breakpoint, and so we'd just call kdb_trap() to handle it. Change kinst_invop() to return NOP_INSTR after handling a matching breakpoint. NOP_INSTR is handled by advancing the ELR, so we have to compensate by subtracting INSTR_SIZE before returning. Reviewed by: christos MFC after: 1 week Fixes: 853cd8723494 ("arm64: Clean up usage of the dtrace invop handler") Differential Revision: https://reviews.freebsd.org/D56987 --- sys/cddl/dev/kinst/aarch64/kinst_isa.c | 38 ++++++++++++++++++---------------- 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a/sys/cddl/dev/kinst/aarch64/kinst_isa.c b/sys/cddl/dev/kinst/aarch64/kinst_isa.c index 20ca26219a55..1ccfe20b8dcb 100644 --- a/sys/cddl/dev/kinst/aarch64/kinst_isa.c +++ b/sys/cddl/dev/kinst/aarch64/kinst_isa.c @@ -18,7 +18,7 @@ DPCPU_DEFINE_STATIC(struct kinst_cpu_state, kinst_state); -static int +static void kinst_emulate(struct trapframe *frame, const struct kinst_probe *kp) { kinst_patchval_t instr = kp->kp_savedval; @@ -132,17 +132,13 @@ kinst_emulate(struct trapframe *frame, const struct kinst_probe *kp) else frame->tf_elr += INSN_SIZE; } - - return (0); } static int kinst_jump_next_instr(struct trapframe *frame, const struct kinst_probe *kp) { - frame->tf_elr = (register_t)((const uint8_t *)kp->kp_patchpoint + - INSN_SIZE); - - return (0); + frame->tf_elr = (register_t)(uintptr_t)kp->kp_patchpoint; + return (NOP_INSTR); } static void @@ -215,21 +211,27 @@ kinst_invop(uintptr_t addr, struct trapframe *frame, uintptr_t scratch) dtrace_probe(kp->kp_id, 0, 0, 0, 0, 0); cpu->cpu_dtrace_caller = 0; - if (kp->kp_md.emulate) - return (kinst_emulate(frame, kp)); + if (kp->kp_md.emulate) { + kinst_emulate(frame, kp); + } else { + ks->state = KINST_PROBE_FIRED; + ks->kp = kp; - ks->state = KINST_PROBE_FIRED; - ks->kp = kp; + /* + * Cache the current SPSR and clear interrupts for the duration + * of the double breakpoint. + */ + ks->status = frame->tf_spsr; + frame->tf_spsr |= PSR_I; + frame->tf_elr = (register_t)kp->kp_tramp; + } /* - * Cache the current SPSR and clear interrupts for the duration - * of the double breakpoint. + * NOP_INSTR is handled in dtrace_invop_start() by advancing the ELR, so + * compensate by subtracting INSTR_SIZE before returning. */ - ks->status = frame->tf_spsr; - frame->tf_spsr |= PSR_I; - frame->tf_elr = (register_t)kp->kp_tramp; - - return (0); + frame->tf_elr -= INSN_SIZE; + return (NOP_INSTR); } void