From nobody Sun May 17 19:44:49 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gJWc13gVYz6ctyB for ; Sun, 17 May 2026 19:44:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gJWc12rMmz3L8p for ; Sun, 17 May 2026 19:44:49 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779047089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gI+0l6tqk+HdCCTSIQYEhQUBJuTa7uDgHquZV313aWM=; b=YcSdkyNRO9e+TF5gwl6hsByMZQ4M1xnFRWEPUv4y4ZigCY1AMwcYWW0fYx6vCSJHJ0IxQz z1jQq2spLZctTVm7kM2AXmdXnhLaloZHGzHuVEqjoZle/VZMJJNOvq1dNTWkcqoWS19qgK Asw7vKMgtaE+S9Rfe5dA3KsoC+E3AVMJFnJoeSogI2EEYdOg5c+1VL9fvkZ2zMKUqVvGgD OpxmKW8YJvqb1uhI8YRHjKS7dxjyf/dVXawEeYdN7RCZAbyzTJCEzfTxsRCFLw8IvFZV67 Dt2MxHJ1QjdVC4Ho/y+ypovPZ9hVO9PYnDhN/hovB1UjEYBrGXXNHkA2QllbIA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1779047089; a=rsa-sha256; cv=none; b=hZ4szaPMvORzSYbUGNOOvG4TOTXH+bmRHLhBYDhnHBJu5UllHNR4KQvQ4Lxz/EB54uoNLJ jUVogiP4EKHoHIM0kECDFmT5hzN7l+Z91XuhpA0evO8dZThMt9YylsJV9wIdKniirdyZdI 1pXgenUa6gyJYBfhJE1iW5UIicxfJhDgh63NwfjTYGwnLYXhCIgmXJogI9E3a162uGUQfj M6x1XJNbRyHISnhNeo6VzDFWQmABj3hjBjvfbZig2cKCqlEaQndVAdV0D72o+9BhF5wsOb cX+NSV9GtMg38roWod2fwWnhUEbteh/7fEstya6dyb59GksFV/tMiSznuqKOJw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779047089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gI+0l6tqk+HdCCTSIQYEhQUBJuTa7uDgHquZV313aWM=; b=IexozvV/vQkS5VatTu5aYnzLTYsVL6xDIQeGm0aSHWJJlzW2qn5l84ux9aBE9kKPghi31q 2FqWomcWUz/KjM0pYil30cTBI1Yl0qD5fUe97ipLaT7xYutaQR9ZLNO38uwa+XVn9MwUYm +DEOxDBDQ6/f10yF7vuIREwCub9KnK24bJnnu2jTt4nvdrgV1TPQAFMsBj32f810qNUx7D /xgFizISqRzULLAEVJW1HCVelgUf8hM1F7qE0KBWOM7qiJ4itkxAytswUgx0qJFSzJMkQL b9/1OHvE3tLH+2O40Rungo31v+kvWNPM0fhkVs58ebvpF2JXecd+u+YW6+slFA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gJWc12PkVzvsm for ; Sun, 17 May 2026 19:44:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 366ed by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 17 May 2026 19:44:49 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 7bdf2b5d5fba - main - nullfs: do not allow to mount a vnode over itself List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 7bdf2b5d5fbabfc8749c4ff6e618c3e843b14de0 Auto-Submitted: auto-generated Date: Sun, 17 May 2026 19:44:49 +0000 Message-Id: <6a0a1ab1.366ed.93367f9@gitrepo.freebsd.org> The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=7bdf2b5d5fbabfc8749c4ff6e618c3e843b14de0 commit 7bdf2b5d5fbabfc8749c4ff6e618c3e843b14de0 Author: Konstantin Belousov AuthorDate: 2026-05-16 22:16:45 +0000 Commit: Konstantin Belousov CommitDate: 2026-05-17 19:44:06 +0000 nullfs: do not allow to mount a vnode over itself This causes recursion in VFS that is not worth handling. PR: 275570 Reported by: Alex S Reviewed by: markj Tested by: pho Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D57043 --- sys/fs/nullfs/null_vfsops.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/sys/fs/nullfs/null_vfsops.c b/sys/fs/nullfs/null_vfsops.c index c3eec727aeea..0ec4f9c87297 100644 --- a/sys/fs/nullfs/null_vfsops.c +++ b/sys/fs/nullfs/null_vfsops.c @@ -151,6 +151,14 @@ nullfs_mount(struct mount *mp) */ lowerrootvp = ndp->ni_vp; + /* + * Do not allow to mount a vnode over itself. + */ + if (mp->mnt_vnodecovered == lowerrootvp) { + vput(lowerrootvp); + return (EDEADLK); + } + /* * Check multi null mount to avoid `lock against myself' panic. */