From nobody Fri Mar 20 22:49:50 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fcySH0QT3z6WBpp for ; Fri, 20 Mar 2026 22:49:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fcySG6gvZz46JW for ; Fri, 20 Mar 2026 22:49:50 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774046991; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IdOtuz1sbJIV7sZqzq2VbyuhWXmQWBrBuLI13R3esLs=; b=nJpMGbUjyk+eiwSBsL78cFB04TzM297R2Gb/cdjCMHLdhsZ4PGl7G2gEpZZWPOQ4CQ+uuE I48DydRYF23AvPI9Vy6moLus1ZdeUbTxQeZUqHjNNFhpRnbft5MDiF34iPnQ5cJnQPlC6U mExJaVWyzYFAAzAj/Xpud1kM8sCjcfQ3e4epfWMS/As4eLssuBjBXeZmDWqKJNhB+0ZIFD nKKoxE9XILoNxDOqhmYOcRekCcNbCPoL2CVQgpiQuJKqy4zp8/o8CJ1LhcSjGdYjYVLSHT ykCRODcRRxzME8hC1sjh5iB4LKyEgFbU0q/wEhU6kF07HPTfKm4ac4c1F3nU4w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1774046991; a=rsa-sha256; cv=none; b=PCE32jRljje6OusN9Q/9jTSvqlav3vrUMRPj0fb1PnUmlqMZHNEGLrk+1PaVSJIuYPAUJH kEZOSFNX2GSUWYCSXJs5K38PBPsN9GLZ8dlId/cNnoq2tOD8Aa4wUai4Ppd/jm9YWK0rpU xYtHX80ZF+31kC56uQaEnFcP6bMldKGOC6K1jvD9GdipmEhBlk/itNNDIfa7RgVxzTwOwJ kbwl5EJhzFj2sgNWzuZy5/vbDaPnaKTmASa5tfAgzSnqOxGgrmbBy48K/OPolLlqtB+x5K rO1R/deMM7TI6frK8z3ANiFvJtjMoXETbA0h+lWNUGc1KL8Pmf4Hb0bb96N3lg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774046991; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IdOtuz1sbJIV7sZqzq2VbyuhWXmQWBrBuLI13R3esLs=; b=qFngaEP5/oPI3DgUuT7748+4nhUMcCPPeV6NBdjRyd/JriHUq5b3Kb+mm8BFi8iLv0l8cM GDWxiiSiVt27Ssm/lU6bnsZkXD31zr9oqriI+S5H3jzAUdUQLWwcPHB1DE6j4a426qdAts MVNZPKzDKbj/I3sJ/COeXz9aQumiQFT0jYuXU9F86qtmmM+nKgGIv6hNiSZV2j4gIOiqmu uoymgPT0yHfvzMKay35LdiEeb1prjsmgcliQ0SU1kJfeFMzzHAfTPt4sUJwfy0Y6U/t39e Dcq/V1ggwy/1W/bVrtGjfbudTTVrAybh/S/uEQv9zEx40gYQ2NNtrveoRZ8Oxw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fcySG61PCzld6 for ; Fri, 20 Mar 2026 22:49:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 27225 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 20 Mar 2026 22:49:50 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: e18449fbe273 - main - amd64: move code to check for traps with interrupts disabled into helpers List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e18449fbe2731399862e82e61fffaadd6739642c Auto-Submitted: auto-generated Date: Fri, 20 Mar 2026 22:49:50 +0000 Message-Id: <69bdcf0e.27225.4f43bd27@gitrepo.freebsd.org> The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=e18449fbe2731399862e82e61fffaadd6739642c commit e18449fbe2731399862e82e61fffaadd6739642c Author: Konstantin Belousov AuthorDate: 2026-03-11 12:04:55 +0000 Commit: Konstantin Belousov CommitDate: 2026-03-20 21:05:15 +0000 amd64: move code to check for traps with interrupts disabled into helpers Reviewed by: jhb, markj Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D55809 --- sys/amd64/amd64/trap.c | 96 ++++++++++++++++++++++++++++++-------------------- 1 file changed, 58 insertions(+), 38 deletions(-) diff --git a/sys/amd64/amd64/trap.c b/sys/amd64/amd64/trap.c index 3a9323936d2d..e4e4e98fbf7d 100644 --- a/sys/amd64/amd64/trap.c +++ b/sys/amd64/amd64/trap.c @@ -260,6 +260,62 @@ trap_clear_step(struct thread *td, struct trapframe *frame) PROC_UNLOCK(td->td_proc); } +/* + * Warn with a message on the user's tty if application code has + * disabled interrupts and then trapped. + */ +static void +trap_check_intr_user(struct thread *td, struct trapframe *frame) +{ + MPASS(TRAPF_USERMODE(frame)); + + if (__predict_true((frame->tf_rflags & PSL_I) != 0)) + return; + + uprintf("pid %ld (%s): trap %d (%s) with interrupts disabled\n", + (long)td->td_proc->p_pid, td->td_name, frame->tf_trapno, + trap_msg[frame->tf_trapno]); +} + +/* + * Some exceptions can occur on kernel attempt to reload a corrupted + * user context, which is done with interrupts enabled. Interrupts + * such as NMIs and debugging faults can be also taken in the kernel + * while interrupts are disabled. Other traps shouldn't occur with + * interrupts disabled unless the kernel has a bug. Re-enable + * interrupts in case this occurs, unless the interrupted thread holds + * a spin lock. + */ +static void +trap_check_intr_kernel(struct thread *td, struct trapframe *frame) +{ + MPASS(!TRAPF_USERMODE(frame)); + + if (__predict_true((frame->tf_rflags & PSL_I) != 0)) + return; + + switch (frame->tf_trapno) { + case T_NMI: + case T_BPTFLT: + case T_TRCTRAP: + case T_PROTFLT: + case T_SEGNPFLT: + case T_STKFLT: + break; + default: + printf("kernel trap %d with interrupts disabled\n", + frame->tf_trapno); + + /* + * We shouldn't enable interrupts while holding a + * spin lock. + */ + if (td->td_md.md_spinlock_count == 0) + enable_intr(); + break; + } +} + /* * Table of handlers for various segment load faults. */ @@ -337,46 +393,9 @@ trap(struct trapframe *frame) return; } - if ((frame->tf_rflags & PSL_I) == 0) { - /* - * Buggy application or kernel code has disabled - * interrupts and then trapped. Enabling interrupts - * now is wrong, but it is better than running with - * interrupts disabled until they are accidentally - * enabled later. - */ - if (TRAPF_USERMODE(frame)) { - uprintf( - "pid %ld (%s): trap %d (%s) " - "with interrupts disabled\n", - (long)curproc->p_pid, curthread->td_name, type, - trap_msg[type]); - } else { - switch (type) { - case T_NMI: - case T_BPTFLT: - case T_TRCTRAP: - case T_PROTFLT: - case T_SEGNPFLT: - case T_STKFLT: - break; - default: - printf( - "kernel trap %d with interrupts disabled\n", - type); - - /* - * We shouldn't enable interrupts while holding a - * spin lock. - */ - if (td->td_md.md_spinlock_count == 0) - enable_intr(); - } - } - } - if (TRAPF_USERMODE(frame)) { /* user trap */ + trap_check_intr_user(td, frame); td->td_pticks = 0; td->td_frame = frame; @@ -497,6 +516,7 @@ trap(struct trapframe *frame) } } else { /* kernel trap */ + trap_check_intr_kernel(td, frame); KASSERT(cold || td->td_ucred != NULL, ("kernel trap doesn't have ucred"));