From nobody Thu Mar 19 00:47:26 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fbn8v1Sphz6VNDV for ; Thu, 19 Mar 2026 00:47:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fbn8v0njYz3tNH for ; Thu, 19 Mar 2026 00:47:27 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1773881247; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pQRK3nVAJWV8+8JRNRVm2OSGAJIFfP3pOm594zaqzD0=; b=K/BYtpa/eJ35BUXf17TuJ2J9qJr+hkEIg0sxdnaOUzxuFfHct9yiNR+y7LpKp7mmJuDbVp X94HvaSYkOJf6ccETIhCO4wRKwIk3QKt7QmEyWTEwalN2Z355WnducIt1UENDo1aZkmLkb WwhzzSb1ow81VE7vlwIImCK66is1idfp0BUWLN4UE/8f53wq4jm8qekT3C6uNMJAe3SLpy jD3S9GxW9Fecm6g8Gf1iscdmPPpLAr+t5kYJYgl7luVALbpqYKOJnoCeYqZYrKjSbLdUVI dcwKQEpFeg7CB4UhcX9izivVLjxtRr6ZJD2PMBTgX2g7AyAvvGOkercAbMXYkw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1773881247; a=rsa-sha256; cv=none; b=qSUDDNajbZ6hZEiBXOA9a4U4qz+0/skiUyJfiXtHELaotAI1xk9Ccw5OWUn2WMtxDwcI+M ZccXZZLhy7ht27GULkRYMN9qAm7aU1bRjo3JfnF8ta0lem0KzdUXAjKV12deHkWF8RRjOr 809itoRtZSJLNk+i64U9U5m3l11v0oF884KuTdtrAZTuwPwQhrUDRetJDe261IjVxMCqeX yGdoi4Ma8Ac7oCY3hIImo7vp4mck+HcWco6J7qrSe9jjgf6bQQN7LTqNHVkIir97nyx4aC EBbimBgaiO5JBn8WPQObDltSOHSWCsYQd0Juvuoyix64vpmpN3tOHcgGEyQ4Hg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1773881247; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pQRK3nVAJWV8+8JRNRVm2OSGAJIFfP3pOm594zaqzD0=; b=cj4sNjjr0gZSIPao+xpK4eSq2+ttBlDiJRk3OlOgI55T1RCLNSA8srgPrv0fpa33cD/Gb8 xl57hw5cGZ4O8vdXprKiXw9ndiUXTjLv4QVr0jqX6Gb/wKGdRVSqnrGIgnN5li8lJ7t8Gv TFdE4+y92tdIRueB0prf/vf9jRjQrpZ56DL8/+gBwrBBJIr9WJvOyy1cgDaKwEiYkKN/x/ +4lU43SD1lN5RVEltzzWsIjTT96aEhpLOftgwZf7F6OGgros16kJmee0hr3s+SD9ZEodpc 8L7MEVZ1me1NOP44IFjuWjVK8+2PdCW1fxgwVdErIIWelVfFd4aAnQvQGYstoA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fbn8v05MzzYh7 for ; Thu, 19 Mar 2026 00:47:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3bd1f by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 19 Mar 2026 00:47:26 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kirk McKusick Subject: git: 51446d33c6fb - main - Delete error-check code that can never happen. List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mckusick X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 51446d33c6fbc27ce21f54ebb4c27caace48c3be Auto-Submitted: auto-generated Date: Thu, 19 Mar 2026 00:47:26 +0000 Message-Id: <69bb479e.3bd1f.710a9fc1@gitrepo.freebsd.org> The branch main has been updated by mckusick: URL: https://cgit.FreeBSD.org/src/commit/?id=51446d33c6fbc27ce21f54ebb4c27caace48c3be commit 51446d33c6fbc27ce21f54ebb4c27caace48c3be Author: Kirk McKusick AuthorDate: 2026-03-19 00:45:23 +0000 Commit: Kirk McKusick CommitDate: 2026-03-19 00:45:23 +0000 Delete error-check code that can never happen. Near the top of kern_mmap() that implements the mmap(2) system call, it sets prot = PROT_EXTRACT(prot); with So prot can only be the three PROT_ flags. The following test of the user's mmap(2) parameters (near line 275 in vm/vm_mmap.c): if (prot != PROT_NONE && (prot & ~(PROT_READ | PROT_WRITE | PROT_EXEC)) != 0) { return (EXTERROR(EINVAL, "invalid prot %#jx", prot)); } can never fail. This commit deletes it. No functional change intended. Reviewed by: kib MFC-after: 1 week Sponsored by: Netflix --- sys/vm/vm_mmap.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/sys/vm/vm_mmap.c b/sys/vm/vm_mmap.c index 234586893b59..cb5906440f56 100644 --- a/sys/vm/vm_mmap.c +++ b/sys/vm/vm_mmap.c @@ -271,10 +271,6 @@ kern_mmap(struct thread *td, const struct mmap_req *mrp) return (EXTERROR(EINVAL, "both SHARED and PRIVATE set (flags %#jx)", flags)); } - if (prot != PROT_NONE && - (prot & ~(PROT_READ | PROT_WRITE | PROT_EXEC)) != 0) { - return (EXTERROR(EINVAL, "invalid prot %#jx", prot)); - } if ((flags & MAP_GUARD) != 0 && (prot != PROT_NONE || fd != -1 || pos != 0 || (flags & ~(MAP_FIXED | MAP_GUARD | MAP_EXCL | MAP_32BIT | MAP_ALIGNMENT_MASK)) != 0)) {