From nobody Mon Mar 16 20:37:03 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fZRhw0dC4z6VxHL for ; Mon, 16 Mar 2026 20:37:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fZRhw0169z47r3 for ; Mon, 16 Mar 2026 20:37:04 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1773693424; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=VjOt/nXccD/BktFtl5U/R0FMCYOS32IAntxBoa7cAzo=; b=JKVNH4HcFTh0NdhdiEGnp+zZNT2A0oZAYsSN6BVXk2ulfKX/ruN+KzIERSP9Ojksm189tQ m00XxZs6ZNg88orKMFCB3m6bf08935I8yJGnl6dnSIfi0ZXEUGSDFZEaxdpipcDm6Z9Rjj GtpjLkpNDTftmQjxmMXWN6sLkzcsXDyc665EhP6n04eQauD/cAK/29GyaRCp3YiqEanV9s PzcZ9fd+rUSQ5lqK90qw6K/aMfa4Toic+2N3ddTejuuzyJ+J0OYRUPiOpsFVmz/glOM0Nl 4LUX6OSt+6s70yHfDdOTO/snWmH8E6W6zCT+nsMVJ6wAIaY4SvCnOz+VcV386w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1773693424; a=rsa-sha256; cv=none; b=eUVoD6GDYIrZtBT/78OHTRTaLWBi5uf31dtGT5HaZiYh1aPxROyBFVndTOA990tKDY2LSr hQGOD2RKmsEdFtq0IjRKxBoKlL+a9ike8u++EyOZT48EqcPhdEXEOmdYx5a18r0WlEMqTY iwrOaW93m5lieJvi40n3v/OfVKT5/8onq0HwXgE6D2Bw6L/qWgZ/+7pxPlxB8t5WtIYsdm wJlmq7A3E8pzT41cT13hLhA9Dk12FaobZWN7C9aX6rI+Na5NAv/fTqbOMpZiUHuSVgFog2 RdC6AZvRlzpJgSbqhU81AZLOZmH7zyphnZUOKybZ+lKRcRptd3Y0QMw+XRS2YQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1773693424; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=VjOt/nXccD/BktFtl5U/R0FMCYOS32IAntxBoa7cAzo=; b=j499LLD5CLnV8UjD5YrfCVKTHQ5H/HOWRN/+loPnHgNr3OOq11/DDkJ7VFXmVMbHvu0lPV ukmY64eandUZG2tPtb6f4YhyA9Xx3MbFCxtAHbBG7KjDuDs5m3EuHRpOVdqDJDizPbmr1S iB1BMHCyJFMZT+y5MzjgTJ/5rGXhP1Abf6+lNbPhaejc7SSfDDe0I7ZjuwuQW/QEmdY5Gu AkL+2XSvCcceTjfpM+9/nD66rmixbQYR+IBLFtDIwDZoVapOiZMi2+Gqm3AXYrf3HOVzAZ fjD2k6Ry1lI/gvOmJyGLK1PTStVh/9r5zuH/dNtjAuh/S/q/s/wM4XTotVRL4w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fZRhv6R3JzrgQ for ; Mon, 16 Mar 2026 20:37:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3fa86 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 16 Mar 2026 20:37:03 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: aa15df459705 - main - queue.h: Reorder STAILQ_INSERT_TAIL List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: aa15df4597053c0e95a15b2a7036296999cd562a Auto-Submitted: auto-generated Date: Mon, 16 Mar 2026 20:37:03 +0000 Message-Id: <69b869ef.3fa86.bffed26@gitrepo.freebsd.org> The branch main has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=aa15df4597053c0e95a15b2a7036296999cd562a commit aa15df4597053c0e95a15b2a7036296999cd562a Author: Dag-Erling Smørgrav AuthorDate: 2026-03-16 20:36:56 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2026-03-16 20:36:56 +0000 queue.h: Reorder STAILQ_INSERT_TAIL The current implementation briefly violates the tail invariant. This is not usually an issue, but if an insert is in flight when a panic occurs, we may then trip the invariant while dumping core. MFC after: 1 week Sponsored by: Klara, Inc. Sponsored by: NetApp, Inc. Reviewed by: obiwac, olce, jhb Differential Revision: https://reviews.freebsd.org/D55819 --- sys/sys/queue.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/sys/queue.h b/sys/sys/queue.h index aa6453889e6b..e2603bc664c3 100644 --- a/sys/sys/queue.h +++ b/sys/sys/queue.h @@ -499,9 +499,10 @@ struct { \ #define STAILQ_INSERT_TAIL(head, elm, field) do { \ QMD_STAILQ_CHECK_TAIL(head); \ + __typeof__((head)->stqh_last) prevlast = (head)->stqh_last; \ STAILQ_NEXT((elm), field) = NULL; \ - *(head)->stqh_last = (elm); \ (head)->stqh_last = &STAILQ_NEXT((elm), field); \ + *prevlast = (elm); \ } while (0) #define STAILQ_LAST(head, type, field) \