Re: git: 858f53dd43ec - main - Makefile.inc1: Don't force LLVM_BINUTILS off for cross-tools

On 8 Mar 2026, at 21:56, Ahmad Khalifa <ahmadkhalifa570@gmail.com> wrote:
> On Wed Mar 4, 2026 at 9:12 PM +0200, Ed Maste wrote:
>> The branch main has been updated by emaste:
>> 
>> URL: https://cgit.FreeBSD.org/src/commit/?id=858f53dd43ecb84cf2597229e9dbda2f242d9dd6
>> 
>> commit 858f53dd43ecb84cf2597229e9dbda2f242d9dd6
>> Author:     Ed Maste <emaste@FreeBSD.org>
>> AuthorDate: 2026-03-04 15:06:26 +0000
>> Commit:     Ed Maste <emaste@FreeBSD.org>
>> CommitDate: 2026-03-04 19:10:48 +0000
>> 
>>    Makefile.inc1: Don't force LLVM_BINUTILS off for cross-tools
>> 
>>    Because of this setting we were still using ELF Tool Chain tools for
>>    buildworld.  The sets of binary utilities are largely equivalent and
>>    this went unnoticed after commit 1cae7121c667 ("Enable LLVM_BINUTILS
>>    by default").
>> 
>>    This was discovered recently because ELF Tool Chain objcopy produces
>>    standalone debug files without phdrs and this caused an issue with a
>>    3rd party ELF parser [1].  Remove the forced setting so that we use
>>    LLVM's binutils to build the system.
> 
> llvm-objcopy doesn't get built during cross-tools, which results in
> cross builds not having objcopy. Not sure if just specifying
> llvm-objcopy under cross-tools would fix it, haven't had the time to
> check.
> 
> See https://github.com/freebsd/freebsd-src/actions/runs/22685122750
> 
> Thanks.

Ed,
GitHub CI has been broken for over a week now and I’ve just hit this
locally. Can we please revert this commit unless you have a fix
imminent?

Jessica