Re: git: 2a514d377b37 - main - bhyve/virtio-scsi: Preallocate all I/O requests

From: John Baldwin <jhb_at_FreeBSD.org>
Date: Wed, 11 Mar 2026 12:58:41 UTC
On 3/11/26 08:28, Dag-Erling Smørgrav wrote:
> Dag-Erling Smørgrav <des@FreeBSD.org> writes:
>> Ed Maste <emaste@FreeBSD.org> writes:
>>> +	assert(iov_to_buf(req->vsr_iov_in, req->vsr_niov_in,
>>> +	    (void **)&req->vsr_cmd_rd) == VTSCSI_IN_HEADER_LEN(q->vsq_sc));
>> This assertion breaks the gcc build.
> 
> It's been a week since this was committed.  It still hasn't been fixed
> and is causing Jenkins to nag everyone who commits anything to main.
> Please attend to it.
> 
> As a reminder, you can install an alternate toolchain (e.g. amd64-gcc15)
> from ports or packages and run either
> 
>      make buildworld WITHOUT_TOOLCHAIN=1 CROSS_TOOLCHAIN=amd64-gcc15
> 
> to build world with that toolchain, or
> 
>      make buildenv CROSS_TOOLCHAIN=amd64-gcc15
> 
> to get a shell in which `make` will use that toolchain instead of the
> default.  Simply running `make CROSS_TOOLCHAIN=amd64-gcc15` in
> `usr.sbin/bhyve` will not work; you need the full environment.

There are fixes in active review (I commented on the reviews yesterday).

-- 
John Baldwin