From nobody Tue Mar 10 19:09:07 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fVk2C5Zcdz6TsyL for ; Tue, 10 Mar 2026 19:09:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fVk2C4gzYz44xt for ; Tue, 10 Mar 2026 19:09:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1773169747; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8N6GlJ17vxTuyVK/YhdycgfvqVBwNHdwlx+ozpUPkYY=; b=WkR5vDv+vRsHmKlJrAoUn0Qjd2mPTCt5kIF2zKWYhNAttDNdd5JbCV0DnvjiqJlCqTy2R1 fVcbK91YJUp7lin/7NWhGmoeQHKCStWI1/Tb3fXg/UF1oTcLQuYpBnnfhsPXrX9GMcA+xC LFRQ0J0yqHIgtTkeRuICT6pU//sKulh3o/06B/h1nIg0e7yHLaZxblk0gSclQVZJCLQhDO LVv1N70V75UQGQwZOIWEfQ9z1toatF/oIh44l5yUMc9zO4nhwSCCn0ZTtVV+V+bDF052Zc G7w42g7r4gklMhpaj8onLc8+En9wWD5wstqomjDa/UIac94g7reyWrH7SpYEQg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1773169747; a=rsa-sha256; cv=none; b=S/QHWlwAKE1zEhV4HI6WEb92CWrvnjx4zYvCjlH1a5sxTuLDxQF/vXL01GBm9t5TtEsPFv cxVxnin+Xkw0JLRgigx12gIzAiUNs4iFMPcCIRzPy6hA5W5kVY2RHW6ETS/w5pXkRt7Nhx xvsNRnh6wV7sjKNaJ9tNErSMTrMoDvT158ypkCUF9hMzSIoJdP+ImOXjQ5PcRdUZ5TfS9N s8QBx9pJzlQv88h7/6GJmlY1fmjhXVnzt+a58w4nN+ZMsU0cOC9cFf9NwbOeHLnDJJz73N xIYHwqoZegRVAyFAQVAPWHfHEsGHYhidrAc59Il3BnarlDV7xgv4q/TUbD/XmA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1773169747; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8N6GlJ17vxTuyVK/YhdycgfvqVBwNHdwlx+ozpUPkYY=; b=fCfe4bweBHbPVlEUtAa01IkxES/FIaemO5o7xu2AJndW5M852cL94+mfhTQP9tR9v9CoSS 8RtvBsTNypITuk66CSLdJCnWGRmYnizm2K+daUNW8+tP85zrJ6YH2C2LDZI7EZv9xi524j TsjuouqaoN+ahE1uXKEPr1kt9Ouy2hMA8Jz/uB0CSdhy2Ge2VmjVEa98+DOHfYm1RJsb4m kG0ADPACjplAbBzQeY/cxRdoxeWa+RRv3rUR72WXGE0LsU56hQLp+UNP0xe27BJRfwpdOz z+SShzv/MJRmXM642N5IvQNbUq54dFXxiaZiNZR4oKo/i2MtTF7iuu5M/kmbOQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fVk2C43ylz8jl for ; Tue, 10 Mar 2026 19:09:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 236b3 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 10 Mar 2026 19:09:07 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andrew Turner Subject: git: d99e725c26a7 - main - virtio: Restore mb() calls List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: andrew X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d99e725c26a7745aa349eab01ae56ca630b6d0f5 Auto-Submitted: auto-generated Date: Tue, 10 Mar 2026 19:09:07 +0000 Message-Id: <69b06c53.236b3.73c1f491@gitrepo.freebsd.org> The branch main has been updated by andrew: URL: https://cgit.FreeBSD.org/src/commit/?id=d99e725c26a7745aa349eab01ae56ca630b6d0f5 commit d99e725c26a7745aa349eab01ae56ca630b6d0f5 Author: Andrew Turner AuthorDate: 2026-03-10 19:08:38 +0000 Commit: Andrew Turner CommitDate: 2026-03-10 19:08:38 +0000 virtio: Restore mb() calls Until an issue seen on amd64 can be investigated restore two mb() calls to virtio. Reviewed by: andrew Fixes: c499ad6f997c ("virtio: Use bus_dma for ring and indirect buffer allocations") Sponsored by: Arm Ltd Differential Revision: https://reviews.freebsd.org/D55766 --- sys/dev/virtio/virtqueue.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/sys/dev/virtio/virtqueue.c b/sys/dev/virtio/virtqueue.c index dbd55e02e091..b7fdb4703ccb 100644 --- a/sys/dev/virtio/virtqueue.c +++ b/sys/dev/virtio/virtqueue.c @@ -565,6 +565,9 @@ virtqueue_notify(struct virtqueue *vq) /* Ensure updated avail->idx is visible to host. */ bus_dmamap_sync(vq->vq_ring_dmat, vq->vq_ring_mapp, BUS_DMASYNC_PREWRITE); +#if defined(__i386__) || defined(__amd64__) + mb(); +#endif if (vq_ring_must_notify_host(vq)) vq_ring_notify_host(vq); @@ -960,6 +963,9 @@ vq_ring_enable_interrupt(struct virtqueue *vq, uint16_t ndesc) bus_dmamap_sync(vq->vq_ring_dmat, vq->vq_ring_mapp, BUS_DMASYNC_PREWRITE); +#if defined(__i386__) || defined(__amd64__) + mb(); +#endif /* * Enough items may have already been consumed to meet our threshold