From nobody Sat Jun 27 15:23:59 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gnbtP6DZbz6jk9R for ; Sat, 27 Jun 2026 15:24:13 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gnbtN6yRxz3hXr for ; Sat, 27 Jun 2026 15:24:12 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-516d0db9372so15569571cf.2 for ; Sat, 27 Jun 2026 08:24:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1782573852; cv=none; d=google.com; s=arc-20260327; b=UcgAlXHjMNt9cjHENnlzL8NW2oJOQ69Vk6dnGuYSN1dTOfdvwllGW3mKITfbEXezad svvpTSU9BgPF4XQj8TwpGwrLnYA+V+LpC916Aq3g71LEqCKqBhlV5+cQVGg9VWyWpRhY 1rDy+0Begfq78ZbcHet6gpiRK09WUOnUOsd1gWWc8AjiTNT+7BbupwmlRAgmnY9+AmOB Af5eVzKLq7ujMAeFigF8jE8F6mf2C1bVlXZxDOr0ZjZ4IpmZKRclwWlRbfJwGm8V5orv iU7dzEohbS73ie3Cwh9sGCoq8uKuuDoSKFLBtZnWCdVJeuH9kBCmOfut2/u9qiQl5Pif LlOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version; bh=Ljmoe215kv2H8IWomey8c5VcQmBYAwot5baUsmLgsjk=; fh=tGGBgCx05/JaAOyY19DVgPOLfgeQ3LCB9E16vQLiNDM=; b=btKFnD/WDSqLt+7h1rvl96GzqzIo25X2aeLgfhORwcYxNfBgMdK8fxji9iw/Uh+clk FgoaLlOIifitzyzuKc0B8tNkIus5kxR/70KGYtfm0uDYbBB8hLXLEpT65u8RpEya5yH7 nyJ1sNXEGEeZIikoiu5d4qA35N4/q5ztzedSTwj4F8YIuZghRCJ6ZEI0C9qCd3SWlI7m ByOF2Ts4F/KPrq5maNI6QV4EZMzjbC3Pt4rxxb3p9tlfzRXZaeSP1dXcSz8YIdmzW6kV v1aDpND3sQqq/I2gaXigcC/8oJjqlejI5kfAEHOqFAYKhZTDyxaZXTG/0gv32HMpuMdk Do5g==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782573852; x=1783178652; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ljmoe215kv2H8IWomey8c5VcQmBYAwot5baUsmLgsjk=; b=jcixb2mBoaQktDU0t8ScCv8QtGMtMXul6vdzN6ROesjdTz+iY0i8pamBVmsbiVGj2f 4B72mY92wD2ZWyc/VwP63ZiD1KieZKjlPhkmF9zRr9kbQiNO9bRMx02VpVpvJry+xCVB zkBiuTYnICR5hkuy9p/9VN3WDKcDcu9lBxpDu1hqIM9FWVxkciIs55pYaWcpVC/XeP8k jTB39uvziEXpgxz908zIkIjtY4YwaUYQZNXXNgCdlwPX/WamRkgXyWSRlJ2F19OTR5zK TVECNo56PnRUPavkl5m4uEvHGYP2tsRr7r/tyAtibtdp6kX/m3U+hOyJ7GtnPE+acj+c Ymog== X-Forwarded-Encrypted: i=1; AFNElJ9dp5/H6Aq+Pobx703lYIFYozuRaZEbkkQ20rSegRWReJhT86WmvHrgIIArvUPEMXrb9hWIJmTcq/c8UWqZnjFtHe99Og==@freebsd.org X-Gm-Message-State: AOJu0YzK0g7MZr8BlT8JWS6Wl6FMozeVuGJq0hdgzvnXjblqlhA7PdRQ FUaINZdrtkOPZS1DRd813ZiRzXfyMyqJ7e9p1JNsEdZjTK8WY6cU6X26nq5CtZprU1Y6rYbnZf/ fTEnoFmBdIHGxiCaUP/h2mJ+AbQOIKOc= X-Gm-Gg: AfdE7clk5rvMoT4sPVUajU7XvzlNKIP97HZCgZukp/+sXg1D7QnEH9jVgWTHexUAW6o HAbuIdct7eyI5X2fgcYca+gxjY6gQenG5/LJWCrr6kfULy0IR3d9pVXJvsEQfTYbXi5ArkMSU+0 Mry3f8JKOVVhOjprHnKqK11u6KU2hCOvGRpOskTIv2T4+B1jcz9gznODq+ADu9BSQdh6O58D3Du DXiMXrUpV0HTTNFwYdjyfOaBU3uSwBmwPUkhShrVTeCf2VTvwdfhEhSQ58beiGgGfWWYUs1VlUW vDr1+HeNcs5J1U5c4cyfoDHB8x4bN+ubPuOpRF2O5km71ihqz3a2Tu9Eh2QRpUoR2zoahNDNiVm qsoyl7v6QGywm55AcMD5iqmmCwV2Ubvuk0H7VUQOtZKf5V7U= X-Received: by 2002:a05:622a:2617:b0:517:7d69:805b with SMTP id d75a77b69052e-51a7283d38fmr170218951cf.27.1782573852005; Sat, 27 Jun 2026 08:24:12 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 References: <6a1e7b3b.1a45a.91f6820@gitrepo.freebsd.org> <21a39777-c38e-4805-abdc-b1c19183bce1@omnilan.de> In-Reply-To: <21a39777-c38e-4805-abdc-b1c19183bce1@omnilan.de> From: Adrian Chadd Date: Sat, 27 Jun 2026 08:23:59 -0700 X-Gm-Features: AVVi8CfRHmxkhWVj_q4eV-76mn15XTQVWNwgshU0dMsoLxJB6Y6m23xxD2GNBmA Message-ID: Subject: Re: hwpstate_intel i386 build workaround [Was: Re: git: 7b26353a59d6 - main - hwpstate_intel: Disable package control on hybrid CPU] To: Harry Schmalzbauer Cc: ShengYi Hung , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4gnbtN6yRxz3hXr X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated please create a review for this? It sounds like they should've wrapped it if #ifdef amd64 or something -a On Sat, 27 Jun 2026 at 07:19, Harry Schmalzbauer wrote: > > On 2026-06-02 08:42, ShengYi Hung wrote: > > The branch main has been updated by aokblast: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=7b26353a59d66dc1bc611fd042a49b9e3bd13699 > > > > commit 7b26353a59d66dc1bc611fd042a49b9e3bd13699 > > Author: ShengYi Hung > > AuthorDate: 2026-06-01 09:46:37 +0000 > > Commit: ShengYi Hung > > CommitDate: 2026-06-02 06:41:41 +0000 > > > > hwpstate_intel: Disable package control on hybrid CPU > > > > In package control mode, the performance of all cores depends on the > > most recent value written to the request field. If the last write comes > > from an E-core, all cores are forced to align with the E-core > > performance level, resulting in significant performance degradation. > > Therefore, package control is disabled on hybrid-core systems. > > > > Reviewed by: olce > > MFC after: 2 weeks > > Sponsored by: The FreeBSD Foundation > > Sponsored by: Framework Computer Inc > > Differential Revision: https://reviews.freebsd.org/D57377 > > --- > > sys/x86/cpufreq/hwpstate_intel.c | 21 +++++++++++++++++++++ > > > In lieu of a proper fix, due to lacking skills, I'm working around i386 > incompatibility with this diff: > > diff --git a/sys/x86/cpufreq/hwpstate_intel.c > b/sys/x86/cpufreq/hwpstate_intel.c > index db8600d7b89a..b9b68f1b14d0 100644 > --- a/sys/x86/cpufreq/hwpstate_intel.c > +++ b/sys/x86/cpufreq/hwpstate_intel.c > @@ -321,6 +321,7 @@ sysctl_epp_select(SYSCTL_HANDLER_ARGS) > return (ret); > } > > +#ifndef __i386__ > static void > intel_hwpstate_hybrid_cb(void *ctx) > { > @@ -328,11 +329,14 @@ intel_hwpstate_hybrid_cb(void *ctx) > > atomic_add_32(small_cores, PCPU_GET(small_core)); > } > +#endif > > void > intel_hwpstate_identify(driver_t *driver, device_t parent) > { > +#ifndef __i386__ > uint32_t small_cores = 0; > +#endif > > if (device_find_child(parent, "hwpstate_intel", > DEVICE_UNIT_ANY) != NULL) > return; > @@ -353,6 +357,7 @@ intel_hwpstate_identify(driver_t *driver, device_t > parent) > if ((cpu_power_eax & CPUTPM1_HWP) == 0) > return; > > +#ifndef __i386__ > /* > * On hybrid-core systems, package-level control cannot be used. > * It may cause all cores to run at the E-core frequency because > @@ -363,6 +368,7 @@ intel_hwpstate_identify(driver_t *driver, device_t > parent) > intel_hwpstate_hybrid_cb, smp_no_rendezvous_barrier, > &small_cores); > if (small_cores > 0 && small_cores < mp_ncores) > hwpstate_pkg_ctrl_enable = false; > +#endif > > if (BUS_ADD_CHILD(parent, 10, "hwpstate_intel", > device_get_unit(parent)) > == NULL) > > I know i386 is not supported anymore. > Just in case anybody else wants to keep i368-stable/15 for bhyve guests > for example, where cpufreq(4) isn't attaching anyways. > > Thanks, > > -harry > >