From nobody Sun Jun 21 18:11:19 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gjzt82hKDz6hTCx for ; Sun, 21 Jun 2026 18:11:28 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic303-25.consmr.mail.gq1.yahoo.com (sonic303-25.consmr.mail.gq1.yahoo.com [98.137.64.206]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4gjzt65DP7z3Srm for ; Sun, 21 Jun 2026 18:11:26 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yahoo.com header.s=s2048 header.b=AHCBDoSk; dmarc=pass (policy=reject) header.from=yahoo.com; spf=pass (mx1.freebsd.org: domain of marklmi@yahoo.com designates 98.137.64.206 as permitted sender) smtp.mailfrom=marklmi@yahoo.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1782065482; bh=KLe18R9m4n79obhhqkUW2w+9bpBFwOjmXL0Aj0GpeAI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=AHCBDoSkcEcMx4kPm/QsO78J7f4AaGI1QccZxM2fja/oDhe8512aODvfFSahemdMi/twnzKGbFTG3BZ64TzPvgD4SQRF/zcJ9iqDwgpSTf/fqGYzmCrF6KzvlJtZ1K1vD3AzFDUKDfXQ1dJfxZ0qtyt+lJ4pbQmpGpCvO6j9YkCtgeOqM2g9qf0g8XYYrd/+V8nDR9vF9oRMoswK90mkd4WmJuh3oCsFWhj0PS25mu8emaAUzrAF+Go1lyqiOo9cE3tmwOZExQqryfviHZuH+7d4XbDyh6hZdDdBW/e7pz8n8FbeJ9/bDLOvViyQmO5ScUJTIL6AqBx+2bq3RgrsnA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1782065482; bh=n8zYXocbU9fqUm5tdPmgHJO8lqVmE4Ctj/cEEN2EWDc=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=NMOiFBHKRRt77+072oHb4OzrL8k8BaPW+Qts79RghVg2jb0hJMQaOe9b2mlQpWBKo/kOrF6L7pnz1TPccBZRfJlPHKACzI0vS1unO6OPPPP6wr0LevrUMjW4HLVcY8QWcZur6WcuqYw3LYYfaMI+BkG7msKitgzzxvgeIU0J2N9wYXDW/NHiRd31E9a2hyCweQdcQ/UzI8Cyn4q2Jotir1FPRHMwQuoIj87VkIr9aw96pPn7/VBO/HFsusAzmSI2czJLb0fhAiWT8ANz85gxAUX3yY4ov8NkxKovuE6M1ZIYEMdx2gAT0Q/x0xzDGqIbYbqpDt5E+CAVy9V+FjH+XA== X-YMail-OSG: hzFdc_IVM1n3cxh5IFM4OPVqcOIBU6HtTuEtwPIMaeVNRw6qxFTBBhQLAYmyQHT B9am3QWR3FeZpIlAfBDjx0N0cciQ0LulyqqftXHthbDIbebW_SH.JwJBJ0JHbzsSD6PbK67xxMBL vPJyMSqagE_VoLwzs4QfjOi6fET_ZqJUfZBcj.c0fYjafBarrEJAtOVGcSXbi3x2EEFmlO0bLF4H _iE2rzW3iQbjTTvDSuycl_pd5ZzA1A29mzRyTlbZrvHyy.JFUyr76o6qJHd7_4ZWASsI5uB4NEqA kiLF.OIWm9FyujjQOZscie4l91huin4BPQkL5na8JRfZNzeC0Um87R7oRSeTuy4OzxYJ.Rh9WsyV Jh.Oq2hEn4OrNRxW8iMxP9K19R5Xm8yWNROGRChKUQfZFksHJOnKnae4wbj1HSZF.uRBRPr_sXLx otGQ0kMiaqFs.Msku.mODVKVhfn4JfOHaV8PklO.ze56Ah7ME53L1lIWBbItTrZJ77Ebyp6IMo7W _AK0PyQY0sWHypwMVFJrRu0qj_KOkMEeer5WqduQ7OUABNPqLLZndF6GzExt4uULiw9jKc1btQep VcmQFSjkESUM9fIOxD7Ar.WB2keHBkx007nFeQ8tmRm7duflQVN_vLK6sTScIJq3NP8bBaLoKBU3 Gmfd3FowLMePsZlrPXzQWEm4njpZVNck8EjUPlGFJ3W0HprIzpA6e1YctFeSvYoAc5yqMXUqxGhI 7IyZdOztmOjj.bmSxhab_2VzNapU29D3p4Ux_jMH662AHX7Zn7UI4QttrYS6KAtJMgqaqO2WT93S ZrZw.eWtk4Sqg6Zd6LUAG5UzaONB5lEJGcq4MUqgbxHnDKw6cLHRtd3QR_AKU4XoIN8FXw3HDziG pjFfibWD_xWEn2B0KlJ4VZAQUl3Ecv4mzXmJmSRkwynST1.tPSUA9AJa0DvvxL95UpmSC9npoSVT lkEO4YnfKQpziHZGuvzH9xtjOHlSdT1ndrImINuKlbcoxFjIrvpmFq3271BobN2CfiFdXDvYU_uk N3Atl7nWvJgluFc2w1rs7tv4RtzajGMaUkNMeoU0jx9dLya38ULwdw2HIdRb6qxiFsmGJXNd.OB4 xn42qeJWOalVg5QM_PMtNvLQgCFfJBD2YyMXyA6ZWN5fh9IgyGKxMwoH6XFsbaErhGuMkMMrP.Ez _Z5F2cDIfOLzlF7FYwHZZjb1A_hY7LzvSKINIesHtItZjG7tLYXkoaUAt138gA20Yaro3vfgdP.e dqNres5KufedQ9Yoo0bi1HRenXDrim1PFOl2za9vkIArTXid6MPJXLG62fU5n6_vkzOEU3JCOMaE ZcLyKG2EoyQf4NjxxsvpJEBr1rvrpRm469kJyggRIos08KEhx6uTGhp.6zg5YzBcSvhS3E6lMTG1 fxEeVi1DBD2b9KY3D0dM77dKq_lXvtDcVfierydfBGCCJ7Ht4IlNq33RXcYitR.MU99snRHnnsrj .HkwjdwbeERC_WAZY.twKXa_xQj_XvKyRWPZndeTg_vLWMBSuPl1x1XDiOUfvVvZvuIRXONtw2tu 39qk4pfa0kfLxiN6Rik6GeQkHQqj2pJzYidDRHogcJpprz38HqfM4E58HRQ5lyrZRBMSLQcR2MR3 hbVNkERi1KSHwnHV_qVx49LIHPyrrZZi1Js1wzHdjjoEO7JrpqMUd2o2PxM76bBWVlXAm4.VBfN. N18J_zFiiUGdTWaQLmNxdUAupy03zpLn9sBewiaXw81wdaWgSLANiAQcSTdR2EDpZTlHdMUuY0Vk 3k9rPll8pKleIcGjAd2u1rJOeRxCdC0nftTd0PccSwfCuA_JABs59JvZnBjiv3kLBX8uIlkmUahr QIKhW8f0a1cvA4SZG_i6MnSqGhVudbiO8dqH.Y_Skswe.gULyAN.miS2reXxzO6I1QIg7exD5ZLE 55JhcRnb5fRVjI4QRCTHNeSC6sAVP4Fd76FBKsWZlkAnqUsmYq3q0iWWVPFw94BYBE_tIXea21u9 xV.c6lWYAHiwG7wJephZAQEcL6c8W3P56PraQuVcNOhhXbNUf37nyNPLbBIV9BB3E4zjrz3tKm37 EHu42TGq1gez04v0orDZkdnskNQGwoEtN0Whzq1mMuQYrzeRgJiQ2GTOcRZXa.yGPhRYWvdQxcVf Mzz5J9n7uu0QZN.niZKtjLx7tuZCcH5pNviiijgTnMa.vNj8rZD2KawxuKBKyYea89Ohgz9dcGX_ AyFBhjYS3TnSMh7CIIuIs4.YN0KG5cTUUCEt7usOTIz014mDlQAH96o9McUHi.nQcM4sjoVjvdqm fYWSsMKCV0rbt2rhnVmufU516t.JMHeq51BztgsVIm2GKSCrtjnJHUEA- X-Sonic-MF: X-Sonic-ID: f1d1970a-d6f5-4bd6-bf62-daae4bf2adbf Received: from sonic.gate.mail.ne1.yahoo.com by sonic303.consmr.mail.gq1.yahoo.com with HTTP; Sun, 21 Jun 2026 18:11:22 +0000 Received: by hermes--production-gq1-7bb7df5c46-bdzch (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID e0c4ecb5dcb57e2976ca6f5730ceb02b; Sun, 21 Jun 2026 18:11:20 +0000 (UTC) Message-ID: <4e902fcf-e79c-47b5-a51f-4881c09f7528@yahoo.com> Date: Sun, 21 Jun 2026 11:11:19 -0700 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 28cecfe27964 - main - libc: Restrict ATOMIC_VAR_INIT for C23 conformance To: Warner Losh , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Faraz Vahedi , Nuno Teixeira References: <6a35ddd3.22963.721d614@gitrepo.freebsd.org> Content-Language: en-US From: Mark Millard In-Reply-To: <6a35ddd3.22963.721d614@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.26016 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-Spamd-Result: default: False [-3.54 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.54)[-0.544]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_FROM(0.00)[yahoo.com]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; FROM_HAS_DN(0.00)[]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; RCVD_IN_DNSWL_NONE(0.00)[98.137.64.206:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[yahoo.com:+]; MLMMJ_DEST(0.00)[dev-commits-src-main@FreeBSD.org]; RWL_MAILSPIKE_POSSIBLE(0.00)[98.137.64.206:from]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_FIVE(0.00)[6] X-Spamd-Bar: --- X-Rspamd-Queue-Id: 4gjzt65DP7z3Srm On 6/19/26 17:24, Warner Losh wrote: > The branch main has been updated by imp: > > URL: https://cgit.FreeBSD.org/src/commit/?id=28cecfe27964fdb67497800f5dcd5d3e1033727f > > commit 28cecfe27964fdb67497800f5dcd5d3e1033727f > Author: Faraz Vahedi > AuthorDate: 2026-05-01 14:34:44 +0000 > Commit: Warner Losh > CommitDate: 2026-06-20 00:23:28 +0000 > > libc: Restrict ATOMIC_VAR_INIT for C23 conformance > > Omit `ATOMIC_VAR_INIT` when targeting C23, where it has been removed. > Retain it for earlier C standards and for C++ (as it still remains in > C++23, albeit marked as deprecated since C17 and C++20.) > > Also separate `atomic_init` definitions from `ATOMIC_VAR_INIT` to > avoid coupling with a deprecated initialisation mechanism. > > No functional change intended for `atomic_init`; this is purely a > conformance and cleanup adjustment. > > Signed-off-by: Faraz Vahedi > Reviewed by: imp > Pull Request: https://github.com/freebsd/freebsd-src/pull/2185 > --- > sys/sys/stdatomic.h | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/sys/sys/stdatomic.h b/sys/sys/stdatomic.h > index c3f9b217519c..2d565ce991be 100644 > --- a/sys/sys/stdatomic.h > +++ b/sys/sys/stdatomic.h > @@ -86,11 +86,17 @@ > * 7.17.2 Initialization. > */ > > +#if __ISO_C_VISIBLE < 2023 || defined(__cplusplus) > #if defined(__CLANG_ATOMICS) > #define ATOMIC_VAR_INIT(value) (value) > -#define atomic_init(obj, value) __c11_atomic_init(obj, value) > #else > #define ATOMIC_VAR_INIT(value) { .__val = (value) } > +#endif > +#endif > + > +#if defined(__CLANG_ATOMICS) > +#define atomic_init(obj, value) __c11_atomic_init(obj, value) > +#else > #define atomic_init(obj, value) ((void)((obj)->__val = (value))) > #endif > > > I expect that the problem reports for port package build failures are tied to src/sys/sys/_visible.h : . . . #elif defined(_C23_SOURCE) /* Localism to specify strict C23 env. */ #define __POSIX_VISIBLE 0 #define __XSI_VISIBLE 0 #define __BSD_VISIBLE 0 #define __ISO_C_VISIBLE 2023 #define __EXT1_VISIBLE 0 #else /* Default environment: show everything. */ #define __POSIX_VISIBLE 202405 #define __XSI_VISIBLE 800 #define __BSD_VISIBLE 1 #define __ISO_C_VISIBLE 2023 #define __EXT1_VISIBLE 1 #endif #endif /* _POSIX_C_SOURCE */ The "show everything" note is wrong now, as C23 removes at least ATOMIC_VAR_INIT . A real "show everything" would require more logic, such as still keeping ATOMIC_VAR_INIT for __BSD_VISIBLE also being 1 or some such (may be inventing a new configuration macro for, say, __ISO_C_BUT_WITHOUT_SOME_REMOVALS). -- === Mark Millard marklmi at yahoo.com