Re: git: 949804c81909 - main - nvme: Use newbus to ask if a device is storage

From: Dag-Erling_Smørgrav <des_at_FreeBSD.org>
Date: Sat, 20 Jun 2026 16:07:08 UTC
Mark Johnston <markj@freebsd.org> writes:
> Warner Losh <imp@freebsd.org> writes:
> > +      static bool
> > +      default_is_storage_device(device_t dev)
> > +      {
> > +          return (true);
> > +      }
> After this commit I see a warning during buildkernel of a GENERIC
> kernel:
>
> nvme_if.c:21:1: warning: unused function 'default_is_storage_device' [-Wunused-function]

Easily fixed by changing `static bool` to `static inline bool`.

DES
-- 
Dag-Erling Smørgrav - des@FreeBSD.org