From nobody Sat Jun 20 00:24:57 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ghwG13ktHz6hFRb for ; Sat, 20 Jun 2026 00:24:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ghwG11jLGz3HpT for ; Sat, 20 Jun 2026 00:24:57 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1781915097; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iXGncXR89A0jz1TzgXM+fZrEXIX4n4AeDkcoA9yHLV8=; b=gLdUZeUCmIqKrMr14kZ6iomeVNLpDZxGiTh+1TlJcuhrRy+Q1xr2zEACJJPSXBL7BTMXVP AT00ZGCLi0QsWAhl5kNKwKT2wGHo9oILGXwvZkhdN0+Mm36DF5wM0CynUyy9do/dEvyBy9 MbQre5TWX92bAY0MmGemV5lGV3eGZ/B151hBhsLsqyo5E+0uO9BEUv3ESx8tDtMAF7IryP EReYD4N3CW3YVTWRx8TiBtGGmPnGT1vYNqt+MDLJsW8zuoe1szz0eHWu3m/3JZFGAx2+Is UGWPelRARl6aIHh9IgvN3vOgT6D5pHl+OUx8Z0CZ45G6FEEZrIHizfXYU/BNqQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1781915097; a=rsa-sha256; cv=none; b=hy3xl5WmYOffAxnptEcZwSjYW7qPv+JmNgH9RqATgLXiKZVvtrZYHvi/yq7wMCHjmRGINh 3J7qPr8mStdJK2vgkMYLD09JAW+UkcUuoPLdrLKG2IS04FRsjy5hS+ocRoWP6J22Zrby1q Bqxak3EiAnqVR3JHptIk4KGPb/d57pDp2l2Uo4417nT0DLFCt2MHf5Ntj0pSf7zHRQw2gH BjyuBOoDZzqeH14VcCkpdwVojaBpnX6yGd3K9QZhFASkL56jUC+0UZtgJ+LmJs/Rm0P/qw 9G2keZUmBvBYjbPbueJ2u+EQh8gj0gZqwoKEEJAWOWT9Qud0xuvkRB2jjyVajQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1781915097; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iXGncXR89A0jz1TzgXM+fZrEXIX4n4AeDkcoA9yHLV8=; b=bxj3xlL+MHQM1gZnw7zv0oPoDuo9CUQ3vbyt7fRW+LkUrAGywtD1v+lCgESvr6xs8Y+1SF AlBmAh7QPSZk+mjteLmrRk6AYVIZo+euDvU2EKo/Ck3eWuYc3dDbShoka3pvV8beaT0XAD CfoFrg37n0p7FKHE09Az9oXn9boG3D9PlshdAev9XvgXCLgN1u67YamyPPbHZ+pBum930l NkTE2y5Ak+TkwDXqI99jmBbw5g5c1RGG2ixw0tfrFSZBQPJiRmNxElVhGHT9dhUANYnNUg iBD/5iiIruLUVpLwypyhjpLDQAFAULUyPYBxGPafKTM5+2uhAbdjG+2C/Sh/VQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4ghwG10VrPz17Pm for ; Sat, 20 Jun 2026 00:24:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 2538f by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 20 Jun 2026 00:24:57 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Faraz Vahedi From: Warner Losh Subject: git: 54ac231419cf - main - libc: Fix atomic_init for GCC atomic objects List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 54ac231419cf09557d2f5826b1539e83db552410 Auto-Submitted: auto-generated Date: Sat, 20 Jun 2026 00:24:57 +0000 Message-Id: <6a35ddd9.2538f.5104dbc7@gitrepo.freebsd.org> The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=54ac231419cf09557d2f5826b1539e83db552410 commit 54ac231419cf09557d2f5826b1539e83db552410 Author: Faraz Vahedi AuthorDate: 2026-05-07 23:00:47 +0000 Commit: Warner Losh CommitDate: 2026-06-20 00:23:29 +0000 libc: Fix atomic_init for GCC atomic objects Add a dedicated `__GNUC_ATOMICS` path that initialises via `atomic_store_explicit(obj, value, memory_order_relaxed)`. This ensures the required initialisation semantics without assuming any particular object representation. Previously, `atomic_init` on GCC fell through to the legacy `__val` member path intended only for old struct-backed atomic objects. For current atomic objects, this caused the following compilation error: > error: request for member '__val' in something not a structure or union As a result, valid code such as `atomic_init(&x, 1)` failed to compile when using GCC. This fix restores compatibility with standard-conforming callers while other code paths remain unchanged. Signed-off-by: Faraz Vahedi Reviewed by: imp Pull Request: https://github.com/freebsd/freebsd-src/pull/2185 --- sys/sys/stdatomic.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sys/sys/stdatomic.h b/sys/sys/stdatomic.h index 3e4bdd505418..c0cbb7f785b5 100644 --- a/sys/sys/stdatomic.h +++ b/sys/sys/stdatomic.h @@ -96,6 +96,9 @@ #if defined(__CLANG_ATOMICS) #define atomic_init(obj, value) __c11_atomic_init(obj, value) +#elif defined(__GNUC_ATOMICS) +#define atomic_init(obj, value) atomic_store_explicit(obj, \ + value, __ATOMIC_RELAXED) #else #define atomic_init(obj, value) ((void)((obj)->__val = (value))) #endif