From nobody Fri Jul 31 18:21:18 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hBZCN3pYfz6nHWr for ; Fri, 31 Jul 2026 18:21:36 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hBZCN1jLGz4FqQ for ; Fri, 31 Jul 2026 18:21:31 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-c1c50c1e29bso190740166b.3 for ; Fri, 31 Jul 2026 11:21:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785522090; x=1786126890; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:content-type:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6n6/glaECloMay/V5/wcbmPykILONrDG/NRgTqv1fNc=; b=ZL3KPjYCb/Yax3W9JIq9+e3k0CUK8Afm7gI/UDK390rqwOM9+jCagy2W48fbJuDwpW sXy5+CSlKdbjhgbbWxr56znM/OHRyZOBMEcg5Q5p9OwF7OJ2kAPGPE0FLZiwE3GIEGPj yftWzp5j9o7FWgxEmGyfiv0GR/Zam7Esmz/Bndkkv12xJ7Ni+UWCc1yvFzRuqvTfmXve a8lt+4GH1LkWv7NCTQ/7/R9gVvjM/I97iyb71CqeSSkm5wPg/VhOQs0NrVJ6PmmndezR wpBI5Ch/syzvgRxWmAD8uETDt2KFrQYK3xCM6cD8KD7O0Xd+iQ0C2njsSvIRUOFHim1F hm3A== X-Forwarded-Encrypted: i=1; AHgh+RqtUUEQgTQmQGoA+0H39vPytoU85hdPeO0a66jE1W3J4t6fU3AhcU5+wHF1TfuJszF5w6lfIOGF+V+7sPKezSGQlN1lZA==@freebsd.org X-Gm-Message-State: AOJu0YzC4rfJW3rY12j6CHcr+ZmYFME7sFO+1qU2MWGYExb7rXAliiIe twUL/kOvIFs/O7BLRgqkADgjXZaAKs7407tCEJ4Y0PyEXPyhc1s6+gnOD/ba78PrtFo= X-Gm-Gg: AR+sD13iP+AEjWr7Q8vryHTfOciVrTJyklrv130vwMBTyzIbmoTQBk7WQVflU5uhdct aaQI5sz48IzSgIK/M8dNYG3kJBPbm62L8GI+a7uZFOL+qlCffuCBzulen1zHxTJBuJkGr6Jqn9e 3NMkZXrn7uK97y1k80VrEHvS+rnHc2K8yh5XKclHgx59x43kricojYEdxNOPx4+W7usGKNjftGq Y5ki1+/6/9CUU0Wh3xp99HbQ0wdFs7aV6lxYx6DxweRIQ9hAzF6r0rd0KqykZeT3DswfxbpX4C9 vr6BZXtQ39BppLjyu30giNeDKKECzHp3FgROS3qZFLR2wmYuKNAL5RJVUgFGyJna2CRH6p7BsM/ 0HWbQVMK+XviX5WhiyXzUk1i3MDsqBcWFEKmfcA6hgRW3sNxU1sXBfwZEPlCASKy2VqtMGmsl2O A/ogJwsR9gy/vebF98Afp5S9qSZNZLOO73PE1XeR2yVoWjnEyDSQSjamXlx+UmuFts9s3r90IKV 3GJDBlr4erz0YhOjwQOrbDKKr2PPzERCf7h6wahbud9Nw== X-Received: by 2002:a17:906:1005:20b0:c16:2a6d:86da with SMTP id a640c23a62f3a-c1fe82b1780mr36556266b.54.1785522089507; Fri, 31 Jul 2026 11:21:29 -0700 (PDT) Received: from smtpclient.apple (nat-184-161.net.cam.ac.uk. [131.111.184.161]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a09c655446sm2411833a12.21.2026.07.31.11.21.28 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 31 Jul 2026 11:21:28 -0700 (PDT) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3897.100.8.1.1\)) Subject: Re: git: 8aec309852b5 - main - stand: Remove a pointless goto From: Jessica Clarke In-Reply-To: <8d8b4b46-b5b8-41cb-be17-fc51128c8a94@woozle.net> Date: Fri, 31 Jul 2026 19:21:18 +0100 Cc: John Baldwin , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <3BD5981B-011B-4957-BA95-11DBCADFA868@freebsd.org> References: <6a6ce20e.3f382.1f114d7@gitrepo.freebsd.org> <8d8b4b46-b5b8-41cb-be17-fc51128c8a94@woozle.net> To: Dmitry Morozovsky X-Mailer: Apple Mail (2.3897.100.8.1.1) X-Rspamd-Queue-Id: 4hBZCN1jLGz4FqQ X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Spamd-Bar: ---- On 31 Jul 2026, at 19:01, Dmitry Morozovsky wrote: >=20 > Hohn, >=20 > On 31.07.2026 20:57, John Baldwin wrote: >> The branch main has been updated by jhb: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D8aec309852b5285cfa03424f7776a0bf= 432dff7a >>=20 >> commit 8aec309852b5285cfa03424f7776a0bf432dff7a >> Author: John Baldwin >> AuthorDate: 2026-07-31 17:50:33 +0000 >> Commit: John Baldwin >> CommitDate: 2026-07-31 17:50:33 +0000 >>=20 >> stand: Remove a pointless goto >> Commit 505222d35fea removed a batch of code that this goto = used to skip >> around. >> Reviewed by: olce, kib, markj >> Fixes: 505222d35fea ("Implement the long-awaited = module->file cache database. A userland tool (kldxref(8)) keeps a cache = of what modules and versions are inside what .ko files. I have tested = this on both Alpha and i386.") >> Differential Revision: https://reviews.freebsd.org/D58539 >> --- >> stand/common/load_elf.c | 3 --- >> 1 file changed, 3 deletions(-) >>=20 >> diff --git a/stand/common/load_elf.c b/stand/common/load_elf.c >> index 1c4efb8c4156..97467094750c 100644 >> --- a/stand/common/load_elf.c >> +++ b/stand/common/load_elf.c >> @@ -921,9 +921,6 @@ nosyms: >> if (__elfN(parse_modmetadata)(fp, ef, p_start, p_end) =3D=3D 0) >> goto out; >> - if (ef->kernel) /* kernel must not depend on anything */ >> - goto out; >> - > but then previous check becomes useless too, isn't it? Yes, but the next commit restructures the code so that if/goto is = meaningful. Jessica