From nobody Fri Jul 31 17:00:07 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hBXPP58mbz6n8vr; Fri, 31 Jul 2026 17:00:09 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hBXPP4YqGz40pM; Fri, 31 Jul 2026 17:00:09 +0000 (UTC) (envelope-from kevans@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785517209; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=WEoBZ/7hE0XMwzGrVpCQ7w9AAukGep9gJxMQUfmVDeA=; b=Ki1llJiPRqanZ+KcZJdCuJ0Nk2gBdxq/2KQ5C7bvtO6L1xk4IEsIIHywRXTq92JdabmV8d 0IAR1Yes0rZs4bHRVt+u0KrSMUKbG7xOzOY55cKnImNVb6qhiOTB2VLIIaGHUZEa9ClQlK MPdRf6MOv/QtDScTzgCBC15ppYIsHsvNU6dfFvUXtrkzNMVeQ4OGtQGqIYtIKsZkJ4ZcGo dXqwN9xcsYZ5kFTgK08TSWth4dUolztMhA4Tj2jf/W8xLSuFHt6HawYr/jDsRbDvGPb6cT VHFus96lmIC4EAcVoTocQVkXU+uVj3bVFTF3Y3R2worhokvDjLlb2jFW0ubXHg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785517209; a=rsa-sha256; cv=none; b=lQUAwwuc+jsKWtkbGEOUrYmFZ0cYY3JVhka6RaXXlKbw6S6+mDuOnwt4e5KqROWz/sYpad aoaleD2lJUjk0Oe5AWhSr2f5GThc65DGPNOzReqAPvz0ViPSfMmuUbducPwblaX6JuDS+z tU0zKWnG/aXNrpt6QyGmgPpnsoHnAceF4yE22S3+uoxHBs12Fnxyk/P2LCV+IqgeCl9SmH 0mYNjd1JnilwaBwpnUh+19A/Syj4YnhMOAHN63izi3z0I2arb3/oA3TG26YHdl+dL+CqW1 SUauR8aRFaK0wAgK6yUcS9eWWyKFebXOmNJRs2Gc+aexPEzqqsLo+/nZlUWT0Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785517209; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=WEoBZ/7hE0XMwzGrVpCQ7w9AAukGep9gJxMQUfmVDeA=; b=WcBzJr0purrKJlrFfvl94wYbVjRyOQc5EfIoHigNkHtIglI+9ETbSqIjejek7ipRARPvvM Yk+AsB0Nbg+2aCHUlhu/jKjDayyRTr5n8O+Ri5cAWc//+1J272mrZzgHq2UyEROt0MXwpD H0+MqAEmmOEwvYbMkdAzh8+tAGTAYVu1zMRl0r2Gxgk3voSpc47GKUNQSZSxQ8aTt3ByTb niZ14On6Mm0em3vV6nI2dUHGcQQePfRqRtfpx7BT2Yflnv+Je4XFRFN3pY+pH8ijbQ+PN9 I0LcRSZ+cj2fBiKynBZWATl0STVJd+mErj1DV4UlsxfFSvoR4V/TjqnjbQex8g== Received: from [10.9.4.95] (unknown [209.182.120.176]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) (Authenticated sender: kevans/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4hBXPN3Rgfzr7g; Fri, 31 Jul 2026 17:00:08 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Message-ID: <4e6ba52d-33f4-4af7-867c-c62547dcdc16@FreeBSD.org> Date: Fri, 31 Jul 2026 12:00:07 -0500 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: dd235f097af4 - main - route(8): Add prefsrc option in netlink From: Kyle Evans To: Pouria Mousavizadeh Tehrani , Shawn Webb Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <6a6917c5.1e42d.6373b3b9@gitrepo.freebsd.org> <2405606b-929d-49ba-97b6-c57eb28b9eaa@FreeBSD.org> <8f33c455-680b-4ac8-804f-7c63b9915363@FreeBSD.org> Content-Language: en-US Autocrypt: addr=kevans@FreeBSD.org; keydata= xjMEWySaMRYJKwYBBAHaRw8BAQdAdk/Fqvvw2gwIzw2l1UAbv5mrT35Y5ylfHyUBEcWY3AzN H0t5bGUgRXZhbnMgPGtldmFuc0BGcmVlQlNELm9yZz7ClgQTFggAPgIbAwULCQgHAgYVCgkI CwIEFgIDAQIeAQIXgBYhBPv/ZC7g03RcLBP+TBlOtBOHRwt7BQJlp2YoBQkQJmZ1AAoJEBlO tBOHRwt7krYBAPnGTE/v9EcirWF5oGU+J19nr0wOpPCQzMOxCf5e2km5AQDHIznIhaLvZYUw LlxiBE7MEs/2w4WfXRgW+LuAkzedCc44BFskmjESCisGAQQBl1UBBQEBB0B84DgMSsY6hG+1 o57XJAuqj+dVfG+esKnEiO6T886KYAMBCAfCfgQYFggAJgIbDBYhBPv/ZC7g03RcLBP+TBlO tBOHRwt7BQJlp2ZOBQkQJmadAAoJEBlOtBOHRwt75v8A/Aq5ti6ACDG6/Hfodp9rfed9UQIH q45o6ymUj2TnhTJWAP45Wtv80BB+TiEcWCG7kcOYB3hcqZlD8k8vfito8b3KBA== In-Reply-To: <8f33c455-680b-4ac8-804f-7c63b9915363@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/31/26 11:59, Kyle Evans wrote: > On 7/31/26 11:05, Pouria Mousavizadeh Tehrani wrote: >> Hi Shawn, >> >> On 7/31/26 19:28, Shawn Webb wrote: >>> Hey Pouria, >>> >>> This commit causes /sbin/route to crash. I will work on getting a core >>> dump this weekend. Reverting this commit made /sbin/route happy again. >>> I just figured I'd send the email now while I'm thinking about it. >>> >>> Note that I'm using HardenedBSD, so the core dump might be a little >>> bit different than one generated by FreeBSD. >>> >>> Thanks, >>> >> >> Thank you for the report. >> I'll keep an eye out for your email. >> > > It seems like this should be predicated on `prefsrc != NULL`: > > ``` > snl_add_msg_attr_ip(&nw, RTA_PREFSRC, prefsrc); > ``` > > snl_add_msg_attr_ip seems like it'd be happy to dereference `prefsrc`, and > we might not have one? > > Thanks, > > Kyle Evans > Ahh, I see the follow-up now.