From nobody Fri Jul 31 10:58:39 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hBNNJ2Qghz6n1b6 for ; Fri, 31 Jul 2026 10:58:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hBNNJ1t1Pz44BR for ; Fri, 31 Jul 2026 10:58:40 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785495520; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=K7afbt0QVOAsNCgXPy+4jSCjzibZBBNAMTfK+nvmRWk=; b=T99ri1DGTFZORPRdeQtdHETiKx9QkBg9MfE6i0GZDPdXflnkO0M8AByg3DUq2eyZT9v0md Dg6bGOYYZqAzFN+lZZ9Vk32moKCPiIh+1XdESIvCxaV7XGChdl2KeKVdbxn3Izq5/tsk8j 3DlSIdDe3+x0Nnv/s0Yzj37ISkT/WoBQZBz2NkHmRHaDK8QE7Hf9MGsJSYsqb2cBYYXS4V nRXzwftEGAEeLWJkMEKRhiHszchJ6HlJWaEnSvDAKiyr+gUY7p2NXpPxWAnzZVw+osIre5 HuTyEyolYs+saJFHepW27xG/OKoqZ2/TeYxyaRe1SBum4WhzyM6GW+rpvX4ZIA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785495520; a=rsa-sha256; cv=none; b=YXsuDVHRoRD9m6t0G8LNS0J0zpcItR5LLEb3JmTzmG9fi9ltrifDQnaKFiztCiZJge1Kkg VUM3TljU9fk9kNtHn2ihgh6WuFxdAQ5OF3etyxBPG7b46kPjRQ3+VxnogJJFcT4pI1jt+D +x2HoN5OQ8GhNhKFshi9+HX44xK0f//PyQwBBn5UnEgMKrNq+V6LKUN0eCbk9E7tdME1ZT EUS1ehyO7DEn72Kf1fPAhTT3cVM7w0TJbmxOV6A1UIaOdKrKln/ImzMeZXAa72DCLWYBB4 bd3EdPqEbJwEqXv8tse8HyeHFKdR40TcxcpVz6fcbv+DEtIzgBNb7Guk/qK+8A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785495520; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=K7afbt0QVOAsNCgXPy+4jSCjzibZBBNAMTfK+nvmRWk=; b=PWVUybypXbEmjn/ee598QelAMIyq3AnmRDRERBbTD+pPDXuhSb1+by6YkyIZCPSAgHvMGI 15QZyfvPlW7YhhCRbPyNkhsm8cNBivp9NeSD0i2QoQJp/z07uyptbHCsN0QGMJkYvPpmSq Id38FuN8GTKLaMdxIUBTlO1g+XRFpZtZ41XfIBOT5eZRqQxyVfWJCvf+A5ihOmc3AQcnEG EdtdZTR40QJw+OSb3mqpWZnHFI2TKz5WLXu9lOrnnRTP1ksWTgi6eN0Peipcq8kOFORLD+ 1pQsaF+9b746DrCFK4yMiYB3TmFVJpPF0WX2YBbfBPhjhTXJA8rYlVxuek+M2Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hBNNJ0NP4zxC3 for ; Fri, 31 Jul 2026 10:58:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 39ad4 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 31 Jul 2026 10:58:39 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: 6020de5ad154 - main - ixv: fix multicast address enumeration List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6020de5ad154d54c8b9a838f28612c2182330c67 Auto-Submitted: auto-generated Date: Fri, 31 Jul 2026 10:58:39 +0000 Message-Id: <6a6c7fdf.39ad4.c070c42@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=6020de5ad154d54c8b9a838f28612c2182330c67 commit 6020de5ad154d54c8b9a838f28612c2182330c67 Author: Kevin Bowling AuthorDate: 2026-07-28 11:06:23 +0000 Commit: Kevin Bowling CommitDate: 2026-07-31 10:56:15 +0000 ixv: fix multicast address enumeration if_foreach_llmaddr() adds each callback return value to its running count. Returning the incremented count made the address indices grow as 0, 1, 3, 7, and so on, eventually writing beyond the multicast address array. Return one address per callback and stop copying when the array is full, matching the ixv-1.6.12 driver. Fixes: ff06a8dbb677 ("Mechanically convert ixgbe(4) to IfAPI") MFC after: 1 week --- sys/dev/ixgbe/if_ixv.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sys/dev/ixgbe/if_ixv.c b/sys/dev/ixgbe/if_ixv.c index 8a1c1aae041d..24e6fa714a7b 100644 --- a/sys/dev/ixgbe/if_ixv.c +++ b/sys/dev/ixgbe/if_ixv.c @@ -842,11 +842,14 @@ ixv_negotiate_api(struct ixgbe_softc *sc) static u_int ixv_if_multi_set_cb(void *cb_arg, struct sockaddr_dl *addr, u_int cnt) { + if (cnt >= MAX_NUM_MULTICAST_ADDRESSES) + return (0); + bcopy(LLADDR(addr), &((u8 *)cb_arg)[cnt * IXGBE_ETH_LENGTH_OF_ADDRESS], IXGBE_ETH_LENGTH_OF_ADDRESS); - return (++cnt); + return (1); } /************************************************************************ @@ -1982,4 +1985,3 @@ ixv_init_device_features(struct ixgbe_softc *sc) if (sc->feat_cap & IXGBE_FEATURE_NEEDS_CTXD) sc->feat_en |= IXGBE_FEATURE_NEEDS_CTXD; } /* ixv_init_device_features */ -