Re: git: f22b08443f6a - main - tcp_hostcache: explicitly typecast atomic_load_int to (int) for comparison

Hi,

This commit message is telling *what* the diff changes. And is a bit redundant in that sense.

I was surprised that the linked review has a very nice explanation of *why* this change was needed.

I think it will be very valuable to future commit readers to include the *why* in the commit message. The *why* in the message, the *what* is already in the diff.

Regards,
Ronald.

 
Van: Richard Scheffenegger <rscheff@FreeBSD.org>
Datum: dinsdag, 21 juli 2026 17:21
Aan: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Onderwerp: git: f22b08443f6a - main - tcp_hostcache: explicitly typecast atomic_load_int to (int) for comparison
> 
> The branch main has been updated by rscheff:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=f22b08443f6ae3620dd14ade4e2376b8531fd6f3
> 
> commit f22b08443f6ae3620dd14ade4e2376b8531fd6f3
> Author:     Richard Scheffenegger <rscheff@FreeBSD.org>
> AuthorDate: 2026-07-21 14:51:02 +0000
> Commit:     Richard Scheffenegger <rscheff@FreeBSD.org>
> CommitDate: 2026-07-21 15:20:32 +0000
> 
>     tcp_hostcache: explicitly typecast atomic_load_int to (int) for comparison
>     
>     Sponsored by:   NetApp, Inc.
>     MFC after:      1 week
>     Reviewed By:    tuexen, #transport, markj
>     Differential Revision: https://reviews.freebsd.org/D58360
> ---
>  sys/netinet/tcp_hostcache.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sys/netinet/tcp_hostcache.c b/sys/netinet/tcp_hostcache.c
> index e5c20b6f2475..fbf81b1f2303 100644
> --- a/sys/netinet/tcp_hostcache.c
> +++ b/sys/netinet/tcp_hostcache.c
> @@ -768,7 +768,7 @@ tcp_hc_purge_internal(int all)
>                 "bucket length out of range at %u: %u", i,
>                 head->hch_length));
>             if (all ||
> -               atomic_load_int(&hc_entry->hc_expire) <= 0) {
> +               (int)atomic_load_int(&hc_entry->hc_expire) <= 0) {
>                 if (hc_prev != NULL) {
>                     KASSERT(hc_entry ==
>                         CK_SLIST_NEXT(hc_prev, hc_q),
>  
> 
> 
>