Re: git: 74654ba3b1b3 - main - chflags: Add a new UF_DONTCACHE flag

On 13 Jul 2026, at 03:56, Rick Macklem <rick.macklem@gmail.com> wrote:
> 
> On Sun, Jul 12, 2026 at 7:19 PM Jessica Clarke <jrtc27@freebsd.org> wrote:
>> 
>> CAUTION: This email originated from outside of the University of Guelph. Do not click links or open attachments unless you recognize the sender and know the content is safe. If you are unsure, forward the message to ITHelp@uoguelph.ca for review.
>> 
>> 
>> On 12 Jul 2026, at 23:47, Rick Macklem <rmacklem@FreeBSD.org> wrote:
>>> 
>>> The branch main has been updated by rmacklem:
>>> 
>>> URL: https://cgit.FreeBSD.org/src/commit/?id=74654ba3b1b3bcf6ba8870a54310accbb6adbf0b
>>> 
>>> commit 74654ba3b1b3bcf6ba8870a54310accbb6adbf0b
>>> Author:     Rick Macklem <rmacklem@FreeBSD.org>
>>> AuthorDate: 2026-07-12 22:45:28 +0000
>>> Commit:     Rick Macklem <rmacklem@FreeBSD.org>
>>> CommitDate: 2026-07-12 22:45:28 +0000
>>> 
>>>   chflags: Add a new UF_DONTCACHE flag
>>> 
>>>   This internet draft (which is close to being an RFC)
>>>   specifies a new NFSv4.2 attribute which tells the NFSv4.2
>>>   client to not cache file data. (Similar to O_DIRECT, but
>>>   triggered by this attribute set on the file on the NFSv4.2
>>>   server and not by the application's open(2).)
>>> 
>>>   https://datatracker.ietf.org/doc/draft-ietf-nfsv4-uncacheable-files/
>>> 
>>>   This patch adds a new chflags(1) flag called UF_DONTCACHE to
>>>   implement this.
>>> 
>>>   Patches for NFS and ZFS will be done separately.
>>> 
>>>   Reviewed by:    kib
>>>   MFC after:      2 weeks
>>>   Differential Revision:  https://reviews.freebsd.org/D58181
>>> ---
>>> lib/libc/gen/strtofflags.c | 4 +++-
>>> sys/fs/tmpfs/tmpfs_subr.c  | 2 +-
>>> sys/sys/stat.h             | 1 +
>>> sys/ufs/ufs/ufs_vnops.c    | 2 +-
>>> 4 files changed, 6 insertions(+), 3 deletions(-)
>>> 
>>> diff --git a/lib/libc/gen/strtofflags.c b/lib/libc/gen/strtofflags.c
>>> index 73b4db54ccdd..ca12401c37e5 100644
>>> --- a/lib/libc/gen/strtofflags.c
>>> +++ b/lib/libc/gen/strtofflags.c
>>> @@ -80,7 +80,9 @@ static struct {
>>> { "nosparse", 0, UF_SPARSE },
>>> { "nousparse", 0, UF_SPARSE },
>>> { "nosystem", 0, UF_SYSTEM },
>>> - { "nousystem", 0, UF_SYSTEM }
>>> + { "nousystem", 0, UF_SYSTEM },
>>> + { "nodontcache", 0, UF_DONTCACHE },
>>> + { "noudontcache", 0, UF_DONTCACHE }
>> 
>> Hi Rick,
>> This breaks cross-building from Linux; please fix or revert.
>> 
>> (This is a bootstrap file for use with makefs)
> I'll revert it, but I have no idea what you are talking about.

Thank you. For reference:

  https://docs.freebsd.org/en/books/handbook/cutting-edge/#building-on-non-freebsd-hosts

And the failing GitHub Actions job that tests every push:

  https://github.com/freebsd/freebsd-src/actions/runs/29212286112/job/86701932770

Presumably the tools/build/cross-build/include/linux/sys/stat.h compatibility shim just needs to grow a new define, but it’s too late here to get into checking if there are other issues or not.

If you want to test an updated patch, you can file a pull request against the official GitHub repository and all the GitHub Actions will run on it.

Jessica