From nobody Sat Jan 24 09:51:44 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dyqnr257pz6PXMY for ; Sat, 24 Jan 2026 09:51:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dyqnr0Z4mz4B1S for ; Sat, 24 Jan 2026 09:51:44 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769248304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WEtv8evFe6GaJsTOB7FSlwN1kMUVxNgLcqgpy1ZGOR0=; b=CT5BNZtUFVOBCak7/6rHzs/r1zIHH4tKPgaTUexrDBhSJhoHXfGvvS6QcTCXG9lTCdhFL3 ag1YKrVDecLDingSVl7gr6IqUwUatxUC+0RzvHTv8iCwyWCCG3A1Op+lRiE+IvTDBFdn4K hBkso2/D4vJ092A3MWqBnz+gif2/E0LOtRAyeRbjPKooOGQ1obNaUi+7W2Lr0nYxcWI9s6 Reugw9ts+ghxau4AjzTooUEORpmiWXhTENw3akAa4mSChb679hhj7XE8GY7BSJI3tYxESy nlXhRRy2PaeEvEmwMN+dtPQKUgy+mNEXbOUDrmOhBxwMofUsFFiUbPtP4qyZpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769248304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WEtv8evFe6GaJsTOB7FSlwN1kMUVxNgLcqgpy1ZGOR0=; b=rFBDtySqw0uW6QL+b4ExuJyJ4sjxrLUQTOy/CSpAZvwHv3G44Ub344nVjde2l12ukz2qE3 W3a5GVVPIM9qwNyD2WmL/GAWToi13ajQiMkXWqa/JV9gDq+NigQoM7PyCcesgT2U0JjCek tgSaq5GtALDlpxdEedYylL0Kv7avmMRw2c0cwyEfxwWE7GHyQN5WUVHFMBS0RpUkg23apY 9sYg5mRL7w4hrUhQJhqTv2fI/eRJ2DnUuQ9hc04GjHQ/aLKDnDMPO+iEmN7g7xMzokiWoQ GrxaKNNwskuCMb+1lW+j1oYAo4wS5ABItG9H9/p9AIP/nrEcF6SbGRrDORzbag== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1769248304; a=rsa-sha256; cv=none; b=yzDCdDKdZPQqkrv5mQTqLRmB8AN+jbDOxLf3Hg35Rm3h3yU/lrwB7K2jNOjG9GsdKmcI6n fr2mrOuEkzCIcWLR44PIE0oYqdY9qcb4St6ePW5+yLbrN4ZEzzsMgWV1+BSeRk8WCWpjDY ky5sf5uU3S8kCl01Y5fvA7gMZ7FoNdyT1w9s6Zm8Zy5DAfj5HzT5zuTLze7O7Zhmi83ATk ic2n4zjn0aKnh1BcBTUAVw2cnsw8Mhylh93Aef/a0uAUsrsKxT7Cg3tknfVMA0IEUwbqfA mASJY2b2XrPtxjwbOR9cIAY6DR9XHjnWXrDqsMLa3tjZzXi8HnD3xoo9xeaYyw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dyqnr05Nrz10R6 for ; Sat, 24 Jan 2026 09:51:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 309de by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 24 Jan 2026 09:51:44 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Pouria Mousavizadeh Tehrani Subject: git: 04f6b99947d2 - main - netlink: use caller's credentials in rtnl_handle_newlink List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: pouria X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 04f6b99947d2d2e0f6ec7703609c74083b5646e2 Auto-Submitted: auto-generated Date: Sat, 24 Jan 2026 09:51:44 +0000 Message-Id: <69749630.309de.521b11ac@gitrepo.freebsd.org> The branch main has been updated by pouria: URL: https://cgit.FreeBSD.org/src/commit/?id=04f6b99947d2d2e0f6ec7703609c74083b5646e2 commit 04f6b99947d2d2e0f6ec7703609c74083b5646e2 Author: Pouria Mousavizadeh Tehrani AuthorDate: 2026-01-24 09:50:50 +0000 Commit: Pouria Mousavizadeh Tehrani CommitDate: 2026-01-24 09:50:50 +0000 netlink: use caller's credentials in rtnl_handle_newlink Make sure rtnl_handle_newlink sets the caller's credential during calls to ifc_create_ifp_nl and ifc_modify_ifp_nl Reviewed by: glebius, melifaro Approved by: glebius (mentor) Differential Revision: https://reviews.freebsd.org/D54109 --- sys/netlink/route/iface.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/sys/netlink/route/iface.c b/sys/netlink/route/iface.c index e9c053015fad..2ae43e22f7ed 100644 --- a/sys/netlink/route/iface.c +++ b/sys/netlink/route/iface.c @@ -675,6 +675,8 @@ static int rtnl_handle_newlink(struct nlmsghdr *hdr, struct nlpcb *nlp, struct nl_pstate *npt) { struct nlattr_bmask bm; + struct thread *td = curthread; + struct ucred *cred; int error; struct nl_parsed_link attrs = {}; @@ -683,10 +685,16 @@ rtnl_handle_newlink(struct nlmsghdr *hdr, struct nlpcb *nlp, struct nl_pstate *n return (error); nl_get_attrs_bmask_nlmsg(hdr, &ifmsg_parser, &bm); + /* XXX: temporary patch until the D39180 review lands */ + cred = td->td_ucred; + td->td_ucred = nlp_get_cred(nlp); if (hdr->nlmsg_flags & NLM_F_CREATE) - return (create_link(hdr, &attrs, &bm, nlp, npt)); + error = create_link(hdr, &attrs, &bm, nlp, npt); else - return (modify_link(hdr, &attrs, &bm, nlp, npt)); + error = modify_link(hdr, &attrs, &bm, nlp, npt); + td->td_ucred = cred; + + return (error); } static void