From nobody Sun Feb 22 18:08:11 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fJsRH6crSz6TX81 for ; Sun, 22 Feb 2026 18:08:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fJsRH5Rjbz40dS for ; Sun, 22 Feb 2026 18:08:11 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771783691; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gEQz+f6UkMfB3uxlG9RbWacyG5ng/lZ32m7vdwIAuQo=; b=ZBGWDmQqtXSq1UYtCbNODfFms6DAYqg7VW2R/GnKGLgw+WWhsbIMWPTBSXUg67r2emgput +YFm55PmR1BSyjuRqLsyEDS50YIX3Z/Moh4mcuQAQY7brVnTbJeXxBhDkfPJr/WywcsdOG OZ+MaD7h3i12TQq1sz7Sl2FuNyIntK3N2pDK66mXw+rA+uGMz3cCIs2IoggJKCdeGCAgIX VcpckopFVR080PfhwaIfNPULPsQLjBCpP4txvbMxD+rC4W6ynLXm554x0ruPnV6Ec82//1 HPndhAwlABkx4EHbUrqd4Iv/DrzuRoJjP7OGgv/pv40KECOzMauvt7OZn8XBrQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1771783691; a=rsa-sha256; cv=none; b=S3uqUPzt7VyufiKXbEvgvBJi1f83VCBi2ybv7ebKx+UVRNY/8hnh2KpfWiOB2F6wpTwi1r WtUzZKCU0/RF29kRpzST2USazou8rC56eUDK21Th7ns2Hg1CI3pt70W7BmSrF1s69jaiP/ Pc+ScX6SdHLZ6aopr9RKgjK15OqL5G3rIE2gdxWhJvXoNAojT6vrLrivl4jLxxgLq6aafz /ML7937/69VQfAuSklW4Yb8Ht3XI8kJSnc+JmpFolkodoJGOLxwuEa7wsPEzBU7QttOPB6 oRdvDfcPss6WftYIj4iv31ku6V99RY3lZ/+mCg9RLhCPi4aYCkt81md1cvHzEg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771783691; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gEQz+f6UkMfB3uxlG9RbWacyG5ng/lZ32m7vdwIAuQo=; b=lh3GMk8L9DjRJfKiakerb0nU+6EUff4gK9pXxTRbOoEG5vQpkTKBdubqtP+gxL37u1Jl0m lEmhIDanYq+T1jnQ0XbgDlsvRFgDhmYvCROYmi+WNwS5O+Vm6HznZs5sfiIZTpbcbkz4v3 2XUe9JrcfYxyXgbyWfavEP708B7fFOrl6+Dqw1Iw/4MU8bCudlNeyRlFWa3boqwXHX8n0m uaNf0C/yAKXZrkzBNRBlk9tL8/O5nb/W1ce0NpfB9MXXcm8a1Y3yUd2orQt/Yp7Pc5K7xs f1qmusK0acr7sjx0NIZ8Q2+tTxni2vzZ1RDL97NFN/bbqZ00ksOlXWAKylTW6w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fJsRH4tcSzvc2 for ; Sun, 22 Feb 2026 18:08:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3d256 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 22 Feb 2026 18:08:11 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Christos Longros From: Adrian Chadd Subject: git: acbf7498f5e1 - main - rge: log silicon revision during attach List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: adrian X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: acbf7498f5e11b00ffcd6c12bdb8bd1eddeb6d7f Auto-Submitted: auto-generated Date: Sun, 22 Feb 2026 18:08:11 +0000 Message-Id: <699b460b.3d256.1396c93@gitrepo.freebsd.org> The branch main has been updated by adrian: URL: https://cgit.FreeBSD.org/src/commit/?id=acbf7498f5e11b00ffcd6c12bdb8bd1eddeb6d7f commit acbf7498f5e11b00ffcd6c12bdb8bd1eddeb6d7f Author: Christos Longros AuthorDate: 2026-02-22 18:06:50 +0000 Commit: Adrian Chadd CommitDate: 2026-02-22 18:07:37 +0000 rge: log silicon revision during attach The initial import from OpenBSD contained chip revision printf() calls commented out, as OpenBSD's bare printf() style does not translate to FreeBSD's device_printf() idiom. The result is that users cannot distinguish RTL8125 from RTL8125B, RTL8125D_1, RTL8125D_2 etc. via dmesg alone, even though all variants show as '' from the PCI probe string. Add proper device_printf() calls including the raw hwrev value, consistent with how re(4) reports chip revisions. Signed-off-by: Christos Longros Reviewed by: zlei, imp, adrian Differential Revision: https://reviews.freebsd.org/D55402 --- sys/dev/rge/if_rge.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/sys/dev/rge/if_rge.c b/sys/dev/rge/if_rge.c index dfa6cd1325e5..b2f1311b4c87 100644 --- a/sys/dev/rge/if_rge.c +++ b/sys/dev/rge/if_rge.c @@ -413,31 +413,31 @@ rge_attach(device_t dev) switch (hwrev) { case 0x60900000: sc->rge_type = MAC_R25; -// device_printf(dev, "RTL8125\n"); + device_printf(dev, "chip rev: RTL8125 (0x%08x)\n", hwrev); break; case 0x64100000: sc->rge_type = MAC_R25B; -// device_printf(dev, "RTL8125B\n"); + device_printf(dev, "chip rev: RTL8125B (0x%08x)\n", hwrev); break; case 0x64900000: sc->rge_type = MAC_R26_1; -// device_printf(dev, "RTL8126_1\n"); + device_printf(dev, "chip rev: RTL8126_1 (0x%08x)\n", hwrev); break; case 0x64a00000: sc->rge_type = MAC_R26_2; -// device_printf(dev, "RTL8126_2\n"); + device_printf(dev, "chip rev: RTL8126_2 (0x%08x)\n", hwrev); break; case 0x68800000: sc->rge_type = MAC_R25D_1; -// device_printf(dev, "RTL8125D_1\n"); + device_printf(dev, "chip rev: RTL8125D_1 (0x%08x)\n", hwrev); break; case 0x68900000: sc->rge_type = MAC_R25D_2; -// device_printf(dev, "RTL8125D_2\n"); + device_printf(dev, "chip rev: RTL8125D_2 (0x%08x)\n", hwrev); break; case 0x6c900000: sc->rge_type = MAC_R27; -// device_printf(dev, "RTL8127\n"); + device_printf(dev, "chip rev: RTL8127 (0x%08x)\n", hwrev); break; default: RGE_PRINT_ERROR(sc, "unknown version 0x%08x\n", hwrev);