From nobody Sun Feb 22 17:20:05 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fJrMn5GG5z6TT7T for ; Sun, 22 Feb 2026 17:20:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fJrMn4D6Yz3rZC for ; Sun, 22 Feb 2026 17:20:05 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771780805; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XN/7hl0RRa8zd2dbjfFyoqVMAv33jyiXhSxe4rj3m0o=; b=tzYCwrAVvbhiwIa8TVl0PLZX23ArBUcxftnqos/Hq38O/OrtlPT/MwWIlxuxzAcjDUXr7R G0i+hSVYk88bZ1/Z7aUQOIROipRVJZYDQfipQS5kN7oy0Hzx565sTDY23/mLiWEFw0Cu9F J+R8e/cXZLAJqJK1l2Qg/lmyH8LhstFVtO9OApwjNzMF7yR+Kco/41IlC4bV+0cClWkVPv KXDdISdUmQ24jCsPXQrvW20+EvfG0Cx3INR/RswOx6PM4zNB4NQas0KbWsZp+Ryit/uL62 T2HxfmJG01VhKEaG+dm/E0FHtfCfmRuRuI5vsxFDaqHrRl+a3ky6FeOOGhAUHQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1771780805; a=rsa-sha256; cv=none; b=hjLH6uH65gwAuRUWUdE6dBVjbauyGB2t3kEJEu0G1Y3ajRRj60GmykOLKktve8R7P5GfM1 JrUl/wbfOZXpN4MioGji9tKLLK4JdlsEFCeWYW9TKCuzMolCmMXlQgLEGZ2DytYHbDSyjZ /uUXbq3/1jDOlO4kwS3O/cFCDz9wziCwP+Ttq5qVQQqcj5SU78+pDTCXIQ1xfNRUfsiiIX V0RZWqlRJhYF+6fafLV8BPCyeFfPGl3j+g2domdI+2hBpOEwwp8jonJ3SmqHwn7El52tZC 9KggV0DBf7V8sHmIxG9S7hFg920Ozyi6cge6w3zz0/Aqwpvshi+57Flty/GCrg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771780805; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XN/7hl0RRa8zd2dbjfFyoqVMAv33jyiXhSxe4rj3m0o=; b=V1glRpVEdTOfQOd3Bo0uCYkjJs1+QqKXVIj0BdsuNtc9K05n96M0WFGADq1WWclXyvFBMN 7d1kxPxsiTo5WOhpQGidUnA1GbGXugmTaoiBd0OhTlPOX2B2EORWvHb1JjrwjmcXBI1mz2 IW/4DcIfLyve9VH1DHYDmwwoatqYJWYUiJRWjGR5mp0LI7Tc1a24XOkg+Eh9vS3HVvq9lm ge+Z4TeA4RnA+J79TSk2U3PSzvQE8lG260snBU81eml1jMggB3vbrPCcmpJG+6EcO8o8RJ AwcsNHmbaLDhgl7wrOcbc6424mKjp29KbylZDhJKsG6QPMtLMfpPeAi8SPQchQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fJrMn3FGJzsPM for ; Sun, 22 Feb 2026 17:20:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3844b by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 22 Feb 2026 17:20:05 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Alan Somers Subject: git: 7755a406a6ae - main - fusefs: remove the obsolete rename_lock List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: asomers X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 7755a406a6ae3801e885a79f714155f97c4d2bc6 Auto-Submitted: auto-generated Date: Sun, 22 Feb 2026 17:20:05 +0000 Message-Id: <699b3ac5.3844b.56573101@gitrepo.freebsd.org> The branch main has been updated by asomers: URL: https://cgit.FreeBSD.org/src/commit/?id=7755a406a6ae3801e885a79f714155f97c4d2bc6 commit 7755a406a6ae3801e885a79f714155f97c4d2bc6 Author: Alan Somers AuthorDate: 2026-02-10 20:45:23 +0000 Commit: Alan Somers CommitDate: 2026-02-22 17:08:27 +0000 fusefs: remove the obsolete rename_lock This lock was included in the original GSoC submission. Its purpose seems to have been to prevent concurrent FUSE_RENAME operations for the current mountpoint, as well as to synchronize FUSE_RENAME with fuse_vnode_setparent. But it's obsolete, now that ef6ea91593e added mnt_renamelock . MFC after: 2 weeks Sponsored by: ConnectWise Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D55231 --- sys/fs/fuse/fuse_ipc.c | 2 -- sys/fs/fuse/fuse_ipc.h | 2 -- sys/fs/fuse/fuse_vnops.c | 2 -- 3 files changed, 6 deletions(-) diff --git a/sys/fs/fuse/fuse_ipc.c b/sys/fs/fuse/fuse_ipc.c index f3d92d861352..c24e11a7ff2f 100644 --- a/sys/fs/fuse/fuse_ipc.c +++ b/sys/fs/fuse/fuse_ipc.c @@ -550,7 +550,6 @@ fdata_alloc(struct cdev *fdev, struct ucred *cred) TAILQ_INIT(&data->aw_head); data->daemoncred = crhold(cred); data->daemon_timeout = FUSE_DEFAULT_DAEMON_TIMEOUT; - sx_init(&data->rename_lock, "fuse rename lock"); data->ref = 1; return data; @@ -565,7 +564,6 @@ fdata_trydestroy(struct fuse_data *data) return; /* Driving off stage all that stuff thrown at device... */ - sx_destroy(&data->rename_lock); crfree(data->daemoncred); mtx_destroy(&data->aw_mtx); knlist_delete(&data->ks_rsel.si_note, curthread, 0); diff --git a/sys/fs/fuse/fuse_ipc.h b/sys/fs/fuse/fuse_ipc.h index 6fb04fd4ee25..8ceb6bb1fb1a 100644 --- a/sys/fs/fuse/fuse_ipc.h +++ b/sys/fs/fuse/fuse_ipc.h @@ -194,8 +194,6 @@ struct fuse_data { */ u_long ticketer; - struct sx rename_lock; - uint32_t fuse_libabi_major; uint32_t fuse_libabi_minor; diff --git a/sys/fs/fuse/fuse_vnops.c b/sys/fs/fuse/fuse_vnops.c index 22d5893d4fbc..49014a1cdd35 100644 --- a/sys/fs/fuse/fuse_vnops.c +++ b/sys/fs/fuse/fuse_vnops.c @@ -2272,7 +2272,6 @@ fuse_vnop_rename(struct vop_rename_args *ap) if (err) goto out; } - sx_xlock(&data->rename_lock); err = fuse_internal_rename(fdvp, fcnp, tdvp, tcnp); if (err == 0) { if (tdvp != fdvp) @@ -2280,7 +2279,6 @@ fuse_vnop_rename(struct vop_rename_args *ap) if (tvp != NULL) fuse_vnode_setparent(tvp, NULL); } - sx_unlock(&data->rename_lock); if (tvp != NULL && tvp != fvp) { cache_purge(tvp);