From nobody Sat Feb 21 08:56:24 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fJ1F50tpxz6SFjq for ; Sat, 21 Feb 2026 08:56:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fJ1F45zFdz3v90 for ; Sat, 21 Feb 2026 08:56:24 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771664184; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iDpR0reGvo2BRaR7OdEhwmJu1uZ9gAsc5X/lQUZMnw8=; b=QOCE47Ywf2VADEWU2csFNaUqW6UnrBltN9UqamwoF5HzYS3sm53LvwcdY8CVCCVSQUVG7f zu8OBMD/aq8DKocJoGOyQoohTFuyWfOWdVz84BNsNpWkLSghDrBKSJfTLLgNTFw6+lFmru 62wCB4ythvkJkP72t6Huen7XlJZrA3PB+ICnohJXuJI0/OKQoW4b8fdxASSdpqZDUOjb/4 2WIB8oVq+7Vz15TwqHoEe0GDVvSsPnRonVRkjSDqGkpcei0F08Vwkp9kYjh7za8gPye4aY MpOuNqFDcBTDGqG1YWTseH2ywx+5pDFCQvO3NlXxCWe781PhJjNxO27eTxUV2g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1771664184; a=rsa-sha256; cv=none; b=ydXWpbLGBS8+hCgbpfPZRiCM2LjDP9fUsajr7Mu3hwgwcc/LEwk2mkQOP9uDpSOR0De5G8 xU3Let6Y05BkgiWPBFDaX+0cSA/M5eRS3ASzCSbZrJiQYc3s+/QGTzMWsJrfg3UX9+gsui AqZGVUBPEyAxgSLRLBih4375tF6JBUGQqS2WZl5AxJ3/5N05O8wKlvPYmHMyoE3rj1oP6X mlN1fa0acinTRlQQ52IbSFQ9JpwUchWgiDmxbFMXBvIgbHsaeuiTIVn70FA+1lPhMYAaQ6 yeSmkYtX9CYV1EnxaVtej6cWm/Z8LmL+QWpkHF8Bi9NflEZ9lfP0Cwrw5kRJHA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771664184; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iDpR0reGvo2BRaR7OdEhwmJu1uZ9gAsc5X/lQUZMnw8=; b=SecjJHbe1RY1uyFaZv+/B+68DY+P1mD4a+BAKG6XPf0FXBzSQ372fvc15pF7r9oKT4/Ceb sYalNqHziykQFknHS8z/n47cDcI2HaegcE0iXdO6H+4OBdObM4ZRBxGpC9Ygk4xQfyFkwc HNnv1sl71M36SSpOQjbyr1A3gcHuCCN9zYwOVNwnUNEy/vBNUoO2BR8br+ozm2Wni+8FYt Gw98gPUjAuln6yDEtNXSvEf5E/3Bpp4r9N330rQ/DTsY/wDMVI9OrvWDlmg3BTpHRl3IcC j/lmiz8Fg1HbLAtH9+oUdurZBh0lhjzal+vgjn+TitQ7YQVdCQeBN19MFN5fGQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fJ1F44w5sz16N5 for ; Sat, 21 Feb 2026 08:56:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 197a5 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 21 Feb 2026 08:56:24 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Toomas Soome Subject: git: dc11af08a498 - main - loader.efi: tss_pa setup seems to be flawed in trap.c List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tsoome X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: dc11af08a4983237a90c3500ecf500ed41b0802b Auto-Submitted: auto-generated Date: Sat, 21 Feb 2026 08:56:24 +0000 Message-Id: <69997338.197a5.3c46ed07@gitrepo.freebsd.org> The branch main has been updated by tsoome: URL: https://cgit.FreeBSD.org/src/commit/?id=dc11af08a4983237a90c3500ecf500ed41b0802b commit dc11af08a4983237a90c3500ecf500ed41b0802b Author: Toomas Soome AuthorDate: 2026-02-21 08:49:34 +0000 Commit: Toomas Soome CommitDate: 2026-02-21 08:49:34 +0000 loader.efi: tss_pa setup seems to be flawed in trap.c since sd_lobase is 24 bits, we would need to shift 24 bits, not 16. Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D55178 --- stand/efi/loader/arch/amd64/trap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stand/efi/loader/arch/amd64/trap.c b/stand/efi/loader/arch/amd64/trap.c index 671321be3628..97e78ecccf22 100644 --- a/stand/efi/loader/arch/amd64/trap.c +++ b/stand/efi/loader/arch/amd64/trap.c @@ -329,7 +329,7 @@ efi_redirect_exceptions(void) free_tables(); return (0); } - tss_pa = tss_desc->sd_lobase + (tss_desc->sd_hibase << 16); + tss_pa = tss_desc->sd_lobase + (tss_desc->sd_hibase << 24); tss = (struct amd64tss *)tss_pa; tss_desc->sd_type = SDT_SYSTSS; /* unbusy */ }